From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 486D710E581 for ; Thu, 14 Sep 2023 19:15:14 +0000 (UTC) Message-ID: Date: Thu, 14 Sep 2023 21:13:47 +0200 MIME-Version: 1.0 Content-Language: en-US To: Kamil Konieczny , igt-dev@lists.freedesktop.org, Nirmoy Das , andi.shyti@intel.com References: <20230913094252.6246-1-nirmoy.das@intel.com> <20230913094252.6246-2-nirmoy.das@intel.com> <20230914133151.6rpyuaeamby4bkf4@kamilkon-desk.igk.intel.com> From: Nirmoy Das In-Reply-To: <20230914133151.6rpyuaeamby4bkf4@kamilkon-desk.igk.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_gt: Add a method to detect ggtt bind List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Kamil, On 9/14/2023 3:31 PM, Kamil Konieczny wrote: > Hi Nirmoy, > > On 2023-09-13 at 11:42:50 +0200, Nirmoy Das wrote: >> On MTL GGTT updates happens through MI_UPDATE_GGTT command. >> Add a method to detect that. >> >> Signed-off-by: Nirmoy Das >> --- >> lib/igt_gt.c | 5 +++++ >> lib/igt_gt.h | 1 + >> 2 files changed, 6 insertions(+) >> >> diff --git a/lib/igt_gt.c b/lib/igt_gt.c >> index a24a566c7..6895964a9 100644 >> --- a/lib/igt_gt.c >> +++ b/lib/igt_gt.c >> @@ -659,3 +659,8 @@ int gem_execbuf_flags_to_engine_class(unsigned int flags) >> igt_assert(0); >> } >> } >> + > Add description to public function. Makes sense, will resend with doc. Nirmoy > > Regards, > Kamil > >> +bool gem_has_ggtt_bind(int fd) >> +{ >> + return IS_METEORLAKE(intel_get_drm_devid(fd)); >> +} >> diff --git a/lib/igt_gt.h b/lib/igt_gt.h >> index 3d10349e4..7d35a209d 100644 >> --- a/lib/igt_gt.h >> +++ b/lib/igt_gt.h >> @@ -83,5 +83,6 @@ extern const struct intel_execution_engine2 { >> } intel_execution_engines2[]; >> >> int gem_execbuf_flags_to_engine_class(unsigned int flags); >> +bool gem_has_ggtt_bind(int fd); >> >> #endif /* IGT_GT_H */ >> -- >> 2.41.0 >>