Re: [PATCH 1/4] tests/xe_pat: add userptr-comp PAT test

[Matthew Auld <matthew.auld@intel.com>]

On 07/01/2026 05:24, Xin Wang wrote:
> Add a new xe_pat subtest that iterates the debugfs PAT table and
> validates that userptr bindings are rejected for PAT entries
> enabling compression and for COH_MODE_NONE entries.
> 
> Expected failures return -EINVAL.
> 
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Xin Wang <x.wang@intel.com>

Nit: I think commit title should be "tests/intel/xe_pat:"

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> ---
>   tests/intel/xe_pat.c | 61 ++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 61 insertions(+)
> 
> diff --git a/tests/intel/xe_pat.c b/tests/intel/xe_pat.c
> index a7f8ab088..5ad4922dd 100644
> --- a/tests/intel/xe_pat.c
> +++ b/tests/intel/xe_pat.c
> @@ -887,6 +887,64 @@ static void bo_comp_disable_bind(int fd)
>   	xe_vm_destroy(fd, vm);
>   }
>   
> +/**
> + * SUBTEST: userptr-comp
> + * Test category: functionality test
> + * Description: Validate that userptr mappings cannot be bound with a PAT index
> + * that enables compression (expected to fail with -EINVAL).
> + */
> +static void userptr_comp(int fd)
> +{
> +	size_t size = xe_get_default_alignment(fd);
> +	uint16_t dev_id = intel_get_drm_devid(fd);
> +	struct intel_pat_cache pat_sw_config = {};
> +	int32_t parsed;
> +	uint32_t vm;
> +	void *data;
> +
> +	igt_require(intel_get_device_info(dev_id)->graphics_ver >= 20);
> +
> +	parsed = xe_fetch_pat_sw_config(fd, &pat_sw_config);
> +
> +	data = mmap(0, size, PROT_READ | PROT_WRITE,
> +		    MAP_SHARED | MAP_ANONYMOUS, -1, 0);
> +	igt_assert(data != MAP_FAILED);
> +
> +	vm = xe_vm_create(fd, 0, 0);
> +
> +	for (int i = 0; i < parsed; i++) {
> +		uint32_t pat;
> +		uint32_t coh_mode;
> +		bool compressed;
> +		uint64_t va;
> +		int expected;
> +		int ret;
> +
> +		if (pat_sw_config.entries[i].rsvd)
> +			continue;
> +		pat = pat_sw_config.entries[i].pat;
> +		compressed = !!(pat & XE2_COMP_EN);
> +		coh_mode = REG_FIELD_GET(XE2_COH_MODE, pat);
> +
> +		/* Spread VAs to keep each attempt independent. */
> +		va = 0x40000ull + (uint64_t)i * 0x200000ull;
> +
> +		if (compressed || coh_mode == COH_MODE_NONE)
> +			expected = -EINVAL;
> +		else
> +			expected = 0;
> +		ret = __xe_vm_bind(fd, vm, 0, 0, to_user_pointer(data), va,
> +				   size, DRM_XE_VM_BIND_OP_MAP_USERPTR, 0, NULL, 0, 0,
> +				   i, 0);
> +		igt_assert_eq(ret, expected);
> +		if (!ret)
> +			xe_vm_unbind_sync(fd, vm, 0, va, size);
> +	}
> +
> +	munmap(data, size);
> +	xe_vm_destroy(fd, vm);
> +}
> +
>   /**
>    * SUBTEST: display-vs-wb-transient
>    * Test category: functionality test
> @@ -1317,6 +1375,9 @@ int igt_main_args("V", NULL, help_str, opt_handler, NULL)
>   	igt_subtest("userptr-coh-none")
>   		userptr_coh_none(fd);
>   
> +	igt_subtest("userptr-comp")
> +		userptr_comp(fd);
> +
>   	igt_subtest("prime-self-import-coh")
>   		prime_self_import_coh();
>