From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E2BB6E264 for ; Mon, 18 May 2020 19:06:29 +0000 (UTC) From: "Souza, Jose" Date: Mon, 18 May 2020 19:06:27 +0000 Message-ID: References: <20181213105734.32617-1-ville.syrjala@linux.intel.com> <20200515143857.21222-1-ville.syrjala@linux.intel.com> In-Reply-To: <20200515143857.21222-1-ville.syrjala@linux.intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2] lib/debugfs: Sanity check even discarded CRCs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "ville.syrjala@linux.intel.com" , "igt-dev@lists.freedesktop.org" Cc: "Pandiyan, Dhinakaran" List-ID: T24gRnJpLCAyMDIwLTA1LTE1IGF0IDE3OjM4ICswMzAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOg0K PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPg0K PiANCj4gV2UgY3VycmVudGx5IG9ubHkgc3BvdCBjaGVjayBzb21lIG9mIHRoZSBDUkNzLiBXZSBz aG91bGQgY2hlY2sgdGhlbQ0KPiBhbGwuIFRoaXMgd2lsbCBwcm9iYWJseSBjYXVzZSBmYWlsdXJl cyBvbiBtYWNoaW5lcyB3aXRoIFBTUiBhcw0KPiBpdCBsb29rcyBsaWtlIHRoZSBDUkMgY2FwdHVy ZWQgYWZ0ZXIgUFNSIGV4aXQgaXMgYm9ndXMuIE9yIGF0IGxlYXN0DQo+IGl0IGlzIG9uIElDTC4g V2Ugc2hvdWxkIHByb2JhYmx5IGp1c3QgZGlzYWJsZSBQU1Igd2hlbmV2ZXIgQ1JDDQo+IGNhcHR1 cmluZyBpcyBhY3RpdmUuDQoNClRoZXJlIHdhcyBzb21lIFBTUiBjaGFuZ2VzIGFyb3VuZCBDUkMs IGl0IHNob3VsZCBub3QgYmUgYSBwcm9ibGVtIGFueW1vcmUuDQoNCj4gDQo+IHYyOiBSZWJhc2UN Cj4gDQoNClJldmlld2VkLWJ5OiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNvdXphQGlu dGVsLmNvbT4NCg0KPiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRl bC5jb20+DQo+IFJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBh bmRpeWFuQGludGVsLmNvbT4gI3YxDQo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVz a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNjk3NA0KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPg0KPiAtLS0NCj4gIGxpYi9p Z3RfZGVidWdmcy5jIHwgNDcgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlv bnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2RlYnVnZnMuYyBiL2xpYi9pZ3RfZGVi dWdmcy5jDQo+IGluZGV4IDA1MDY3MDc4NTJmMC4uNzM5NzVmOTIyZTE5IDEwMDY0NA0KPiAtLS0g YS9saWIvaWd0X2RlYnVnZnMuYw0KPiArKysgYi9saWIvaWd0X2RlYnVnZnMuYw0KPiBAQCAtNzU5 LDYgKzc1OSwyNiBAQCBzdGF0aWMgYm9vbCBwaXBlX2NyY19pbml0X2Zyb21fc3RyaW5nKGlndF9w aXBlX2NyY190ICpwaXBlX2NyYywgaWd0X2NyY190ICpjcmMsDQo+ICAJcmV0dXJuIHRydWU7DQo+ ICB9DQo+ICANCj4gK3N0YXRpYyB2b2lkIGNyY19zYW5pdHlfY2hlY2tzKGlndF9waXBlX2NyY190 ICpwaXBlX2NyYywgaWd0X2NyY190ICpjcmMpDQo+ICt7DQo+ICsJYm9vbCBhbGxfemVybyA9IHRy dWU7DQo+ICsNCj4gKwkvKiBBbnkgQ1JDIHZhbHVlIGNhbiBiZSBjb25zaWRlcmVkIHZhbGlkIG9u IGFtZGdwdSBoYXJkd2FyZS4gKi8NCj4gKwlpZiAoaXNfYW1kZ3B1X2RldmljZShwaXBlX2NyYy0+ ZmQpKQ0KPiArCQlyZXR1cm47DQo+ICsNCj4gKwlmb3IgKGludCBpID0gMDsgaSA8IGNyYy0+bl93 b3JkczsgaSsrKSB7DQo+ICsJCWlndF93YXJuX29uX2YoY3JjLT5jcmNbaV0gPT0gMHhmZmZmZmZm ZiwNCj4gKwkJCSAgICAgICJTdXNwaWNpb3VzIENSQzogaXQgbG9va3MgbGlrZSB0aGUgQ1JDICIN Cj4gKwkJCSAgICAgICJyZWFkIGJhY2sgd2FzIGZyb20gYSByZWdpc3RlciBpbiBhIHBvd2VyZWQg Ig0KPiArCQkJICAgICAgImRvd24gd2VsbFxuIik7DQo+ICsJCWlmIChjcmMtPmNyY1tpXSkNCj4g KwkJCWFsbF96ZXJvID0gZmFsc2U7DQo+ICsJfQ0KPiArDQo+ICsJaWd0X3dhcm5fb25fZihhbGxf emVybywgIlN1c3BpY2lvdXMgQ1JDOiBBbGwgdmFsdWVzIGFyZSAwLlxuIik7DQo+ICt9DQo+ICsN Cj4gIHN0YXRpYyBpbnQgcmVhZF9jcmMoaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjLCBpZ3RfY3Jj X3QgKm91dCkNCj4gIHsNCj4gIAlzc2l6ZV90IGJ5dGVzX3JlYWQ7DQo+IEBAIC03NzYsNiArNzk2 LDggQEAgc3RhdGljIGludCByZWFkX2NyYyhpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9j cmNfdCAqb3V0KQ0KPiAgCWlmIChieXRlc19yZWFkID4gMCAmJiAhcGlwZV9jcmNfaW5pdF9mcm9t X3N0cmluZyhwaXBlX2NyYywgb3V0LCBidWYpKQ0KPiAgCQlyZXR1cm4gLUVJTlZBTDsNCj4gIA0K PiArCWNyY19zYW5pdHlfY2hlY2tzKHBpcGVfY3JjLCBvdXQpOw0KPiArDQo+ICAJcmV0dXJuIGJ5 dGVzX3JlYWQ7DQo+ICB9DQo+ICANCj4gQEAgLTg4NSwyNyArOTA3LDYgQEAgaWd0X3BpcGVfY3Jj X2dldF9jcmNzKGlndF9waXBlX2NyY190ICpwaXBlX2NyYywgaW50IG5fY3JjcywNCj4gIAlyZXR1 cm4gbjsNCj4gIH0NCj4gIA0KPiAtc3RhdGljIHZvaWQgY3JjX3Nhbml0eV9jaGVja3MoaWd0X3Bp cGVfY3JjX3QgKnBpcGVfY3JjLCBpZ3RfY3JjX3QgKmNyYykNCj4gLXsNCj4gLQlpbnQgaTsNCj4g LQlib29sIGFsbF96ZXJvID0gdHJ1ZTsNCj4gLQ0KPiAtCS8qIEFueSBDUkMgdmFsdWUgY2FuIGJl IGNvbnNpZGVyZWQgdmFsaWQgb24gYW1kZ3B1IGhhcmR3YXJlLiAqLw0KPiAtCWlmIChpc19hbWRn cHVfZGV2aWNlKHBpcGVfY3JjLT5mZCkpDQo+IC0JCXJldHVybjsNCj4gLQ0KPiAtCWZvciAoaSA9 IDA7IGkgPCBjcmMtPm5fd29yZHM7IGkrKykgew0KPiAtCQlpZ3Rfd2Fybl9vbl9mKGNyYy0+Y3Jj W2ldID09IDB4ZmZmZmZmZmYsDQo+IC0JCQkgICAgICAiU3VzcGljaW91cyBDUkM6IGl0IGxvb2tz IGxpa2UgdGhlIENSQyAiDQo+IC0JCQkgICAgICAicmVhZCBiYWNrIHdhcyBmcm9tIGEgcmVnaXN0 ZXIgaW4gYSBwb3dlcmVkICINCj4gLQkJCSAgICAgICJkb3duIHdlbGxcbiIpOw0KPiAtCQlpZiAo Y3JjLT5jcmNbaV0pDQo+IC0JCQlhbGxfemVybyA9IGZhbHNlOw0KPiAtCX0NCj4gLQ0KPiAtCWln dF93YXJuX29uX2YoYWxsX3plcm8sICJTdXNwaWNpb3VzIENSQzogQWxsIHZhbHVlcyBhcmUgMC5c biIpOw0KPiAtfQ0KPiAtDQo+ICAvKioNCj4gICAqIGlndF9waXBlX2NyY19kcmFpbjoNCj4gICAq IEBwaXBlX2NyYzogcGlwZSBDUkMgb2JqZWN0DQo+IEBAIC05NDYsOCArOTQ3LDYgQEAgdm9pZCBp Z3RfcGlwZV9jcmNfZHJhaW4oaWd0X3BpcGVfY3JjX3QgKnBpcGVfY3JjKQ0KPiAgdm9pZCBpZ3Rf cGlwZV9jcmNfZ2V0X3NpbmdsZShpZ3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsIGlndF9jcmNfdCAq Y3JjKQ0KPiAgew0KPiAgCXJlYWRfb25lX2NyYyhwaXBlX2NyYywgY3JjKTsNCj4gLQ0KPiAtCWNy Y19zYW5pdHlfY2hlY2tzKHBpcGVfY3JjLCBjcmMpOw0KPiAgfQ0KPiAgDQo+ICAvKioNCj4gQEAg LTk3NCw4ICs5NzMsNiBAQCBpZ3RfcGlwZV9jcmNfZ2V0X2Zvcl9mcmFtZShpbnQgZHJtX2ZkLCBp Z3RfcGlwZV9jcmNfdCAqcGlwZV9jcmMsDQo+ICAJCQlyZXR1cm47DQo+ICAJCX0NCj4gIAl9IHdo aWxlIChpZ3RfdmJsYW5rX2JlZm9yZShjcmMtPmZyYW1lLCB2YmxhbmspKTsNCj4gLQ0KPiAtCWNy Y19zYW5pdHlfY2hlY2tzKHBpcGVfY3JjLCBjcmMpOw0KPiAgfQ0KPiAgDQo+ICAvKioNCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGlu ZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=