public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Petri Latvala <petri.latvala@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] runner: Reset disk usage tracking on subtest change
Date: Tue, 29 Nov 2022 22:21:04 +0200	[thread overview]
Message-ID: <d4e9db25-8be7-45b7-601a-b3ac64707d46@gmail.com> (raw)
In-Reply-To: <20221129083427.2687430-1-petri.latvala@intel.com>

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 29.11.2022 10.34, Petri Latvala wrote:
> Disk space usage tracking is supposed to be per (dynamic)
> subtest. Remember to reset the usage tracker when subtest changes.
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arek@hiler.eu>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>   runner/executor.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/runner/executor.c b/runner/executor.c
> index 2feef2c9..d2253082 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -1101,7 +1101,6 @@ static int monitor_output(pid_t child,
>   				}
>   
>   				write_packet_with_canary(outputs[_F_SOCKET], packet, settings->sync);
> -				disk_usage += packet->size;
>   
>   				/*
>   				 * runner sends EXEC itself before executing
> @@ -1112,8 +1111,12 @@ static int monitor_output(pid_t child,
>   					socket_comms_used = true;
>   
>   				if (packet->type == PACKETTYPE_SUBTEST_START ||
> -				    packet->type == PACKETTYPE_DYNAMIC_SUBTEST_START)
> +				    packet->type == PACKETTYPE_DYNAMIC_SUBTEST_START) {
>   					time_last_subtest = time_now;
> +					disk_usage = 0;
> +				}
> +
> +				disk_usage += packet->size;
>   
>   				if (settings->log_level >= LOG_LEVEL_VERBOSE) {
>   					runnerpacket_read_helper helper = {};

      parent reply	other threads:[~2022-11-29 20:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  8:34 [igt-dev] [PATCH i-g-t] runner: Reset disk usage tracking on subtest change Petri Latvala
2022-11-29  9:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-29 11:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-11-29 20:21 ` Juha-Pekka Heikkila [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4e9db25-8be7-45b7-601a-b3ac64707d46@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox