From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E6FB6E670 for ; Thu, 6 Dec 2018 21:43:11 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id y78so1270316qka.12 for ; Thu, 06 Dec 2018 13:43:11 -0800 (PST) Message-ID: From: Lyude Paul Date: Thu, 06 Dec 2018 16:43:07 -0500 In-Reply-To: <20181206141132.23349-2-paul.kocialkowski@bootlin.com> References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-2-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/9] chamelium: Pass dimensions instead of mode to pattern generation helper List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: QXJlIHRoZXJlIHNvbWUgcGF0Y2hlcyBtaXNzaW5nIGhlcmU/IFRoaXMgZG9lc24ndCBzZWVtIHRv IGFwcGx5IGNsZWFubHkgdG8KbWFzdGVyLCBhbmQgaXQgbG9va3MgbGlrZSB0aGlzIGlzIHJlbHlp bmcgb24gc29tZSBjaGFuZ2VzIHRvCmNoYW1lbGl1bV9wYWludF94cjI0X3BhdHRlcm4oKSB0aGF0 IGFyZW4ndCBpbiB0aGUgdHJlZQoKKG90aGVyd2lzZSwgdGhpcyBwYXRjaCBsZ3RtLCBSZXZpZXdl ZC1ieTogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4pCgpPbiBUaHUsIDIwMTgtMTItMDYg YXQgMTU6MTEgKzAxMDAsIFBhdWwgS29jaWFsa293c2tpIHdyb3RlOgo+IEluIG9yZGVyIHRvIHJl dXNlIHRoZSBwYXR0ZXJuIGdlbmVyYXRpb24gaGVscGVyIGZvciBvdmVybGF5IHBsYW5lcywKPiBs ZXQncyBwcm92aWRlIHRoZSBwYXR0ZXJuIGdlbmVyYXRpb24gaGVscGVyIHdpdGggdGhlIGV4cGxp Y2l0IGRpbWVuc2lvbnMKPiBpbnN0ZWFkIG9mIHRoZSBtb2RlICh0aGF0IG9ubHkgYXBwbGllcyB0 byB0aGUgcHJpbWFyeSBwbGFuZSkuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bCBLb2NpYWxrb3dz a2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tPgo+IC0tLQo+ICB0ZXN0cy9rbXNfY2hh bWVsaXVtLmMgfCAxMSArKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25z KCspLCA2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfY2hhbWVsaXVt LmMgYi90ZXN0cy9rbXNfY2hhbWVsaXVtLmMKPiBpbmRleCA4YTlmNmJmZS4uYjhjYWI5MjcgMTAw NjQ0Cj4gLS0tIGEvdGVzdHMva21zX2NoYW1lbGl1bS5jCj4gKysrIGIvdGVzdHMva21zX2NoYW1l bGl1bS5jCj4gQEAgLTUwNCw3ICs1MDQsNyBAQCBzdGF0aWMgdm9pZCBjaGFtZWxpdW1fcGFpbnRf eHIyNF9wYXR0ZXJuKHVpbnQzMl90ICpkYXRhLAo+ICAJCQkqKGRhdGEgKyBpICogc3RyaWRlIC8g NCArIGopID0gY29sb3JzWygoaiAvIDY0KSArIChpIC8KPiA2NCkpICUgNV07Cj4gIH0KPiAgCj4g LXN0YXRpYyBpbnQgY2hhbWVsaXVtX2dldF9wYXR0ZXJuX2ZiKGRhdGFfdCAqZGF0YSwgZHJtTW9k ZU1vZGVJbmZvICptb2RlLAo+ICtzdGF0aWMgaW50IGNoYW1lbGl1bV9nZXRfcGF0dGVybl9mYihk YXRhX3QgKmRhdGEsIHNpemVfdCB3aWR0aCwgc2l6ZV90Cj4gaGVpZ2h0LAo+ICAJCQkJICAgIHVp bnQzMl90IGZvdXJjYywgc3RydWN0IGlndF9mYiAqZmIpCj4gIHsKPiAgCWludCBmYl9pZDsKPiBA QCAtNTEyLDE1ICs1MTIsMTQgQEAgc3RhdGljIGludCBjaGFtZWxpdW1fZ2V0X3BhdHRlcm5fZmIo ZGF0YV90ICpkYXRhLAo+IGRybU1vZGVNb2RlSW5mbyAqbW9kZSwKPiAgCj4gIAlpZ3RfYXNzZXJ0 KGZvdXJjYyA9PSBEUk1fRk9STUFUX1hSR0I4ODg4KTsKPiAgCj4gLQlmYl9pZCA9IGlndF9jcmVh dGVfZmIoZGF0YS0+ZHJtX2ZkLCBtb2RlLT5oZGlzcGxheSwgbW9kZS0+dmRpc3BsYXksCj4gLQkJ CSAgICAgIGZvdXJjYywgTE9DQUxfRFJNX0ZPUk1BVF9NT0RfTk9ORSwgZmIpOwo+ICsJZmJfaWQg PSBpZ3RfY3JlYXRlX2ZiKGRhdGEtPmRybV9mZCwgd2lkdGgsIGhlaWdodCwgZm91cmNjLAo+ICsJ CQkgICAgICBMT0NBTF9EUk1fRk9STUFUX01PRF9OT05FLCBmYik7Cj4gIAlpZ3RfYXNzZXJ0KGZi X2lkID4gMCk7Cj4gIAo+ICAJcHRyID0gaWd0X2ZiX21hcF9idWZmZXIoZmItPmZkLCBmYik7Cj4g IAlpZ3RfYXNzZXJ0KHB0cik7Cj4gIAo+IC0JY2hhbWVsaXVtX3BhaW50X3hyMjRfcGF0dGVybihw dHIsIG1vZGUtPmhkaXNwbGF5LCBtb2RlLT52ZGlzcGxheSwKPiAtCQkJCSAgICAgZmItPnN0cmlk ZXNbMF0pOwo+ICsJY2hhbWVsaXVtX3BhaW50X3hyMjRfcGF0dGVybihwdHIsIHdpZHRoLCBoZWln aHQsIGZiLT5zdHJpZGVzWzBdKTsKPiAgCWlndF9mYl91bm1hcF9idWZmZXIoZmIsIHB0cik7Cj4g IAo+ICAJcmV0dXJuIGZiX2lkOwo+IEBAIC01NDEsNyArNTQwLDcgQEAgc3RhdGljIHZvaWQgZG9f dGVzdF9kaXNwbGF5KGRhdGFfdCAqZGF0YSwgc3RydWN0Cj4gY2hhbWVsaXVtX3BvcnQgKnBvcnQs Cj4gIAlpbnQgaSwgZmJfaWQsIGNhcHR1cmVkX2ZyYW1lX2NvdW50Owo+ICAJaW50IGZyYW1lX2lk Owo+ICAKPiAtCWZiX2lkID0gY2hhbWVsaXVtX2dldF9wYXR0ZXJuX2ZiKGRhdGEsIG1vZGUsCj4g KwlmYl9pZCA9IGNoYW1lbGl1bV9nZXRfcGF0dGVybl9mYihkYXRhLCBtb2RlLT5oZGlzcGxheSwg bW9kZS0+dmRpc3BsYXksCj4gIAkJCQkJIERSTV9GT1JNQVRfWFJHQjg4ODgsICZmYik7Cj4gIAlp Z3RfYXNzZXJ0KGZiX2lkID4gMCk7Cj4gIAotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==