From: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] Move some gem tests to benchmarks
Date: Mon, 5 Feb 2018 13:40:35 +0200 [thread overview]
Message-ID: <d5aa4df6-d983-9065-7947-846126b09644@linux.intel.com> (raw)
In-Reply-To: <151782485023.15322.16701599894221010018@mail.alporthouse.com>
On 02/05/2018 12:00 PM, Chris Wilson wrote:
> Quoting Abdiel Janulgue (2018-02-05 09:35:19)
>> Some of the gem tests actually look like benchmarks. Move them to their
>> proper place. Also improve gem_gtt_speed by adding a post-suspend
>> benchmark.
>
> You can't just move them wholesale into benchmarks/ without weaning them
> off libigt, they were not even supposed to be linked against libigt.la.
> libigt was expressly developed with the purpose of making writing tests
> easier and that gets in the way of the benchmarks. That is not to say
> the core ioctl wrappers are not useful, it's just all the logging and
> subtest framework built above them that has all too often caused
> explosions and get in the way.
>
> Say no to igt_subtest, but welcome a new igt_perf. And ezbench
> integration.
Looks like another upcoming lib. Will try to update accordingly...
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-02-05 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 9:35 [igt-dev] [PATCH i-g-t] Move some gem tests to benchmarks Abdiel Janulgue
2018-02-05 9:35 ` [igt-dev] [PATCH i-g-t 1/6] tests/gem_exec_latency: Move " Abdiel Janulgue
2018-02-05 9:35 ` [igt-dev] [PATCH i-g-t 2/6] tests/gem_exec_lut_handle: " Abdiel Janulgue
2018-02-05 9:35 ` [igt-dev] [PATCH i-g-t 3/6] tests/gem_read_read_speed: " Abdiel Janulgue
2018-02-05 9:35 ` [igt-dev] [PATCH i-g-t 4/6] tests/gem_fence_upload: " Abdiel Janulgue
2018-02-05 9:35 ` [igt-dev] [PATCH i-g-t 5/6] tests/gem_gtt_speed: " Abdiel Janulgue
2018-02-05 9:46 ` Chris Wilson
2018-02-05 9:35 ` [igt-dev] [PATCH i-g-t 6/6] benchmarks/gtt_speed: Add a subtest to compare post suspend speed Abdiel Janulgue
2018-02-05 9:43 ` [igt-dev] [PATCH i-g-t] Move some gem tests to benchmarks Chris Wilson
2018-02-05 9:52 ` Abdiel Janulgue
2018-02-05 10:00 ` Chris Wilson
2018-02-05 11:40 ` Abdiel Janulgue [this message]
2018-02-05 11:13 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/6] tests/gem_exec_latency: Move " Patchwork
2018-02-05 12:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5aa4df6-d983-9065-7947-846126b09644@linux.intel.com \
--to=abdiel.janulgue@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox