From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 598F010F62E for ; Fri, 29 Apr 2022 04:40:59 +0000 (UTC) From: "Gupta, Anshuman" To: "Tauro, Riana" , "igt-dev@lists.freedesktop.org" Date: Fri, 29 Apr 2022 04:40:58 +0000 Message-ID: References: <20220425122147.1141783-1-riana.tauro@intel.com> <20220425122147.1141783-2-riana.tauro@intel.com> In-Reply-To: <20220425122147.1141783-2-riana.tauro@intel.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/2] tests/i915/i915_suspend: Add s2idle and s3 subtests without i915 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: > -----Original Message----- > From: Tauro, Riana > Sent: Monday, April 25, 2022 5:52 PM > To: igt-dev@lists.freedesktop.org > Cc: Tauro, Riana ; Gupta, Anshuman > > Subject: [PATCH i-g-t 1/2] tests/i915/i915_suspend: Add s2idle and s3 sub= tests > without i915 >=20 > From: "Tauro, Riana" >=20 > Add new tests basic-s2idle-without-i915 and basic-s3-without-i915 to exer= cise > s2idle and s3 cycles to know the system wide health of suspend/resume >=20 > Signed-off-by: Tauro, Riana > --- > tests/i915/i915_suspend.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) >=20 > diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c index > d34b7a5d..8203b806 100644 > --- a/tests/i915/i915_suspend.c > +++ b/tests/i915/i915_suspend.c > @@ -204,12 +204,12 @@ test_forcewake(int fd, bool hibernate) } >=20 > static void > -test_suspend_without_i915(void) > +test_suspend_without_i915(int state) > { > igt_kmsg(KMSG_INFO "Unloading i915\n"); > igt_assert_eq(igt_i915_driver_unload(),0); >=20 > - igt_system_suspend_autoresume(SUSPEND_STATE_MEM, > SUSPEND_TEST_NONE); > + igt_system_suspend_autoresume(state, SUSPEND_TEST_NONE); >=20 > igt_kmsg(KMSG_INFO "Re-loading i915 \n"); > igt_assert_eq(igt_i915_driver_load(NULL), 0); @@ -219,9 +219,13 @@ > int fd; >=20 > igt_main > { > - igt_describe("Validate system suspend cycle without i915 module"); > - igt_subtest("system-suspend-without-i915") > - test_suspend_without_i915(); > + igt_describe("Validate suspend-to-idle without i915 module"); > + igt_subtest("basic-s2idle-without-i915") > + test_suspend_without_i915(SUSPEND_STATE_FREEZE); > + > + igt_describe("Validate S3 without i915 module"); > + igt_subtest("basic-s3-without-i915") > + test_suspend_without_i915(SUSPEND_STATE_MEM); Looks Good to me. Reviewed-by: Anshuman Gupta >=20 > igt_fixture > fd =3D drm_open_driver(DRIVER_INTEL); > -- > 2.25.1