Re: [PATCH i-g-t v3 07/10] tools/vbt_decode: validate DEVICE env var

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 15 Jun 2026, Michał Grzelak <michal.grzelak@intel.com> wrote:
> On error, strotoul() returns converted value of longest substring
> spanning from beginning. Check if device ID input via DEVICE env var is
> valid. Show it and return if it is not.
>
> v2->v3
> - show whole invalid DEVICE env var (Jani)
>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  tools/intel_vbt_decode.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index a2e57206d6..33f8598e5f 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -4326,8 +4326,14 @@ int main(int argc, char **argv)
>  
>  	if (!context.devid) {
>  		const char *devid_string = getenv("DEVICE");
> -		if (devid_string)
> -			context.devid = strtoul(devid_string, NULL, 16);
> +		if (devid_string) {
> +			context.devid = strtoul(devid_string, &endp, 16);
> +			if (!context.devid || *endp) {
> +				fprintf(stderr, "invalid devid '%s' in DEVICE environment variable\n",
> +					devid_string);
> +				return EXIT_FAILURE;
> +			}
> +		}
>  	}
>  	if (!context.devid)
>  		context.devid = get_device_id(VBIOS, size);

-- 
Jani Nikula, Intel