Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Grzegorzek, Dominik" <dominik.grzegorzek@intel.com>
To: "Kempczynski, Zbigniew" <zbigniew.kempczynski@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] intel_compute: Use valid number of array size for unbind
Date: Mon, 25 Nov 2024 09:58:27 +0000	[thread overview]
Message-ID: <d8100bbd251774db0ff72a35b422afdf2d28a1e7.camel@intel.com> (raw)
In-Reply-To: <20241122102931.210761-1-zbigniew.kempczynski@intel.com>

On Fri, 2024-11-22 at 11:29 +0100, Zbigniew Kempczyński wrote:
> Due to copy-paste number of elements for unbind is wrong for xe2.
> Fix this as it should be paired with bind.
> 
> This is likely subject for refactor and use ARRAY_SIZE() but at the
> moment it's a quickfix. Luckily number or entries value was smaller
> than for bind so we didn't notice the failure, only there were some
> dangling vmas in the vm.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

Good spot. It is:
Reviewed-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
>  lib/intel_compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 3ab9ace793..879928ab64 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -1406,7 +1406,7 @@ static void xe2lpg_compute_exec(int fd, const unsigned char *kernel,
>  		igt_assert(f1 == f2 * f2);
>  	}
>  
> -	bo_execenv_unbind(&execenv, bo_dict, XEHPC_BO_DICT_ENTRIES);
> +	bo_execenv_unbind(&execenv, bo_dict, XE2_BO_DICT_ENTRIES);
>  	bo_execenv_destroy(&execenv);
>  }
>  


  parent reply	other threads:[~2024-11-25  9:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 10:29 [PATCH i-g-t] intel_compute: Use valid number of array size for unbind Zbigniew Kempczyński
2024-11-22 16:09 ` ✓ Xe.CI.BAT: success for " Patchwork
2024-11-22 16:25 ` ✓ i915.CI.BAT: " Patchwork
2024-11-23 15:32 ` ✗ Xe.CI.Full: failure " Patchwork
2024-11-25  7:16   ` Zbigniew Kempczyński
2024-11-24 18:49 ` ✗ i915.CI.Full: " Patchwork
2024-11-25  7:17   ` Zbigniew Kempczyński
2024-11-25  9:58 ` Grzegorzek, Dominik [this message]
2024-11-25 13:36 ` [PATCH i-g-t] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8100bbd251774db0ff72a35b422afdf2d28a1e7.camel@intel.com \
    --to=dominik.grzegorzek@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox