public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t v2 00/23] tests/kms: More igt_crtc_t conversions
@ 2026-02-21  3:19 Ville Syrjala
  2026-02-21  3:19 ` [PATCH i-g-t v2 01/23] tests/intel/kms_psr: Don't pass uninitialized 'pipe' to intel_fbc_supported_on_chipset() Ville Syrjala
                   ` (30 more replies)
  0 siblings, 31 replies; 64+ messages in thread
From: Ville Syrjala @ 2026-02-21  3:19 UTC (permalink / raw)
  To: igt-dev

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Convert more tests to track/pass around igt_crtc_t instead of
enum pipe.

This gets rid of most 'enum pipe' typed variables under tests/.
The remaining ones are:
* active_pipes[] array
  - kms_vblank
  - kms_plane_alpha_blend
  - kms_pipe_crc_basic
  - kms_cursor_edge_walk
  - kms_cursor_crc
* incorrect pipe usage for igt_debugfs_crtc_dir()
  - kms_frontbuffer_tracking
* the big mess that still needs to be sorted:
  - kms_joiner*

Additionally a lot of crtc->pipe usage still remains:
- some will disappear once all external igt_kms functions get
  converted to igt_crtc_t. I still plan to send at least one
  cocci series for that
- some need to be converted to crtc->crtc_index for correctness
- some are used for local array indexing which probably should also
  be converted to crtc_index (or some other sensible thing)
- what should remain in the end are the actual crtc->pipe vs. PIPE_?
  comparisons used for hardware specific quirks and whatnot

v2: Deal with pre-existing kms_psr* intel_fbc_supported_on_chipset() bugs

Ville Syrjälä (23):
  tests/intel/kms_psr: Don't pass uninitialized 'pipe' to
    intel_fbc_supported_on_chipset()
  tests/intel/kms_psr2_sf: Don't pass zero initialized 'data.pipe' to
    intel_fbc_supported_on_chipset()
  tests/intel/kms_flip_scaled_crc: Remove unused 'enum pipe pipe'
  tests/kms_concurrent: Actually run the test over all connected crtcs
  tests/amdgpu/amd_abm: Don't use uninitialized 'pipe'
  tests/kms: Use 'enum pipe' over int'
  lib/kms: Add igt_crtc_for_crtc_id()
  tests/kms_lease: Use igt_crtc_t instead of enum pipe
  tests/kms_lease: Pass lease_t to prepare_crtc()
  tests/intel/kms_frontbuffer_tracking: Use igt_crtc_t instead of enum
    pipe
  tests/kms_plane_scaling: Use igt_crtc_t instead of enum pipe
  tests/drm_read: Use igt_crtc_t instead of enum pipe
  tests/intel/kms_psr2_sf: Convert pipes[] to crtcs[]
  tests/kms_vblank: Use igt_crtc_t instead of enum pipe
  tests/kms_plane_multiple: Use igt_crtc_t instead of enum pipe
  tests/kms_tiled_display: Use igt_crtc_t instead of enum pipe
  tests/intel/kms_psr: Use igt_crtc_t instead of enum pipe
  tests/kms_prime: Use igt_crtc_t instead of enum pipe
  tests/chamelium: Use igt_crtc_t instead of enum pipe
  tests/kms: Use igt_crtc_t instead of enum pipe, part 1
  tests/kms: Use igt_crtc_t instead of enum pipe, part 2
  tests/kms: Use igt_crtc_t instead of enum pipe, part 3
  tests/kms: Use igt_crtc_t instead of enum pipe, part 4

 lib/igt_kms.c                                 |  12 ++
 lib/igt_kms.h                                 |   1 +
 tests/amdgpu/amd_abm.c                        |  34 +++---
 tests/amdgpu/amd_bypass.c                     |   7 +-
 tests/amdgpu/amd_color.c                      |   7 +-
 tests/amdgpu/amd_cursor_overlay.c             |  28 ++---
 tests/amdgpu/amd_dp_dsc.c                     |  12 +-
 tests/amdgpu/amd_hotplug.c                    |   4 +-
 tests/amdgpu/amd_ilr.c                        |   8 +-
 tests/amdgpu/amd_link_settings.c              |   8 +-
 tests/amdgpu/amd_mall.c                       |   4 +-
 tests/amdgpu/amd_max_bpc.c                    |   6 +-
 tests/amdgpu/amd_mem_leak.c                   |   4 +-
 tests/amdgpu/amd_odm.c                        |   4 +-
 tests/amdgpu/amd_plane.c                      |  14 +--
 tests/amdgpu/amd_psr.c                        |  23 ++--
 tests/amdgpu/amd_replay.c                     |   7 +-
 tests/amdgpu/amd_subvp.c                      |   4 +-
 tests/chamelium/kms_chamelium_edid.c          |  13 +-
 tests/chamelium/kms_chamelium_helper.c        |  10 +-
 tests/chamelium/kms_chamelium_helper.h        |   2 +-
 tests/chamelium/kms_chamelium_hpd.c           |   8 +-
 .../kms_chamelium_sharpness_filter.c          |  35 +++---
 tests/drm_read.c                              |  36 +++---
 tests/intel/kms_big_fb.c                      |  28 ++---
 tests/intel/kms_ccs.c                         |   8 +-
 tests/intel/kms_cdclk.c                       |  16 ++-
 tests/intel/kms_dirtyfb.c                     |  25 ++--
 tests/intel/kms_dp_linktrain_fallback.c       |  11 +-
 tests/intel/kms_fb_coherency.c                |   8 +-
 tests/intel/kms_fbc_dirty_rect.c              |  17 ++-
 tests/intel/kms_flip_scaled_crc.c             |   1 -
 tests/intel/kms_flip_tiling.c                 |  12 +-
 tests/intel/kms_frontbuffer_tracking.c        |  99 +++++++--------
 tests/intel/kms_mmap_write_crc.c              |   8 +-
 tests/intel/kms_pipe_stress.c                 |  65 +++++-----
 tests/intel/kms_pm_lpsp.c                     |   7 +-
 tests/intel/kms_psr.c                         |  21 ++--
 tests/intel/kms_psr2_sf.c                     |  97 +++++++--------
 tests/intel/kms_pwrite_crc.c                  |   8 +-
 tests/intel/kms_sharpness_filter.c            |  25 ++--
 tests/intel/perf_pmu.c                        |  10 +-
 tests/intel/prime_mmap_kms.c                  |   6 +-
 tests/kms_async_flips.c                       |  13 +-
 tests/kms_bw.c                                |   2 -
 tests/kms_concurrent.c                        |  45 +++----
 tests/kms_content_protection.c                |   5 +-
 tests/kms_cursor_crc.c                        |  66 +++++-----
 tests/kms_cursor_edge_walk.c                  |  13 +-
 tests/kms_hdr.c                               |  32 ++---
 tests/kms_invalid_mode.c                      |   7 +-
 tests/kms_lease.c                             |  35 +++---
 tests/kms_plane_cursor.c                      |  20 ++-
 tests/kms_plane_lowres.c                      |  11 +-
 tests/kms_plane_multiple.c                    |  88 ++++++++------
 tests/kms_plane_scaling.c                     | 114 +++++++++---------
 tests/kms_prime.c                             |  14 +--
 tests/kms_sequence.c                          |  12 +-
 tests/kms_tiled_display.c                     |  14 +--
 tests/kms_vblank.c                            |  55 +++++----
 tests/nouveau_crc.c                           |  31 +++--
 tests/vmwgfx/vmw_prime.c                      |  10 +-
 tools/amd_hdmi_compliance.c                   |   4 +-
 tools/intel_hdcp.c                            |   4 +-
 64 files changed, 663 insertions(+), 695 deletions(-)

-- 
2.52.0


^ permalink raw reply	[flat|nested] 64+ messages in thread

end of thread, other threads:[~2026-02-25  9:18 UTC | newest]

Thread overview: 64+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-21  3:19 [PATCH i-g-t v2 00/23] tests/kms: More igt_crtc_t conversions Ville Syrjala
2026-02-21  3:19 ` [PATCH i-g-t v2 01/23] tests/intel/kms_psr: Don't pass uninitialized 'pipe' to intel_fbc_supported_on_chipset() Ville Syrjala
2026-02-23 11:22   ` Jani Nikula
2026-02-24  7:28     ` Ville Syrjälä
2026-02-23 11:23   ` Jani Nikula
2026-02-23 12:01     ` Jani Nikula
2026-02-24  8:49   ` [PATCH i-g-t v3 " Ville Syrjala
2026-02-24  8:53     ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 02/23] tests/intel/kms_psr2_sf: Don't pass zero initialized 'data.pipe' " Ville Syrjala
2026-02-24  8:51   ` [PATCH i-g-t v3 " Ville Syrjala
2026-02-24  8:56     ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 03/23] tests/intel/kms_flip_scaled_crc: Remove unused 'enum pipe pipe' Ville Syrjala
2026-02-23 11:34   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 04/23] tests/kms_concurrent: Actually run the test over all connected crtcs Ville Syrjala
2026-02-23  3:09   ` Karthik B S
2026-02-21  3:19 ` [PATCH i-g-t v2 05/23] tests/amdgpu/amd_abm: Don't use uninitialized 'pipe' Ville Syrjala
2026-02-24 14:08   ` Jani Nikula
2026-02-25  9:18     ` Ville Syrjälä
2026-02-21  3:19 ` [PATCH i-g-t v2 06/23] tests/kms: Use 'enum pipe' over int' Ville Syrjala
2026-02-23 11:44   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 07/23] lib/kms: Add igt_crtc_for_crtc_id() Ville Syrjala
2026-02-23 11:46   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 08/23] tests/kms_lease: Use igt_crtc_t instead of enum pipe Ville Syrjala
2026-02-23 11:48   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 09/23] tests/kms_lease: Pass lease_t to prepare_crtc() Ville Syrjala
2026-02-23 11:49   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 10/23] tests/intel/kms_frontbuffer_tracking: Use igt_crtc_t instead of enum pipe Ville Syrjala
2026-02-23 11:52   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 11/23] tests/kms_plane_scaling: " Ville Syrjala
2026-02-23 14:06   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 12/23] tests/drm_read: " Ville Syrjala
2026-02-24  8:58   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 13/23] tests/intel/kms_psr2_sf: Convert pipes[] to crtcs[] Ville Syrjala
2026-02-24  9:09   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 14/23] tests/kms_vblank: Use igt_crtc_t instead of enum pipe Ville Syrjala
2026-02-24 13:43   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 15/23] tests/kms_plane_multiple: " Ville Syrjala
2026-02-24 13:48   ` Jani Nikula
2026-02-25  7:44     ` Ville Syrjälä
2026-02-21  3:19 ` [PATCH i-g-t v2 16/23] tests/kms_tiled_display: " Ville Syrjala
2026-02-24 13:48   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 17/23] tests/intel/kms_psr: " Ville Syrjala
2026-02-24 13:49   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 18/23] tests/kms_prime: " Ville Syrjala
2026-02-24 13:50   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 19/23] tests/chamelium: " Ville Syrjala
2026-02-24 13:51   ` Jani Nikula
2026-02-21  3:19 ` [PATCH i-g-t v2 20/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 1 Ville Syrjala
2026-02-24 13:56   ` Jani Nikula
2026-02-21  3:20 ` [PATCH i-g-t v2 21/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 2 Ville Syrjala
2026-02-24 13:58   ` Jani Nikula
2026-02-21  3:20 ` [PATCH i-g-t v2 22/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 3 Ville Syrjala
2026-02-24  8:51   ` [PATCH i-g-t v3 " Ville Syrjala
2026-02-24 14:04     ` Jani Nikula
2026-02-21  3:20 ` [PATCH i-g-t v2 23/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 4 Ville Syrjala
2026-02-24 14:06   ` Jani Nikula
2026-02-21  3:59 ` ✓ Xe.CI.BAT: success for tests/kms: More igt_crtc_t conversions (rev2) Patchwork
2026-02-21  4:13 ` ✓ i915.CI.BAT: " Patchwork
2026-02-21 16:12 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-23 13:25 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-24 12:43 ` ✓ Xe.CI.BAT: success for tests/kms: More igt_crtc_t conversions (rev5) Patchwork
2026-02-24 12:58 ` ✓ i915.CI.BAT: " Patchwork
2026-02-24 18:52 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-24 22:57 ` ✓ Xe.CI.FULL: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox