From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C423310E07C for ; Thu, 21 Dec 2023 04:52:58 +0000 (UTC) Message-ID: Date: Thu, 21 Dec 2023 10:22:39 +0530 Subject: Re: [PATCH i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic Content-Language: en-US To: Ville Syrjala , References: <20231220154307.32424-1-ville.syrjala@linux.intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <20231220154307.32424-1-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 20-12-2023 09:13 pm, Ville Syrjala wrote: > From: Ville Syrjälä > > The test forgets to set the output size of the planes. The > default plane output size will be taken from the fb dimensions > which means we end up upscaling the planes, which may not work > on all hardware. > > Set the planes' output size to match the input size to avoid this. > The frambuffer was specifically created wide enough to cover both > outputs with 1:1 scaling. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9841 > Signed-off-by: Ville Syrjälä Reviewed-by: Bhanuprakash Modem > --- > tests/kms_display_modes.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c > index 1f0f811c8367..f1d8ab03d501 100644 > --- a/tests/kms_display_modes.c > +++ b/tests/kms_display_modes.c > @@ -180,10 +180,12 @@ static void run_extendedmode_basic(data_t *data, > igt_plane_set_fb(plane[0], &fb); > igt_fb_set_position(&fb, plane[0], 0, 0); > igt_fb_set_size(&fb, plane[0], mode[0]->hdisplay, mode[0]->vdisplay); > + igt_plane_set_size(plane[0], mode[0]->hdisplay, mode[0]->vdisplay); > > igt_plane_set_fb(plane[1], &fb); > igt_fb_set_position(&fb, plane[1], mode[0]->hdisplay, 0); > igt_fb_set_size(&fb, plane[1], mode[1]->hdisplay, mode[1]->vdisplay); > + igt_plane_set_size(plane[1], mode[1]->hdisplay, mode[1]->vdisplay); > > igt_display_commit2(display, COMMIT_ATOMIC); > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Message-ID: Date: Thu, 21 Dec 2023 10:22:39 +0530 Subject: Re: [PATCH i-g-t] tests/kms_display_modes: Fix the plane setup in extended-mode-basic Content-Language: en-US References: <20231220154307.32424-1-ville.syrjala@linux.intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <20231220154307.32424-1-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: To: Ville Syrjala , igt-dev@lists.freedesktop.org Message-ID: <20231221045239.MtZfNhPlVJyWQhz7uU3pVe-QNv5GKwt5haeDf3adLnU@z> On 20-12-2023 09:13 pm, Ville Syrjala wrote: > From: Ville Syrjälä > > The test forgets to set the output size of the planes. The > default plane output size will be taken from the fb dimensions > which means we end up upscaling the planes, which may not work > on all hardware. > > Set the planes' output size to match the input size to avoid this. > The frambuffer was specifically created wide enough to cover both > outputs with 1:1 scaling. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9841 > Signed-off-by: Ville Syrjälä Reviewed-by: Bhanuprakash Modem > --- > tests/kms_display_modes.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c > index 1f0f811c8367..f1d8ab03d501 100644 > --- a/tests/kms_display_modes.c > +++ b/tests/kms_display_modes.c > @@ -180,10 +180,12 @@ static void run_extendedmode_basic(data_t *data, > igt_plane_set_fb(plane[0], &fb); > igt_fb_set_position(&fb, plane[0], 0, 0); > igt_fb_set_size(&fb, plane[0], mode[0]->hdisplay, mode[0]->vdisplay); > + igt_plane_set_size(plane[0], mode[0]->hdisplay, mode[0]->vdisplay); > > igt_plane_set_fb(plane[1], &fb); > igt_fb_set_position(&fb, plane[1], mode[0]->hdisplay, 0); > igt_fb_set_size(&fb, plane[1], mode[1]->hdisplay, mode[1]->vdisplay); > + igt_plane_set_size(plane[1], mode[1]->hdisplay, mode[1]->vdisplay); > > igt_display_commit2(display, COMMIT_ATOMIC); >