Re: [PATCH v4 1/2] tests/intel/kms_frontbuffer_tracking: Skip fbc-* tests on BMG

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Thasleem,

Patch LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 20-01-2025 11:40 am, Mohammed Thasleem wrote:
> FBC test isn't supported on bmg, skip the test on this platform.
>
> v2: Add workaround id: Wa_16023588340. (Swati)
> v3: Add workaround id in code.
> v4: Updated subject. (Kamil).
>
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
> ---
>   tests/intel/kms_frontbuffer_tracking.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index 3d833864a..21bbaf61e 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2755,6 +2755,10 @@ static void prepare_subtest_data(const struct test_mode *t,
>   
>   static void prepare_subtest_screens(const struct test_mode *t)
>   {
> +	/* FBC disabled: Wa_16023588340 */
> +	igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t->feature == FEATURE_FBC),
> +		      "FBC isn't supported on BMG\n");
> +
>   	if (t->pipes == PIPE_DUAL)
>   		enable_both_screens_and_wait(t);
>   	else
> @@ -2799,6 +2803,10 @@ static void prepare_subtest(const struct test_mode *t,
>    */
>   static void rte_subtest(const struct test_mode *t)
>   {
> +	/* FBC disabled: Wa_16023588340 */
> +	igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t->feature == FEATURE_FBC),
> +		      "FBC isn't supported on BMG\n");
> +
>   	prepare_subtest_data(t, NULL);
>   
>   	unset_all_crtcs();
> @@ -4294,6 +4302,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>   			t.flip = -1;
>   			t.tiling = opt.tiling;
>   
> +			/* FBC disabled: Wa_16023588340 */
> +			igt_skip_on_f((IS_BATTLEMAGE(drm.devid) && t.feature == FEATURE_FBC),
> +				      "FBC isn't supported on BMG\n");
> +
>   			for_each_pipe(&drm.display, pipe) {
>   				if (pipe == default_pipe) {
>   					igt_info("pipe-%s: FBC validated in other subtest\n", kmstest_pipe_name(pipe));