Re: [PATCH i-g-t 1/4] tests/intel/kms_pm_dc: Replace require with proper assertion

["Thasleem, Mohammed" <mohammed.thasleem@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]


On 04-03-2026 10:08 am, Jeevan B wrote:
> The DC3CO video playback simulation test was incorrectly using require at
> the end to check if DC3CO state was entered. This causes the test to be
> marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding
> real issues. So changing the call from require to assert.
>
> Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test")
> Signed-off-by: Jeevan B<jeevan.b@intel.com>

LGTM:

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com> 
<mailto:mohammed.thasleem@intel.com>

> ---
>   tests/intel/kms_pm_dc.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
> index 39e94f36b..507b6168d 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -312,8 +312,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)
>   		usleep(delay);
>   	}
>   
> -	igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO,
> -					      dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n");
> +	check_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt);
>   }
>   
>   static void setup_dc3co(data_t *data)

[-- Attachment #2: Type: text/html, Size: 37315 bytes --]