From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED59DEDB7CC for ; Tue, 7 Apr 2026 09:29:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 959ED10E382; Tue, 7 Apr 2026 09:29:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LwdynJjL"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id E22FB10E389 for ; Tue, 7 Apr 2026 09:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775554160; x=1807090160; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=fszQ6JGmCMx47svtp6OzTCUHBXpGUnHa0+G2ldDgk/Y=; b=LwdynJjLNLlNW0rCtAqc8vtHehNG00X7q76g29619dEP1A1nKgkQcxS0 RzPYGjvq5hRSIq7AYqxQ2aLQaADtzXNdxnpPdbyJzsWrPf82VXmRlTOE5 bOHdX78AYkOgBKocGtc9yPDXVUwbP3Nvw0e6GZeSujOTZx9tiWhjOj6cV U3zq4rhLnnWtG6rVVpNDfqb4qJEYQOpGhtgDliSEeCPutELjN0FXs/JoU 3FYUDOfEItTO3jU8KvEP5/E1TfGcU+0Dve3AtqfX7+26TJWNuuqRBgoWD WprZOtYBtAfAj+aYJFuL/Kl+IJaerrXkrYOy+gVuCwGGB0doJM0CGaNhp Q==; X-CSE-ConnectionGUID: mAo4g/AQR3OJMHLPd2GcBg== X-CSE-MsgGUID: 1JmSV8MURDiDJdHlTnf/pA== X-IronPort-AV: E=McAfee;i="6800,10657,11751"; a="87898551" X-IronPort-AV: E=Sophos;i="6.23,165,1770624000"; d="scan'208,217";a="87898551" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 02:29:19 -0700 X-CSE-ConnectionGUID: hRlTuH7SQZuW42mKKryd4g== X-CSE-MsgGUID: nmbnDybrSZaEAmnE9sTDqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,165,1770624000"; d="scan'208,217";a="227124891" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2026 02:29:19 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 7 Apr 2026 02:29:18 -0700 Received: from ORSEDG902.ED.cps.intel.com (10.7.248.12) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 7 Apr 2026 02:29:18 -0700 Received: from BN1PR04CU002.outbound.protection.outlook.com (52.101.56.66) by edgegateway.intel.com (134.134.137.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 7 Apr 2026 02:29:18 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KxpQQmyWODC3B+xbQK22TDPPB9gg0R57wN8Sn57FpZtekdejm4uNL8y/CjCa3vN8YblYqywg45pgzQOKnBcVCUKc3ML74iwqp1a5dzGdeANTeDtXB4Xiup7XO5AeqY4bwaDxk0DI6dDfXQZpzPFdqofxr1hpoMrPpnRG2gNWgRsRIrAFnNzlAOgaS/xgd+w5ZJJKOa0XG9cC9hmZnemv4AiGl3Lxrzd7NpuMaaAuVnCPOl8F7WyDGEB1Q3E23iYziC/grbiqpMGAHFdq8+E2q31T4JMelkRGcVIgH0HYmtxgPEfL13W+ldI9Ge/RLgI6HSYmUPQyQd1q9GVc9aJTrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JUQ8xLqmazCuBBrZ1uTh81XhPhJu8v/fcZ1PGWGM7ac=; b=EIZqp2qn+gROXp4icHTrNF23NeJBfq5FI5ms/Y2aGC6WdF6JD+daSlNCFqyuXpB/yKN/5Z8WIxUZibuWn/HnCORhQanNTrTvHyZeoIrQ1eZQc+PY/FD9mTRmyF1ZljB0rEUIrdTCa0E5uAZzaIHbAAllX+qhqvWvcHNaYy+SiMdSa5J6NfcQp93/7N+8Ma5xpGQnV+GLOrogbPoPVV/fRkW9LwE11MmsJDyD8OmiptfHihf3BsZx1KGdCPGeehyI0PFDym7jqhNWLewG/iMihNoCoOR/nXZF2nkNpVwgfnGFSJRwD9xQncHmZ3WTI0aqnPRKdxxFYdtgCaCqcAzThQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from LV8PR11MB8485.namprd11.prod.outlook.com (2603:10b6:408:1e6::13) by IA1PR11MB8198.namprd11.prod.outlook.com (2603:10b6:208:453::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.18; Tue, 7 Apr 2026 09:29:15 +0000 Received: from LV8PR11MB8485.namprd11.prod.outlook.com ([fe80::9ec6:998a:b515:890c]) by LV8PR11MB8485.namprd11.prod.outlook.com ([fe80::9ec6:998a:b515:890c%4]) with mapi id 15.20.9769.018; Tue, 7 Apr 2026 09:29:15 +0000 Content-Type: multipart/alternative; boundary="------------l32KlNQ0dPSy2bn0olgxjUG4" Message-ID: Date: Tue, 7 Apr 2026 14:59:09 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t 1/4] tests/intel/kms_pm_dc: Replace require with proper assertion Content-Language: en-GB To: Jeevan B , CC: References: <20260304043805.572087-1-jeevan.b@intel.com> <20260304043805.572087-2-jeevan.b@intel.com> From: "Thasleem, Mohammed" In-Reply-To: <20260304043805.572087-2-jeevan.b@intel.com> X-ClientProxiedBy: MA5PR01CA0139.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1b9::12) To LV8PR11MB8485.namprd11.prod.outlook.com (2603:10b6:408:1e6::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR11MB8485:EE_|IA1PR11MB8198:EE_ X-MS-Office365-Filtering-Correlation-Id: 77ba717a-5012-4a0f-b9e5-08de948822a8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|8096899003|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: Q5gEKm7+Pg3Rt8s46RtJbhuoRarV8OzkbrOD3tD4AR8thnxGJ72hAB6AClOgTce36X7Gr/heY/CyuqPSP+Hwk5MNQHe048rrktVwBeOIdiqrFK81pHRPN3/iQgRFa4JJb1tCOAKzInxpoyZntZI7gJNVpv86e+1JniMUx2Mnf/f69WhzT608TdbjZxjrnI6Qh+444OG2RU6tsvMDJub6keWL7apBT7wpppp8d8Wam0R7Ol9S9YxebSC3FRo5by85ijDjwNhpt/dUlss/+KinOAn2sSvogGr+z8AzxZzBMFSz0Jh3pNaSNio7l3uvkZwhplNr7YLNhoTb02DrMxcz8ddHnfQ2sNC1YBCyldiFC49Mhp5oprhfH6VZgj5ZcIL76FjpagBtTyDnun6BRV+5vZpRK0rOcuod75tOybMtwGIbncMT5qeAaoMt3Ni+zo5IIzLBf34Rw+pPWKmmmGtWDasXqiI8UB+YNKFWPmbgAfIyVvRlEZ+yM9jgahIBE+rSlzZSoEgAdO5n3VwU2WyCZyNWA9BAIe5brcWDI3K7Gsb5rMl4qiHhRjQ7qhWd9ZjcWYWUWI1GDzYjYAgxZubfJf4FvWB5yMw8KheYcOi3GH4oks37m7ngt6u0ft15UisfRlz35fbpv9jtB+SYAAbvRryn1mS0hdalFKAUiEr33yP4kA8iWcX5UFTDp8u39viRk+ggFRrF1lXfHJFpG9nUCGYi6cgn3d9TN7IvhTXpFlA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV8PR11MB8485.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(8096899003)(18002099003)(22082099003)(56012099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWl3ejNwR1c0L0ovVms0RWhqeTNtS29kR0tJT3VwNnRWZ2NuWVZqV3lHZE41?= =?utf-8?B?M3krTU91T0NKc1R3dFQwTVIwVktwUG9lOEF0Q0JBR3NvVHhnTHpwSnVaM1da?= =?utf-8?B?RW1ST1A5K3crQ0pDdHJtWlpsMktrRkx3MVdqQ2xEWnNyblhlTzFQLy96S2hq?= =?utf-8?B?TEhzelBQYWc5ODBVdWtSQmRKbUd3STRybDVBSGNyOGdKSWcwcU9ucm8xQmVK?= =?utf-8?B?VGRveEt0ZEhzcTAxS1ZCV0JkRWEvaGlJbGdsdWpNT3BtNDIwOEY4SU10ZHRv?= =?utf-8?B?cUdJRFZld01qb2FYMzBCNkhZNWhHQy9QQklFMWhnb3pyTWJGR0dWM29LeGJw?= =?utf-8?B?M0taTFZDZk5rYlhuSXJyRkR6MVdVcVFpY1ZtWXg0cHkvZE16VHNYRk95bW1a?= =?utf-8?B?dzlOYzY1SG96aEI5YUFoR1hrdVlwT1o3OTNJaU9lRUgvUSsrcTFFazBuKytw?= =?utf-8?B?YVZlYjNkd1lRSk15SWZyU1pEZGlMRUVScE5LZVh5TjVwVTNlOXhBNTArSXBQ?= =?utf-8?B?Y0M4dUM2ZEJTc09TUndNWmJuRlNBWXV2N2dmdmhOUWtnWVoxdFF1ZmJXdTNB?= =?utf-8?B?U3ZwTS91Slo4NDgyYkMvYmF1OEdDNTJmTlAvR3c4UVFOYUtWeHQ1MHdsakx6?= =?utf-8?B?UGM3Wlh1WTNmbkc4STBteWVNbWFXeDUvcG5KQVphSWhXTllQU0ZnSkNhdS9t?= =?utf-8?B?Y2RkYXk2bzJLdStqMmxyM3dObFZJTDFXOWxybDRBRUxCM0RtVjA4cjY0UjBl?= =?utf-8?B?eEp3R3NMdVFzMUxJZlA5Y0JMVUJsOENqRkljL2pMeGVBcXdjZ0oraTlGazBl?= =?utf-8?B?SHQzeWRML3RHZ0pFeTdQcmQxc0kvSTBPVUlwME5Fc3MxNXVyaUpGK1ZST0M1?= =?utf-8?B?YktuanRJL0poUDJSRkxrUU1LTDZreThSSUExQUJxWTR3emtFS1psWE8vT1Vo?= =?utf-8?B?enNDdFVXQ3AxSXZyeE9DYTFuQ2R5YndTaHE3OEJFczJBbW1veE1RWEVUWVg0?= =?utf-8?B?Rm1uS0RmYjlDQWJ0TXYvM0JEejg4azg4ayt1aThROENOUXJZN21ReG1yTVA2?= =?utf-8?B?TWJaNUdmaHFpa0o0Ty8yYjZMV3BHNC82MW5ZMGFLcTAyT3psME5FSjVmU3U3?= =?utf-8?B?V1RMNGc3T3RhSlIvQ3FYT1NWNHllNCtJeU9CdERhZTB5ckhSV1l6UjBoZWd2?= =?utf-8?B?QVVhVGZEYk0xbUhmREx6cS9LbzhVbGtMOGFDaklCYzh1blRnNWZ3cWx5eTNt?= =?utf-8?B?QmdDMEJkYWJKYXY1Z1NFdE1EYkVNb01DRTRaRFpBYytWL1FRMjBNZFhLTC95?= =?utf-8?B?NnNaOWN6WXdhWmZFZmIySUlUQVgvOU1YRi9qd0hLMHZ3bWZBVzhFVThpN2lF?= =?utf-8?B?WUtNcG1hWVR4VWxoZG9kYy9UUXJYNFl4TUU2QTB3WVFnNjdxQUx5MnZvaFBD?= =?utf-8?B?bk9OalhlV1pOaXdVc0lSVXZsbjExTytBNHNVMjVERUJxU1QzdkdyVmE0QlVW?= =?utf-8?B?eW0rL0l2WitrMjlXVW1hN2M4RzJRRVlMdVdMRkJmK0hkTEpEdEFnZlh3SDll?= =?utf-8?B?dnJINHlmOGF1WnFId2IyVTJ3V3BMS2lhZGxvQmNKREZXSnRDVXU5RUpwemNZ?= =?utf-8?B?NDBhMWNpU2g1UEJMYWNFOURHcVhpNDNqb0RvamplVEFVdmJjRXhVRm1HNjM5?= =?utf-8?B?Snpkb2YzRXdpZTJ3YjZVWmNKMHRWczVKYytGUVhONGU1ODJ4VVVGL3FQVi9o?= =?utf-8?B?b3FsZHRDcm1sRFFDeXIzVlg5bElvcTVJQUpOMFI5WDFydGExamJ3bndIbytq?= =?utf-8?B?MGF3NWlTVkxoTFZWY0hsdGh5UXFzeUtxSHczdGgyVUJJYzIrUko2b25MelF2?= =?utf-8?B?NjRuYXFGR2ZHRnlPUTNzZ0VQcnZick9oTUdiTkgxR1dZZjdIemFaVElUd0dE?= =?utf-8?B?TlgwUStTanJQTThLZmEyZHc2bkFCK0ZPWmlhSzNweXE3akZjRS8yV0lqdUNQ?= =?utf-8?B?NUI1UmZ4YjVqS29ZODlEMEgxWnpIdWxRcWhWQ01pUUJSS1dxV1ArZjVrcExC?= =?utf-8?B?cEFSTWthdGtsUkFEMitkRjIvT2N0dXFzRWlhZHlCTFZydTQwN1hLVGtZbmpW?= =?utf-8?B?a3BrWXZyUnpNMHk5Smo5SHc5RjgwM1V0YmVtZUZGank1NlJLMlVDdmVkcUlq?= =?utf-8?B?VjludEZhR1krOXJuRDB1RTBHdjN3aTByUkQwWmlOVXBKYUxpK1JoYjZMekR3?= =?utf-8?B?bjByS1J4SHdFMEdTcCsxc0U4Mm12WGJSZVVvdTBhL1N4UzNZRkFvVWNMNXJn?= =?utf-8?B?ckw0d2FCcUZRZ3pKOTV2b20wdXpwQlJsdVljV3U0YVJLVVk1UEIxRWlWMm91?= =?utf-8?Q?2tBQtTBx34rhPFZs=3D?= X-Exchange-RoutingPolicyChecked: I8HUGg3WDkcPSsGDOvXVrRV51AY7ad6dH+UYah5lCBrqIaV1urXlsfFFI1HhiTyiwyoMQ3JkwOv/GYFgu2zO1QBfG94857ZsqQkcCt0cCmwTOzkIJ3/03BSgkHbty1b6HWW+BYEEHIXFsbYn/BTmxPWqOAjrxGN+iR1MRERUyaWFvAWUMRmaLGrDPoc/8GTKgdE1q7/LXwAYt8E8eUnZPkg4xEw3eXbQBOul9jDIRU2/S2iqhTMOJU1tp3piQx7/2ktoP9wR8AK7pFuVqX7OpPO84G8vN+tgFaOxh7+q1apfNeJtsTyc14/DDqqeDZhY64BU+sZJGsSPUnl4DWa22Q== X-MS-Exchange-CrossTenant-Network-Message-Id: 77ba717a-5012-4a0f-b9e5-08de948822a8 X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8485.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2026 09:29:15.5049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EnUzQ07laOkaYDxzHPcac9BBeHH0ncTVMy8De8krvKjFSoIWi93NN8KtudP1UMpV80JyljRlIjid675QiXAmXxkrIq5Pp0nmZW5syaOBHvM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8198 X-OriginatorOrg: intel.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" --------------l32KlNQ0dPSy2bn0olgxjUG4 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 04-03-2026 10:08 am, Jeevan B wrote: > The DC3CO video playback simulation test was incorrectly using require at > the end to check if DC3CO state was entered. This causes the test to be > marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding > real issues. So changing the call from require to assert. > > Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") > Signed-off-by: Jeevan B LGTM: Reviewed-by: Mohammed Thasleem > --- > tests/intel/kms_pm_dc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c > index 39e94f36b..507b6168d 100644 > --- a/tests/intel/kms_pm_dc.c > +++ b/tests/intel/kms_pm_dc.c > @@ -312,8 +312,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) > usleep(delay); > } > > - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, > - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); > + check_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); > } > > static void setup_dc3co(data_t *data) --------------l32KlNQ0dPSy2bn0olgxjUG4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 04-03-2026 10:08 am, Jeevan B wrote:
The DC3CO video playback simulation test was incorrectly using require at
the end to check if DC3CO state was entered. This causes the test to be
marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding
real issues. So changing the call from require to assert.

Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test")
Signed-off-by: Jeevan B <jeevan.b@intel.com>

LGTM: 

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>
---
 tests/intel/kms_pm_dc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index 39e94f36b..507b6168d 100644
--- a/tests/intel/kms_pm_dc.c
+++ b/tests/intel/kms_pm_dc.c
@@ -312,8 +312,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)
 		usleep(delay);
 	}
 
-	igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO,
-					      dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n");
+	check_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt);
 }
 
 static void setup_dc3co(data_t *data)
--------------l32KlNQ0dPSy2bn0olgxjUG4--