Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 0/3] Sync i915_pciid.h
Date: Wed, 10 Jan 2024 16:45:53 +0200	[thread overview]
Message-ID: <da45fb63-c8c9-4f48-b46d-3fb6a40f72d4@gmail.com> (raw)
In-Reply-To: <20240110081532.1378038-1-chaitanya.kumar.borah@intel.com>

Set look ok to me.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

On 10.1.2024 10.15, Chaitanya Kumar Borah wrote:
> Our original intent was to add ARL-S PCI IDs to IGT header. The ideal way
> to do that would be to sync i915_pciids.h between kernel and IGT.
> However, recently both files have diverged. See [2]
> 
> We tried adding just the ARL-S PCI ID to the IGT i915_pciids.h but
> this will further diverge both the files. Please see the discussions
> in [1].
> 
> To avoid this, we have decided to use i915_pciids_local.h to move out
> any difference between the kernel and IGT header and then sync both
> the headers.
> 
> I have not tested if the PVC and MTL changes causes any functional issue
> but verified that the build works.
> 
> [1] https://patchwork.freedesktop.org/patch/572027/?series=50957&rev=15
> [2] 17f9914c47c9 (lib: Add Pontevecchio platform)
>      77dd5222d165 (v2: Add mtl to perf-metrics-codegen.py (Umesh))
> 	
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> 
> Chaitanya Kumar Borah (3):
>    lib/i915/perf: include i915_pciids_local.h
>    lib: Add non-kernel macros to i915_pciids_local.h
>    lib: sync i915_pciids.h with kernel
> 
>   lib/i915/perf.c         |  1 +
>   lib/i915_pciids.h       | 56 ++++++++++++++++++-----------------------
>   lib/i915_pciids_local.h | 38 ++++++++++++++++++++++++++++
>   3 files changed, 64 insertions(+), 31 deletions(-)
> 

  parent reply	other threads:[~2024-01-10 14:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-10  8:15 [PATCH i-g-t 0/3] Sync i915_pciid.h Chaitanya Kumar Borah
2024-01-10  8:15 ` [PATCH i-g-t 1/3] lib/i915/perf: include i915_pciids_local.h Chaitanya Kumar Borah
2024-01-11 10:02   ` Kamil Konieczny
2024-01-10  8:15 ` [PATCH i-g-t 2/3] lib: Add non-kernel macros to i915_pciids_local.h Chaitanya Kumar Borah
2024-01-11 11:08   ` Kamil Konieczny
2024-01-11 11:11     ` Borah, Chaitanya Kumar
2024-01-11 11:13   ` Kamil Konieczny
2024-01-10  8:15 ` [PATCH i-g-t 3/3] lib: sync i915_pciids.h with kernel Chaitanya Kumar Borah
2024-01-11 10:54   ` Kamil Konieczny
2024-01-10 12:16 ` ✓ CI.xeBAT: success for Sync i915_pciid.h (rev3) Patchwork
2024-01-10 12:20 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-10 14:11 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-10 14:45 ` Juha-Pekka Heikkila [this message]
2024-01-17 10:04 ` ✓ Fi.CI.IGT: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-01-09  6:09 [PATCH i-g-t 0/3] Sync i915_pciid.h Chaitanya Kumar Borah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da45fb63-c8c9-4f48-b46d-3fb6a40f72d4@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox