Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Swati Sharma <swati2.sharma@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 2/2] tests/intel/kms_test_config: Add mandatory fields
Date: Fri, 14 Mar 2025 14:16:47 +0530	[thread overview]
Message-ID: <dad47720-0fb7-4ed7-a8b2-f7c5445c46dc@intel.com> (raw)
In-Reply-To: <20250312092654.567154-2-swati2.sharma@intel.com>


On 3/12/2025 2:56 PM, Swati Sharma wrote:
> To maintain consistency across all KMS test documentation, lets
> make few fields mandatory.
> Let's follow the following pattern
>
> 	/**
> 	  * TEST: <test name>
> 	  * Category: Display
> 	  * Description: <test description>
> 	  * Driver requirement: <i915/xe/i915, xe>
> 	  * Mega feature: <mega feature name>
> 	  *
> 	  * SUBTEST: <subtest name>
> 	  * Description: <subtest description>
> 	 */
> TODO: Upstream documentation for mega feature

Hi Swati,

Since we're making mega feature mandatory in this patch, wouldn't it be 
good to have the documentation for mega feature as part of the same 
series and getting them merged together?

Thanks,
Karthik.B.S
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   tests/intel/kms_test_config.json | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/tests/intel/kms_test_config.json b/tests/intel/kms_test_config.json
> index e11c7f4fe..aeb16a94b 100644
> --- a/tests/intel/kms_test_config.json
> +++ b/tests/intel/kms_test_config.json
> @@ -28,10 +28,12 @@
>               },
>               "Category": {
>                   "_properties_": {
> +		    "mandatory": true,
>                       "description": "Contains the major group for the tested functionality 'Display'"
>                   },
>                   "Mega feature": {
>                       "_properties_": {
> +			"mandatory": true,
>                           "description": "Contains the mega feature for end to end use case, e.g. the 'PSR' feature."
>                       },
>                       "Functionality": {
> @@ -44,6 +46,7 @@
>           },
>           "Driver requirement": {
>               "_properties_": {
> +		"mandatory": true,
>                   "description": "Describes any Driver specific requrirement, like i915/xe."
>               }
>           },
> @@ -59,6 +62,7 @@
>   	},
>           "Description": {
>               "_properties_": {
> +		"mandatory": true,
>                   "description": "Provides a description for the test/subtest."
>               }
>           }

  reply	other threads:[~2025-03-14  8:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12  9:26 [PATCH i-g-t 1/2] tests/kms: Align test documentation Swati Sharma
2025-03-12  9:26 ` [PATCH i-g-t 2/2] tests/intel/kms_test_config: Add mandatory fields Swati Sharma
2025-03-14  8:46   ` Karthik B S [this message]
2025-03-13  1:55 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms: Align test documentation Patchwork
2025-03-13  2:19 ` ✓ i915.CI.BAT: " Patchwork
2025-03-13  4:01 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-13 17:13 ` ✓ Xe.CI.Full: success " Patchwork
2025-03-14  8:48 ` [PATCH i-g-t 1/2] " Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dad47720-0fb7-4ed7-a8b2-f7c5445c46dc@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox