From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4698A10E00E for ; Wed, 19 Jul 2023 05:35:53 +0000 (UTC) Message-ID: Date: Wed, 19 Jul 2023 11:05:35 +0530 Content-Language: en-US To: "Dixit, Ashutosh" References: <20230718111736.3324211-1-badal.nilawar@intel.com> <87edl5hybs.wl-ashutosh.dixit@intel.com> <87cz0phy5u.wl-ashutosh.dixit@intel.com> From: "Nilawar, Badal" In-Reply-To: <87cz0phy5u.wl-ashutosh.dixit@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v3] tests/xe: Verify actual frequency on the basis of GT state List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 18-07-2023 23:58, Dixit, Ashutosh wrote: > On Tue, 18 Jul 2023 11:24:55 -0700, Dixit, Ashutosh wrote: >> >> Sorry I missed this yesterday. Basically why do we have the >> igt_wait(xe_is_gt_in_c6()) above at the top when we are waking up the gt >> when reading cur freq later? >> >> Maybe instead of this usleep, we can this do here: >> >> igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 1)); > > Actually, maybe: > > igt_assert(igt_wait(xe_is_gt_in_c6(fd, gt_id), 1000, 10))Sure I will make this change. > >> >> And get rid of the igt_require(igt_wait()) at the top? This is added to skip test if RC6 disabled or not working. As discussed offline I will move this to igt_main. Regards, Badal >> >> Thanks. >> -- >> Ashutosh