From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Karthik B S <karthik.b.s@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_joiner: Check if sequential pipe is enabled
Date: Mon, 19 Jun 2023 12:59:04 +0530 [thread overview]
Message-ID: <dba8b4fb-81c5-0e34-5173-50f84c5c5403@intel.com> (raw)
In-Reply-To: <20230619055814.32202-1-karthik.b.s@intel.com>
Hi Karthik,
On Mon-19-06-2023 11:28 am, Karthik B S wrote:
> As big joiner is only possible on sequential pipe combinations,
> check that the required pipe is enabled before attempting
> a big joiner modeset.
>
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/i915/kms_big_joiner.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/kms_big_joiner.c b/tests/i915/kms_big_joiner.c
> index b9dda58f..47c1f5aa 100644
> --- a/tests/i915/kms_big_joiner.c
> +++ b/tests/i915/kms_big_joiner.c
> @@ -225,8 +225,11 @@ igt_main
> igt_subtest_with_dynamic("basic") {
> for (i = 0; i < data.n_pipes - 1; i++) {
> data.pipe1 = pipe_seq[i];
> - igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
> - test_basic_modeset(&data);
> + /* Check if the consecutive pipe is enabled*/
> + if (pipe_seq[i + 1] == data.pipe1 + 1) {
Is there any way to use igt_check_bigjoiner_support() which is having
all bigjoiner constraints?
- Bhanu
> + igt_dynamic_f("pipe-%s", kmstest_pipe_name(pipe_seq[i]))
> + test_basic_modeset(&data);
> + }
> }
> }
>
next prev parent reply other threads:[~2023-06-19 7:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 5:58 [igt-dev] [PATCH i-g-t] tests/kms_big_joiner: Check if sequential pipe is enabled Karthik B S
2023-06-19 7:29 ` Modem, Bhanuprakash [this message]
2023-06-19 8:56 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-19 12:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dba8b4fb-81c5-0e34-5173-50f84c5c5403@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox