Re: [igt-dev] [PATCH i-g-t 4/7] lib/params: add igt_params_open() which will return path

Juha-Pekka Heikkila
2020-05-05T18:44:12Z

On 5.5.2020 10.07, Petri Latvala wrote:
> On Tue, Apr 28, 2020 at 11:22:52PM +0300, Juha-Pekka Heikkila wrote:
>> From: Jani Nikula <jani.nikula@intel.com>
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>
> Restore author's S-o-b and

I've been trying to advertise on cover letter about this but maybe Jani
didn't see it there. Original patch doesn't have Jani's S-o-b. If Jani
comment about it I could add it here.

> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
>
>> ---
>> lib/igt_params.c | 29 ++++++++++++++++++-----------
>> 1 file changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/lib/igt_params.c b/lib/igt_params.c
>> index b5ac1266..fe4b1df3 100644
>> --- a/lib/igt_params.c
>> +++ b/lib/igt_params.c
>> @@ -107,17 +107,7 @@ static void igt_params_save(int dir, const char *path, const char *name)
>> module_params = data;
>> }
>>
>> -/**
>> - * igt_params_open:
>> - * @device: fd of the device
>> - *
>> - * This opens the module parameters directory (under sysfs) corresponding
>> - * to the device for use with igt_sysfs_set() and igt_sysfs_get().
>> - *
>> - * Returns:
>> - * The directory fd, or -1 on failure.
>> - */
>> -int igt_params_open(int device)
>> +static int __igt_params_open(int device, char **outpath)
>> {
>> int dir, params = -1;
>>
>> @@ -141,11 +131,28 @@ int igt_params_open(int device)
>>
>> sprintf(path, "/sys/module/%s/parameters", name);
>> params = open(path, O_RDONLY);
>> + if (params >= 0 && outpath)
>> + *outpath = strdup(path);
>> }
>>
>> return params;
>> }
>>
>> +/**
>> + * igt_params_open:
>> + * @device: fd of the device
>> + *
>> + * This opens the module parameters directory (under sysfs) corresponding
>> + * to the device for use with igt_sysfs_set() and igt_sysfs_get().
>> + *
>> + * Returns:
>> + * The directory fd, or -1 on failure.
>> + */
>> +int igt_params_open(int device)
>> +{
>> + return __igt_params_open(device, NULL);
>> +}
>> +
>> /**
>> * igt_params_set:
>> * @device: fd of the device
>> --
>> 2.26.0
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev