public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>
To: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>, <arun.r.murthy@intel.com>
Subject: Re: [PATCH i-g-t v2 2/2] tests/kms_async_flips: Use lowest mode for crc subtest
Date: Tue, 24 Mar 2026 14:41:14 +0530	[thread overview]
Message-ID: <dc2a60df-66b1-4b28-8af3-510862c00da6@intel.com> (raw)
In-Reply-To: <20260317053038.51570-3-santhosh.reddy.guddati@intel.com>

Hi Santhosh,

On 3/17/2026 11:00 AM, Santhosh Reddy Guddati wrote:
> Currently The CRC subtest uses mode[0] which maps to preffered high
> refresh mode. On panels with multiple modes, pick the lower mode to
> speed up crc test.
Here your using a mode where pixel clock is low. Update in git subject 
and commit message.
>
> V2: Rename and move the function to lib to re-use. (Ramanaidu)
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
>   tests/kms_async_flips.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
> index 4a2930968..e8a3da07c 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -819,8 +819,9 @@ static void test_crc(data_t *data)
>   
>   	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>   
> -	/* make things faster by using a smallish mode */
> -	mode = &data->output->config.connector->modes[0];
> +	/* make things faster by using a lower bandwidth mode */
> +	mode = igt_output_get_lowclk_mode(data->output);
> +	igt_output_override_mode(data->output, mode);
>   	width = mode->hdisplay;
>   	height = mode->vdisplay;
>   
Observed regression with your changes. Check once.

  reply	other threads:[~2026-03-24  9:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17  5:30 [PATCH i-g-t v2 0/2] Use lowest mode for crc subtest Santhosh Reddy Guddati
2026-03-17  5:30 ` [PATCH i-g-t v2 1/2] lib/igt_kms: Add lowclk and highclk modes Santhosh Reddy Guddati
2026-03-24  9:18   ` Naladala, Ramanaidu
2026-03-17  5:30 ` [PATCH i-g-t v2 2/2] tests/kms_async_flips: Use lowest mode for crc subtest Santhosh Reddy Guddati
2026-03-24  9:11   ` Naladala, Ramanaidu [this message]
2026-03-17 14:37 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-03-17 15:36 ` ✓ i915.CI.BAT: " Patchwork
2026-03-18 18:01 ` ✗ i915.CI.Full: failure " Patchwork
2026-03-18 23:01 ` ✗ Xe.CI.FULL: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-03-09  8:24 [PATCH i-g-t v1] tests/kms_async_flips: " Santhosh Reddy Guddati
2026-03-17  4:56 ` [PATCH i-g-t v2 1/2] lib/igt_kms: Add lowclk and highclk modes Santhosh Reddy Guddati
2026-03-17  4:56   ` [PATCH i-g-t v2 2/2] tests/kms_async_flips: Use lowest mode for crc subtest Santhosh Reddy Guddati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc2a60df-66b1-4b28-8af3-510862c00da6@intel.com \
    --to=ramanaidu.naladala@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox