From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190529132421.27905-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: Date: Mon, 3 Jun 2019 11:19:48 +0100 MIME-Version: 1.0 In-Reply-To: <20190529132421.27905-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Petri Latvala List-ID: Ck9uIDI5LzA1LzIwMTkgMTQ6MjQsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSBydW4gb3V0 IG9mIGVuZ2luZXMsIGludGVsX2dldF9jdXJyZW50X3BoeXNpY2FsX2VuZ2luZSgpIGRlZ3JhZGVz Cj4gaW50byBhbiBpbmZpbml0ZSBsb29wIGFzIGFsdGhvdWdoIGl0IGFkdmFuY2VkIHRoZSBpdGVy YXRvciwgaXQgZGlkIG5vdAo+IHVwZGF0ZSBpdHMgbG9jYWwgZW5naW5lIHBvaW50ZXIuCgpXZSBo YWQgb25lIGluZmluaXRlIGxvb3AgaW4gdGhlcmUgYWxyZWFkeS4uIEFGQUlSIGl0IHdhcyBvbiBv bmUgZW5naW5lIApwbGF0Zm9ybXMuIERvZXMgdGhlIG5ldyBpbmNhcm5hdGlvbiBoYXBwZW4gYWN0 dWFsbHkgdmlhIHRoZSAKX19mb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUgaXRlcmF0b3Igb3IgcGVy aGFwcyBvbmx5IHdoZW4gY2FsbGluZyAKaW50ZWxfZ2V0X2N1cnJlbnRfcGh5c2ljYWxfZW5naW5l IGFmdGVyIGxvb3AgZW5kPyBXaHkgaXQgd2Fzbid0IHNlZW4gaW4gCnRlc3Rpbmc/CgpSZWdhcmRz LAoKVHZydGtvCgo+IFJlcG9ydGVkLWJ5OiBQZXRyaSBMYXR2YWxhIDxwZXRyaS5sYXR2YWxhQGlu dGVsLmNvbT4KPiBGaXhlczogMTdjNzdlN2IwYzNjICgibGliL2k5MTU6IGFkZCBnZW1fZW5naW5l X3RvcG9sb2d5IGxpYnJhcnkgYW5kIGZvcl9lYWNoIGxvb3AgZGVmaW5pdGlvbiIpCj4gU2lnbmVk LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IEFu ZGkgU2h5dGkgPGFuZGkuc2h5dGlAaW50ZWwuY29tPgo+IENjOiBQZXRyaSBMYXR2YWxhIDxwZXRy aS5sYXR2YWxhQGludGVsLmNvbT4KPiAtLS0KPiAgIGxpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xv Z3kuYyB8IDQ5ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIGxpYi9pOTE1 L2dlbV9lbmdpbmVfdG9wb2xvZ3kuaCB8IDM2ICsrKysrKysrKysrKysrKystLS0tLS0tLS0KPiAg IDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgNTYgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuYyBiL2xpYi9pOTE1L2dl bV9lbmdpbmVfdG9wb2xvZ3kuYwo+IGluZGV4IGZkZDFiOTUxNi4uMTdmNjc3ODZmIDEwMDY0NAo+ IC0tLSBhL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuYwo+ICsrKyBiL2xpYi9pOTE1L2dl bV9lbmdpbmVfdG9wb2xvZ3kuYwo+IEBAIC04MSwxMSArODEsMTAgQEAgc3RhdGljIHZvaWQgY3R4 X21hcF9lbmdpbmVzKGludCBmZCwgc3RydWN0IGludGVsX2VuZ2luZV9kYXRhICplZCwKPiAgIAkJ CSAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0gKnBhcmFtKQo+ICAgewo+ICAg CXN0cnVjdCBpOTE1X2NvbnRleHRfcGFyYW1fZW5naW5lcyAqZW5naW5lcyA9Cj4gLQkJCWZyb21f dXNlcl9wb2ludGVyKHBhcmFtLT52YWx1ZSk7Cj4gKwkJZnJvbV91c2VyX3BvaW50ZXIocGFyYW0t PnZhbHVlKTsKPiAgIAlpbnQgaSA9IDA7Cj4gICAKPiAtCWZvciAodHlwZW9mKGVuZ2luZXMtPmVu Z2luZXNbMF0pICpwID0KPiAtCSAgICAgJmVuZ2luZXMtPmVuZ2luZXNbMF07Cj4gKwlmb3IgKHN0 cnVjdCBpOTE1X2VuZ2luZV9jbGFzc19pbnN0YW5jZSAqcCA9ICZlbmdpbmVzLT5lbmdpbmVzWzBd Owo+ICAgCSAgICAgaSA8IGVkLT5uZW5naW5lczsgaSsrLCBwKyspIHsKPiAgIAkJcC0+ZW5naW5l X2NsYXNzID0gZWQtPmVuZ2luZXNbaV0uY2xhc3M7Cj4gICAJCXAtPmVuZ2luZV9pbnN0YW5jZSA9 IGVkLT5lbmdpbmVzW2ldLmluc3RhbmNlOwo+IEBAIC0xMzYsNyArMTM1LDcgQEAgc3RhdGljIHZv aWQgcXVlcnlfZW5naW5lX2xpc3QoaW50IGZkLCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgKmVk KQo+ICAgewo+ICAgCXVpbnQ4X3QgYnVmZltTSVpFT0ZfUVVFUlldID0geyB9Owo+ICAgCXN0cnVj dCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAqcXVlcnlfZW5naW5lID0KPiAtCQkJKHN0cnVj dCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAqKSBidWZmOwo+ICsJCShzdHJ1Y3QgZHJtX2k5 MTVfcXVlcnlfZW5naW5lX2luZm8gKilidWZmOwo+ICAgCWludCBpOwo+ICAgCj4gICAJcXVlcnlf ZW5naW5lcyhmZCwgcXVlcnlfZW5naW5lLCBTSVpFT0ZfUVVFUlkpOwo+IEBAIC0xNDksNDEgKzE0 OCw2IEBAIHN0YXRpYyB2b2lkIHF1ZXJ5X2VuZ2luZV9saXN0KGludCBmZCwgc3RydWN0IGludGVs X2VuZ2luZV9kYXRhICplZCkKPiAgIAllZC0+bmVuZ2luZXMgPSBxdWVyeV9lbmdpbmUtPm51bV9l bmdpbmVzOwo+ICAgfQo+ICAgCj4gLXN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqCj4g LWludGVsX2dldF9jdXJyZW50X2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgKmVkKQo+ IC17Cj4gLQlpZiAoIWVkLT5uKQo+IC0JCWVkLT5jdXJyZW50X2VuZ2luZSA9ICZlZC0+ZW5naW5l c1swXTsKPiAtCWVsc2UgaWYgKGVkLT5uID49IGVkLT5uZW5naW5lcykKPiAtCQllZC0+Y3VycmVu dF9lbmdpbmUgPSBOVUxMOwo+IC0KPiAtCXJldHVybiBlZC0+Y3VycmVudF9lbmdpbmU7Cj4gLX0K PiAtCj4gLXZvaWQgaW50ZWxfbmV4dF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9kYXRhICpl ZCkKPiAtewo+IC0JaWYgKGVkLT5uICsgMSA8IGVkLT5uZW5naW5lcykgewo+IC0JCWVkLT5uKys7 Cj4gLQkJZWQtPmN1cnJlbnRfZW5naW5lID0gJmVkLT5lbmdpbmVzW2VkLT5uXTsKPiAtCX0gZWxz ZSB7Cj4gLQkJZWQtPm4gPSBlZC0+bmVuZ2luZXM7Cj4gLQkJZWQtPmN1cnJlbnRfZW5naW5lID0g TlVMTDsKPiAtCX0KPiAtfQo+IC0KPiAtc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICoK PiAtaW50ZWxfZ2V0X2N1cnJlbnRfcGh5c2ljYWxfZW5naW5lKHN0cnVjdCBpbnRlbF9lbmdpbmVf ZGF0YSAqZWQpCj4gLXsKPiAtCXN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTsKPiAt Cj4gLQlmb3IgKGUgPSBpbnRlbF9nZXRfY3VycmVudF9lbmdpbmUoZWQpOwo+IC0JICAgICBlICYm IGUtPmlzX3ZpcnR1YWw7Cj4gLQkgICAgIGludGVsX25leHRfZW5naW5lKGVkKSkKPiAtCQk7Cj4g LQo+IC0JcmV0dXJuIGU7Cj4gLX0KPiAtCj4gICBzdGF0aWMgaW50IGdlbV90b3BvbG9neV9nZXRf cGFyYW0oaW50IGZkLAo+ICAgCQkJCSAgc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X3BhcmFt ICpwKQo+ICAgewo+IEBAIC0xOTcsMTAgKzE2MSw5IEBAIHN0YXRpYyBpbnQgZ2VtX3RvcG9sb2d5 X2dldF9wYXJhbShpbnQgZmQsCj4gICAJCXJldHVybiAwOwo+ICAgCj4gICAJLyogc2l6ZSB3aWxs IHN0b3JlIHRoZSBlbmdpbmUgY291bnQgKi8KPiAtCXAtPnNpemUgPSAocC0+c2l6ZSAtIHNpemVv ZihzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFtX2VuZ2luZXMpKSAvCj4gLQkJICAob2Zmc2V0b2Yo c3RydWN0IGk5MTVfY29udGV4dF9wYXJhbV9lbmdpbmVzLAo+IC0JCQkgICAgZW5naW5lc1sxXSkg LQo+IC0JCSAgc2l6ZW9mKHN0cnVjdCBpOTE1X2NvbnRleHRfcGFyYW1fZW5naW5lcykpOwo+ICsJ aWd0X2Fzc2VydChwLT5zaXplID49IHNpemVvZihzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFtX2Vu Z2luZXMpKTsKPiArCXAtPnNpemUgLT0gc2l6ZW9mKHN0cnVjdCBpOTE1X2NvbnRleHRfcGFyYW1f ZW5naW5lcyk7Cj4gKwlwLT5zaXplIC89IHNpemVvZihzdHJ1Y3QgaTkxNV9lbmdpbmVfY2xhc3Nf aW5zdGFuY2UpOwo+ICAgCj4gICAJaWd0X2Fzc2VydF9mKHAtPnNpemUgPD0gR0VNX01BWF9FTkdJ TkVTLCAidW5zdXBwb3J0ZWQgZW5naW5lIGNvdW50XG4iKTsKPiAgIAo+IGRpZmYgLS1naXQgYS9s aWIvaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmggYi9saWIvaTkxNS9nZW1fZW5naW5lX3RvcG9s b2d5LmgKPiBpbmRleCAyNDE1ZmQxZTMuLmExMDE4YWZjYSAxMDA2NDQKPiAtLS0gYS9saWIvaTkx NS9nZW1fZW5naW5lX3RvcG9sb2d5LmgKPiArKysgYi9saWIvaTkxNS9nZW1fZW5naW5lX3RvcG9s b2d5LmgKPiBAQCAtMzAsOSArMzAsNyBAQAo+ICAgI2RlZmluZSBHRU1fTUFYX0VOR0lORVMJCUk5 MTVfRVhFQ19SSU5HX01BU0sgKyAxCj4gICAKPiAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfZGF0YSB7 Cj4gLQl1aW50MzJfdCBuZW5naW5lczsKPiAtCXVpbnQzMl90IG47Cj4gLQlzdHJ1Y3QgaW50ZWxf ZXhlY3V0aW9uX2VuZ2luZTIgKmN1cnJlbnRfZW5naW5lOwo+ICsJdWludDMyX3QgbmVuZ2luZXMs IGN1cjsKPiAgIAlzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgZW5naW5lc1tHRU1fTUFY X0VOR0lORVNdOwo+ICAgfTsKPiAgIAo+IEBAIC00MCwzMSArMzgsNDMgQEAgYm9vbCBnZW1faGFz X2VuZ2luZV90b3BvbG9neShpbnQgZmQpOwo+ICAgc3RydWN0IGludGVsX2VuZ2luZV9kYXRhIGlu dGVsX2luaXRfZW5naW5lX2xpc3QoaW50IGZkLCB1aW50MzJfdCBjdHhfaWQpOwo+ICAgCj4gICAv KiBpdGVyYXRpb24gZnVuY3Rpb25zICovCj4gLXN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5l MiAqCj4gLWludGVsX2dldF9jdXJyZW50X2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEg KmVkKTsKPiAtCj4gLXN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqCj4gLWludGVsX2dl dF9jdXJyZW50X3BoeXNpY2FsX2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgKmVkKTsK PiAtCj4gLXZvaWQgaW50ZWxfbmV4dF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9kYXRhICpl ZCk7Cj4gLQo+ICAgaW50IGdlbV9jb250ZXh0X2xvb2t1cF9lbmdpbmUoaW50IGZkLCB1aW50NjRf dCBlbmdpbmUsIHVpbnQzMl90IGN0eF9pZCwKPiAgIAkJCSAgICAgIHN0cnVjdCBpbnRlbF9leGVj dXRpb25fZW5naW5lMiAqZSk7Cj4gICAKPiAgIHZvaWQgZ2VtX2NvbnRleHRfc2V0X2FsbF9lbmdp bmVzKGludCBmZCwgdWludDMyX3QgY3R4KTsKPiAgIAo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBp bnRlbF9leGVjdXRpb25fZW5naW5lMiAqCj4gK2ludGVsX2dldF9jdXJyZW50X2VuZ2luZShzdHJ1 Y3QgaW50ZWxfZW5naW5lX2RhdGEgKmVkKQo+ICt7Cj4gKwlpZiAoZWQtPmN1ciA+PSBlZC0+bmVu Z2luZXMpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJcmV0dXJuICZlZC0+ZW5naW5lc1tlZC0+ Y3VyXTsKPiArfQo+ICsKPiArc3RhdGljIGlubGluZSBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2Vu Z2luZTIgKgo+ICtpbnRlbF9nZXRfY3VycmVudF9waHlzaWNhbF9lbmdpbmUoc3RydWN0IGludGVs X2VuZ2luZV9kYXRhICplZCkKPiArewo+ICsJc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUy ICplOwo+ICsKPiArCWZvciAoOyAoZSA9IGludGVsX2dldF9jdXJyZW50X2VuZ2luZShlZCkpICYm IGUtPmlzX3ZpcnR1YWw7IGVkLT5jdXIrKykKPiArCQk7Cj4gKwo+ICsJcmV0dXJuIGU7Cj4gK30K PiArCj4gICAjZGVmaW5lIF9fZm9yX2VhY2hfc3RhdGljX2VuZ2luZShlX18pIFwKPiAgIAlmb3Ig KChlX18pID0gaW50ZWxfZXhlY3V0aW9uX2VuZ2luZXMyOyAoZV9fKS0+bmFtZTsgKGVfXykrKykK PiAgIAo+ICAgI2RlZmluZSBmb3JfZWFjaF9jb250ZXh0X2VuZ2luZShmZF9fLCBjdHhfXywgZV9f KSBcCj4gICAJZm9yIChzdHJ1Y3QgaW50ZWxfZW5naW5lX2RhdGEgaV9fID0gaW50ZWxfaW5pdF9l bmdpbmVfbGlzdChmZF9fLCBjdHhfXyk7IFwKPiAgIAkgICAgICgoZV9fKSA9IGludGVsX2dldF9j dXJyZW50X2VuZ2luZSgmaV9fKSk7IFwKPiAtCSAgICAgaW50ZWxfbmV4dF9lbmdpbmUoJmlfXykp Cj4gKwkgICAgIGlfXy5jdXIrKykKPiAgIAo+ICAgLyogbmVlZHMgdG8gcmVwbGFjZSAiZm9yX2Vh Y2hfcGh5c2ljYWxfZW5naW5lIiB3aGVuIGNvbmZsaWN0cyBhcmUgZml4ZWQgKi8KPiAgICNkZWZp bmUgX19mb3JfZWFjaF9waHlzaWNhbF9lbmdpbmUoZmRfXywgZV9fKSBcCj4gICAJZm9yIChzdHJ1 Y3QgaW50ZWxfZW5naW5lX2RhdGEgaV9fID0gaW50ZWxfaW5pdF9lbmdpbmVfbGlzdChmZF9fLCAw KTsgXAo+ICAgCSAgICAgKChlX18pID0gaW50ZWxfZ2V0X2N1cnJlbnRfcGh5c2ljYWxfZW5naW5l KCZpX18pKTsgXAo+IC0JICAgICBpbnRlbF9uZXh0X2VuZ2luZSgmaV9fKSkKPiArCSAgICAgaV9f LmN1cisrKQo+ICAgCj4gICAjZW5kaWYgLyogR0VNX0VOR0lORV9UT1BPTE9HWV9IICovCj4gCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFp bGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldg==