From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id E8CAA6EE3F for ; Thu, 13 Dec 2018 13:29:35 +0000 (UTC) Message-ID: From: Paul Kocialkowski Date: Thu, 13 Dec 2018 14:29:34 +0100 In-Reply-To: <20181210163010.GH9144@intel.com> References: <20181206141132.23349-1-paul.kocialkowski@bootlin.com> <20181206141132.23349-5-paul.kocialkowski@bootlin.com> <20181210163010.GH9144@intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 4/9] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: Petri Latvala , Eben Upton , igt-dev@lists.freedesktop.org, Boris Brezillon , Thomas Petazzoni List-ID: SGksCgpPbiBNb24sIDIwMTgtMTItMTAgYXQgMTg6MzAgKzAyMDAsIFZpbGxlIFN5cmrDpGzDpCB3 cm90ZToKPiBPbiBUaHUsIERlYyAwNiwgMjAxOCBhdCAwMzoxMToyN1BNICswMTAwLCBQYXVsIEtv Y2lhbGtvd3NraSB3cm90ZToKPiA+IFRoZSBjb2RlIHBhdGggZm9yIGFsbG9jYXRpbmcgdGlsZWQg YnVmZmVycyBoYXMgYSBmZXcgaTkxNS1zcGVjaWZpYyBiaXRzCj4gPiB3aXRob3V0IGNoZWNrcyBm b3IgdGhlIGk5MTUgZHJpdmVyLiBBZGQgdGhlc2UgbWlzc2luZyBjaGVja3MuCj4gCj4gVGhlIGVs c2UgYnJhbmNoIGFsc28gaGFzIGEgYml0IG9mIGk5MTUgc3BlY2lmaWNzIGluIGl0Ogo+IAo+IHZv aWQgaWd0X2dldF9mYl90aWxlX3NpemUoaW50IGZkLCB1aW50NjRfdCB0aWxpbmcsIGludCBmYl9i cHAsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCAqd2lkdGhfcmV0LCB1bnNp Z25lZCAqaGVpZ2h0X3JldCkKPiB7Cj4gICAgICAgICBzd2l0Y2ggKHRpbGluZykgewo+ICAgICAg ICAgY2FzZSBMT0NBTF9EUk1fRk9STUFUX01PRF9OT05FOgo+ICAgICAgICAgICAgICAgICAqd2lk dGhfcmV0ID0gNjQ7Cj4gICAgICAgICAgICAgICAgICpoZWlnaHRfcmV0ID0gMTsKPiAgICAgICAg ICAgICAgICAgYnJlYWs7Cj4gCj4gQnV0IEknbSBub3Qgc3VyZSBpZiB0aGVyZSBpcyBoYXJkd2Fy ZSB0aGF0IHdvdWxkbid0IGJlIGhhcHB5Cj4gd2l0aCA2NCBieXRlIHN0cmlkZSBhbGlnbm1lbnQu CgpSaWdodCwgdGhhdCB3YXNuJ3QgY2F1c2luZyBhbnkgcHJvYmxlbSBzbyBJIGtlcHQgaXQgdW50 b3VjaGVkLgoKV2UgY291bGQgdG90YWxseSBjaGFuZ2UgdGhhdCB0byBhbGlnbiB0byBhIGxvd2Vy IHZhbHVlIChJIHRoaW5rIHdlIG5lZWQKYXQgbGVhc3QgNCBieXRlcyBmb3Igc3RyaWRlIGFsaWdu bWVudCB0byBtYWtlIHBpeG1hbiBoYXBweSB3aXRoIHVzaW5nCnRoZSBidWZmZXIpLgoKSWYgeW91 IHRoaW5rIHRoYXQgY2hhbmdlIGlzIG5lY2Vzc2FyeSwgSSBjb3VsZCBtYWtlIGl0IGEgZm9sbG93 LXVwCnBhdGNoIG9yIGludGVncmF0ZSBpdCBpbiB0aGUgbmV4dCByZXZpc2lvbi4KCkNoZWVycywK ClBhdWwKCj4gPiBGb3IgdGhlIG1hcF9ibyBmdW5jdGlvbiwgaW5pdGlhbGx5IGRlZmluZSB0aGUg cmV0dXJuIHBvaW50ZXIgdG8KPiA+IE1BUF9GQUlMRUQgYW5kIGFzc2VydCB0aGF0IGl0J3Mgbm90 IE1BUF9GQUlMRUQgd2hlbiBubyBtYXBwaW5nIGZ1bmN0aW9uCj4gPiB3YXMgZm91bmQsIGluIG9y ZGVyIHRvIHByb3ZpZGUgYW4gdW5kZXJzdGFuZGFibGUgZXJyb3Igd2hlbiBpdCBvY2N1cnMuCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IFBhdWwgS29jaWFsa293c2tpIDxwYXVsLmtvY2lhbGtvd3Nr aUBib290bGluLmNvbT4KPiA+IC0tLQo+ID4gIGxpYi9pZ3RfZmIuYyB8IDggKysrKysrLS0KPiA+ ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gPiBpbmRleCBmMmU2 Yzg5Zi4uY2NkZjA3ZDAgMTAwNjQ0Cj4gPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiA+ICsrKyBiL2xp Yi9pZ3RfZmIuYwo+ID4gQEAgLTI5OCw2ICsyOTgsNyBAQCBzdGF0aWMgdWludDMyX3QgY2FsY19w bGFuZV9zdHJpZGUoc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiA+ICAJCShmYi0+cGxh bmVfYnBwW3BsYW5lXSAvIDgpOwo+ID4gIAo+ID4gIAlpZiAoZmItPnRpbGluZyAhPSBMT0NBTF9E Uk1fRk9STUFUX01PRF9OT05FICYmCj4gPiArCSAgICBpc19pOTE1X2RldmljZShmYi0+ZmQpICYm Cj4gPiAgCSAgICBpbnRlbF9nZW4oaW50ZWxfZ2V0X2RybV9kZXZpZChmYi0+ZmQpKSA8PSAzKSB7 Cj4gPiAgCQl1aW50MzJfdCBzdHJpZGU7Cj4gPiAgCj4gPiBAQCAtMzI2LDYgKzMyNyw3IEBAIHN0 YXRpYyB1aW50MzJfdCBjYWxjX3BsYW5lX3N0cmlkZShzdHJ1Y3QgaWd0X2ZiICpmYiwgaW50IHBs YW5lKQo+ID4gIHN0YXRpYyB1aW50NjRfdCBjYWxjX3BsYW5lX3NpemUoc3RydWN0IGlndF9mYiAq ZmIsIGludCBwbGFuZSkKPiA+ICB7Cj4gPiAgCWlmIChmYi0+dGlsaW5nICE9IExPQ0FMX0RSTV9G T1JNQVRfTU9EX05PTkUgJiYKPiA+ICsJICAgIGlzX2k5MTVfZGV2aWNlKGZiLT5mZCkgJiYKPiA+ ICAJICAgIGludGVsX2dlbihpbnRlbF9nZXRfZHJtX2RldmlkKGZiLT5mZCkpIDw9IDMpIHsKPiA+ ICAJCXVpbnQ2NF90IG1pbl9zaXplID0gKHVpbnQ2NF90KSBmYi0+c3RyaWRlc1twbGFuZV0gKgo+ ID4gIAkJCWZiLT5wbGFuZV9oZWlnaHRbcGxhbmVdOwo+ID4gQEAgLTE0NjYsNyArMTQ2OCw3IEBA IHN0YXRpYyB2b2lkIGRlc3Ryb3lfY2Fpcm9fc3VyZmFjZV9fZ3R0KHZvaWQgKmFyZykKPiA+ICAK PiA+ICBzdGF0aWMgdm9pZCAqbWFwX2JvKGludCBmZCwgc3RydWN0IGlndF9mYiAqZmIpCj4gPiAg ewo+ID4gLQl2b2lkICpwdHI7Cj4gPiArCXZvaWQgKnB0ciA9IE1BUF9GQUlMRUQ7Cj4gPiAgCj4g PiAgCWlmIChpc19pOTE1X2RldmljZShmZCkpCj4gPiAgCQlnZW1fc2V0X2RvbWFpbihmZCwgZmIt PmdlbV9oYW5kbGUsCj4gPiBAQCAtMTQ3NSw5ICsxNDc3LDExIEBAIHN0YXRpYyB2b2lkICptYXBf Ym8oaW50IGZkLCBzdHJ1Y3QgaWd0X2ZiICpmYikKPiA+ICAJaWYgKGZiLT5pc19kdW1iKQo+ID4g IAkJcHRyID0ga21zdGVzdF9kdW1iX21hcF9idWZmZXIoZmQsIGZiLT5nZW1faGFuZGxlLCBmYi0+ c2l6ZSwKPiA+ICAJCQkJCSAgICAgIFBST1RfUkVBRCB8IFBST1RfV1JJVEUpOwo+ID4gLQllbHNl Cj4gPiArCWVsc2UgaWYgKGlzX2k5MTVfZGV2aWNlKGZkKSkKPiA+ICAJCXB0ciA9IGdlbV9tbWFw X19ndHQoZmQsIGZiLT5nZW1faGFuZGxlLCBmYi0+c2l6ZSwKPiA+ICAJCQkJICAgIFBST1RfUkVB RCB8IFBST1RfV1JJVEUpOwo+ID4gKwllbHNlCj4gPiArCQlpZ3RfYXNzZXJ0KHB0ciAhPSBNQVBf RkFJTEVEKTsKPiAKPiBpZ3RfYXNzZXJ0KDApPwo+IAo+ID4gIAo+ID4gIAlyZXR1cm4gcHRyOwo+ ID4gIH0KPiA+IC0tIAo+ID4gMi4xOS4yCi0tIApQYXVsIEtvY2lhbGtvd3NraSwgQm9vdGxpbiAo Zm9ybWVybHkgRnJlZSBFbGVjdHJvbnMpCkVtYmVkZGVkIExpbnV4IGFuZCBrZXJuZWwgZW5naW5l ZXJpbmcKaHR0cHM6Ly9ib290bGluLmNvbQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2Cg==