From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_exec: Update the list of engines on the actual context
Date: Wed, 5 Feb 2020 12:13:52 +0000 [thread overview]
Message-ID: <dd9bd10f-d43c-bce9-7a89-81e2c10fbc66@linux.intel.com> (raw)
In-Reply-To: <20200205115915.1823074-1-chris@chris-wilson.co.uk>
On 05/02/2020 11:59, Chris Wilson wrote:
> We want to iterate the set of physical engines on this context, so
> update the iterators to act on a particular context.
>
> This tunnel keeps on getting longer.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> lib/i915/gem_engine_topology.h | 7 +++++--
> tests/i915/gem_ctx_exec.c | 2 +-
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/i915/gem_engine_topology.h b/lib/i915/gem_engine_topology.h
> index e40d7ec83..027d86be2 100644
> --- a/lib/i915/gem_engine_topology.h
> +++ b/lib/i915/gem_engine_topology.h
> @@ -67,9 +67,12 @@ struct intel_execution_engine2 gem_eb_flags_to_engine(unsigned int flags);
> intel_next_engine(&i__))
>
> /* needs to replace "for_each_physical_engine" when conflicts are fixed */
> -#define __for_each_physical_engine(fd__, e__) \
> - for (struct intel_engine_data i__ = intel_init_engine_list(fd__, 0); \
> +#define ____for_each_physical_engine(fd__, ctx__, e__) \
> + for (struct intel_engine_data i__ = intel_init_engine_list(fd__, ctx__); \
> ((e__) = intel_get_current_physical_engine(&i__)); \
> intel_next_engine(&i__))
>
> +#define __for_each_physical_engine(fd__, e__) \
> + ____for_each_physical_engine(fd__, 0, e__)
> +
> #endif /* GEM_ENGINE_TOPOLOGY_H */
> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
> index aeb8d2976..5b4e4b3db 100644
> --- a/tests/i915/gem_ctx_exec.c
> +++ b/tests/i915/gem_ctx_exec.c
> @@ -226,7 +226,7 @@ static void nohangcheck_hostile(int i915)
>
> igt_require(__enable_hangcheck(dir, false));
>
> - __for_each_physical_engine(i915, e) {
> + ____for_each_physical_engine(i915, ctx, e) {
> igt_spin_t *spin;
>
> spin = igt_spin_new(i915, ctx,
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-02-05 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 11:59 [Intel-gfx] [PATCH i-g-t] i915/gem_ctx_exec: Update the list of engines on the actual context Chris Wilson
2020-02-05 12:13 ` Tvrtko Ursulin [this message]
2020-02-05 12:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-07 21:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd9bd10f-d43c-bce9-7a89-81e2c10fbc66@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox