From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F4EA6E92D for ; Tue, 17 Dec 2019 01:37:38 +0000 (UTC) Message-ID: From: Dhinakaran Pandiyan Date: Mon, 16 Dec 2019 17:00:47 -0800 In-Reply-To: <20191216235407.23070-1-imre.deak@intel.com> References: <20191216235407.23070-1-imre.deak@intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_fb: Add support for the gen12 media compressed modifier List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dhinakaran.pandiyan@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Imre Deak , igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCAyMDE5LTEyLTE3IGF0IDAxOjU0ICswMjAwLCBJbXJlIERlYWsgd3JvdGU6Cj4gTWVk aWEgY29tcHJlc3NlZCBmcmFtZWJ1ZmZlcnMgZG9uJ3QgaGF2ZSBhIENDUyBDQyBwbGFuZS4gQWRk IGhlbHBlcnMgdG8KPiBzZWxlY3QgdGhlIGRpZmZlcmVudCB0eXBlcyBvZiBDQ1MgcGxhbmVzIGFu ZCBtYWtlIHN1cmUgd2Ugc2V0dXAgdGhlCj4gcGxhbmVzIGNvcnJlY3RseSBmb3IgTUMgZnJhbWVi dWZmZXJzIHRvby4KPiAKPiBOb3RlIHRoYXQgdGhlIG9yZGVyIG9mIE1DIGZyYW1lYnVmZmVyIHBs YW5lcyB0aGlzIGNoYW5nZSBhc3N1bWVzIGlzCj4gCj4gcGxhbmUgMDogWSBwbGFuZQo+IHBsYW5l IDE6IFVWIHBsYW5lCj4gcGxhbmUgMjogQ0NTIHBsYW5lIGZvciBwbGFuZSAwCj4gcGxhbmUgMzog Q0NTIHBsYW5lIGZvciBwbGFuZSAxCj4gCj4gdW5saWtlIHRoZSBvcmRlciBkZWZpbmVkIGluIHRo ZSBsYXRlc3QgZGVjb21wcmVzc2lvbiBrZXJuZWwgcGF0Y2hzZXQuCgpIbW0uIHRoYXQgaXMgaW5k ZWVkIHRoZSBvcmRlciBpbiB0aGUgbGF0ZXN0IChiYWNrIGluIFNlcHRlbWJlcikgcGF0Y2ggc2V0 IEkgc2VudCBvdXQgIApodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMzMz MTEzLz9zZXJpZXM9NjcwNzgmcmV2PTMKCitzdGF0aWMgYm9vbCBpc19jY3NfcGxhbmUoY29uc3Qg c3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIsIGludCBjb2xvcl9wbGFuZSkKK3sKKwlpZiAoIWlz X2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpKQorCQlyZXR1cm4gZmFsc2U7CisKKwlyZXR1cm4g Y29sb3JfcGxhbmUgPj0gZmItPmZvcm1hdC0+bnVtX3BsYW5lcyAvIDI7Cit9CgoKVGhlIGRvY3Mg aW4gdGhlIG1vZGlmaWVyIHdlcmUgcHJvYmFibHkgbm90IHVwZGF0ZWQuCgotREsKCj4gVGhlIGFi b3ZlIG9yZGVyIGlzIHRoZSBsb2dpY2FsIG9uZSB0aGF0IGFsbG93cyB1cyB0byBrZWVwIHRoZSBl eGlzdGluZwo+IHdheSBvZiBoYW5kbGluZyB0aGUgWS9VViBwbGFuZXMuCj4gCj4gQ2M6IE1pa2Eg S2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+Cj4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4g PGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8 aW1yZS5kZWFrQGludGVsLmNvbT4KPiAtLS0KPiAgbGliL2lndF9mYi5jIHwgOTIgKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgNjQgaW5zZXJ0aW9ucygrKSwgMjggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDNiMTQxYjkzLi44YzZjNDI2ZCAx MDA2NDQKPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiArKysgYi9saWIvaWd0X2ZiLmMKPiBAQCAtNDg3 LDE4ICs0ODcsNTAgQEAgc3RhdGljIGJvb2wgaXNfY2NzX21vZGlmaWVyKHVpbnQ2NF90IG1vZGlm aWVyKQo+ICAJCW1vZGlmaWVyID09IEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1M7Cj4gIH0K PiAgCj4gK3N0YXRpYyBib29sIGlzX2Njc19wbGFuZShjb25zdCBzdHJ1Y3QgaWd0X2ZiICpmYiwg aW50IHBsYW5lKQo+ICt7Cj4gKwlpZiAoaXNfZ2VuMTJfbWNfY2NzX21vZGlmaWVyKGZiLT5tb2Rp ZmllcikpCj4gKwkJcmV0dXJuIHBsYW5lID49IGZiLT5udW1fcGxhbmVzIC8gMjsKPiArCj4gKwly ZXR1cm4gcGxhbmUgPiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgYm9vbCBpc19nZW4xMl9jY3NfcGxh bmUoY29uc3Qgc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiArewo+ICsJcmV0dXJuIGlz X2dlbjEyX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpICYmIGlzX2Njc19wbGFuZShmYiwgcGxh bmUpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgYm9vbCBpc19nZW4xMl9jY3NfY2NfcGxhbmUoY29uc3Qg c3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiArewo+ICsJcmV0dXJuIGZiLT5tb2RpZmll ciA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9HRU4xMl9SQ19DQ1NfQ0MgJiYKPiArCSAgICAg ICBwbGFuZSA9PSAyOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGNjc190b19tYWluX3BsYW5lKGNv bnN0IHN0cnVjdCBpZ3RfZmIgKmZiLCBpbnQgcGxhbmUpCj4gK3sKPiArCWlmIChpc19nZW4xMl9j Y3NfY2NfcGxhbmUoZmIsIHBsYW5lKSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlyZXR1cm4gcGxh bmUgLSBmYi0+bnVtX3BsYW5lcyAvIDI7Cj4gK30KPiArCj4gIHN0YXRpYyB1bnNpZ25lZCBmYl9w bGFuZV93aWR0aChjb25zdCBzdHJ1Y3QgaWd0X2ZiICpmYiwgaW50IHBsYW5lKQo+ICB7Cj4gIAlj b25zdCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQgPSBsb29rdXBfZHJtX2Zvcm1h dChmYi0+ZHJtX2Zvcm1hdCk7Cj4gIAo+IC0JaWYgKGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZp ZXIpICYmIHBsYW5lID09IDEpIHsKPiAtCQlpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5t b2RpZmllcikpCj4gLQkJCXJldHVybiBESVZfUk9VTkRfVVAoZmItPndpZHRoLAo+IC0JCQkJCSAg ICA1MTIgLyAoZmItPnBsYW5lX2JwcFswXSAvIDgpKSAqIDY0Owo+IC0JCWVsc2UKPiAtCQkJcmV0 dXJuIERJVl9ST1VORF9VUChmYi0+d2lkdGgsIDEwMjQpICogMTI4Owo+IC0JfSBlbHNlIGlmIChp c19nZW4xMl9jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSAmJiBwbGFuZSA9PSAyKSB7Cj4gKwlp ZiAoaXNfZ2VuMTJfY2NzX2NjX3BsYW5lKGZiLCBwbGFuZSkpIHsKPiAgCQlyZXR1cm4gNjQ7Cj4g Kwl9IGlmIChpc19nZW4xMl9jY3NfcGxhbmUoZmIsIHBsYW5lKSkgewo+ICsJCWludCBtYWluX3Bs YW5lID0gY2NzX3RvX21haW5fcGxhbmUoZmIsIHBsYW5lKTsKPiArCQlpbnQgd2lkdGggPSBmYi0+ d2lkdGg7Cj4gKwo+ICsJCWlmIChtYWluX3BsYW5lKQo+ICsJCQl3aWR0aCA9IERJVl9ST1VORF9V UCh3aWR0aCwgZm9ybWF0LT5oc3ViKTsKPiArCj4gKwkJcmV0dXJuIERJVl9ST1VORF9VUCh3aWR0 aCwKPiArCQkJCSAgICA1MTIgLyAoZmItPnBsYW5lX2JwcFttYWluX3BsYW5lXSAvIDgpKSAqIDY0 Owo+ICsJfSBlbHNlIGlmIChpc19jY3NfcGxhbmUoZmIsIHBsYW5lKSkgewo+ICsJCSByZXR1cm4g RElWX1JPVU5EX1VQKGZiLT53aWR0aCwgMTAyNCkgKiAxMjg7Cj4gIAl9Cj4gIAo+ICAJaWYgKHBs YW5lID09IDApCj4gQEAgLTUxMSw3ICs1NDMsNyBAQCBzdGF0aWMgdW5zaWduZWQgZmJfcGxhbmVf YnBwKGNvbnN0IHN0cnVjdCBpZ3RfZmIgKmZiLCBpbnQgcGxhbmUpCj4gIHsKPiAgCWNvbnN0IHN0 cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1hdCA9IGxvb2t1cF9kcm1fZm9ybWF0KGZiLT5k cm1fZm9ybWF0KTsKPiAgCj4gLQlpZiAoaXNfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmllcikgJiYg KHBsYW5lID09IDEgfHwgcGxhbmUgPT0gMikpCj4gKwlpZiAoaXNfY2NzX3BsYW5lKGZiLCBwbGFu ZSkpCj4gIAkJcmV0dXJuIDg7Cj4gIAllbHNlCj4gIAkJcmV0dXJuIGZvcm1hdC0+cGxhbmVfYnBw W3BsYW5lXTsKPiBAQCAtNTIxLDEzICs1NTMsMTggQEAgc3RhdGljIHVuc2lnbmVkIGZiX3BsYW5l X2hlaWdodChjb25zdCBzdHJ1Y3QgaWd0X2ZiICpmYiwgaW50IHBsYW5lKQo+ICB7Cj4gIAljb25z dCBzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQgPSBsb29rdXBfZHJtX2Zvcm1hdChm Yi0+ZHJtX2Zvcm1hdCk7Cj4gIAo+IC0JaWYgKGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIp ICYmIHBsYW5lID09IDEpIHsKPiAtCQlpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2Rp ZmllcikpCj4gLQkJCXJldHVybiBESVZfUk9VTkRfVVAoZmItPmhlaWdodCwgMTI4KSAqIDQ7Cj4g LQkJZWxzZQo+IC0JCQlyZXR1cm4gRElWX1JPVU5EX1VQKGZiLT5oZWlnaHQsIDUxMikgKiAzMjsK PiAtCX0gZWxzZSBpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmllcikgJiYgcGxh bmUgPT0gMikKPiArCWlmIChpc19nZW4xMl9jY3NfY2NfcGxhbmUoZmIsIHBsYW5lKSkgewo+ICAJ CXJldHVybiAxOwo+ICsJfSBlbHNlIGlmIChpc19nZW4xMl9jY3NfcGxhbmUoZmIsIHBsYW5lKSkg ewo+ICsJCWludCBoZWlnaHQgPSBmYi0+aGVpZ2h0Owo+ICsKPiArCQlpZiAoY2NzX3RvX21haW5f cGxhbmUoZmIsIHBsYW5lKSkKPiArCQkJaGVpZ2h0ID0gRElWX1JPVU5EX1VQKGhlaWdodCwgZm9y bWF0LT52c3ViKTsKPiArCj4gKwkJcmV0dXJuIERJVl9ST1VORF9VUChoZWlnaHQsIDEyOCkgKiA0 Owo+ICsJfSBlbHNlIGlmIChpc19jY3NfcGxhbmUoZmIsIHBsYW5lKSkgewo+ICsJCXJldHVybiBE SVZfUk9VTkRfVVAoZmItPmhlaWdodCwgNTEyKSAqIDMyOwo+ICsJfQo+ICAKPiAgCWlmIChwbGFu ZSA9PSAwKQo+ICAJCXJldHVybiBmYi0+aGVpZ2h0Owo+IEBAIC01MzcsMTYgKzU3NCwxNSBAQCBz dGF0aWMgdW5zaWduZWQgZmJfcGxhbmVfaGVpZ2h0KGNvbnN0IHN0cnVjdCBpZ3RfZmIgKmZiLCBp bnQgcGxhbmUpCj4gIAo+ICBzdGF0aWMgaW50IGZiX251bV9wbGFuZXMoY29uc3Qgc3RydWN0IGln dF9mYiAqZmIpCj4gIHsKPiAtCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1h dCA9IGxvb2t1cF9kcm1fZm9ybWF0KGZiLT5kcm1fZm9ybWF0KTsKPiArCWludCBudW1fcGxhbmVz ID0gbG9va3VwX2RybV9mb3JtYXQoZmItPmRybV9mb3JtYXQpLT5udW1fcGxhbmVzOwo+ICAKPiAt CWlmIChpc19jY3NfbW9kaWZpZXIoZmItPm1vZGlmaWVyKSkgewo+IC0JCWlmIChmYi0+bW9kaWZp ZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfR0VOMTJfUkNfQ0NTX0NDKQo+IC0JCQlyZXR1 cm4gMzsKPiAtCQllbHNlCj4gLQkJCXJldHVybiAyOwo+IC0JfSBlbHNlIHsKPiAtCQlyZXR1cm4g Zm9ybWF0LT5udW1fcGxhbmVzOwo+IC0JfQo+ICsJaWYgKGlzX2Njc19tb2RpZmllcihmYi0+bW9k aWZpZXIpKQo+ICsJCW51bV9wbGFuZXMgKj0gMjsKPiArCj4gKwlpZiAoZmItPm1vZGlmaWVyID09 IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0dFTjEyX1JDX0NDU19DQykKPiArCQludW1fcGxhbmVz Kys7Cj4gKwo+ICsJcmV0dXJuIG51bV9wbGFuZXM7Cj4gIH0KPiAgCj4gIHZvaWQgaWd0X2luaXRf ZmIoc3RydWN0IGlndF9mYiAqZmIsIGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0LAo+IEBA IC02MDQsMTIgKzY0MCwxMiBAQCBzdGF0aWMgdWludDMyX3QgY2FsY19wbGFuZV9zdHJpZGUoc3Ry dWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiAgCQkgKiBzbyB0aGUgZWFzaWVzdCB3YXkgaXMg dG8gYWxpZ24gdGhlIGx1bWEgc3RyaWRlIHRvIDI1Ni4KPiAgCQkgKi8KPiAgCQlyZXR1cm4gQUxJ R04obWluX3N0cmlkZSwgMjU2KTsKPiAtCX0gZWxzZSBpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVy KGZiLT5tb2RpZmllcikgJiYgcGxhbmUgPT0gMSkgewo+IC0JCS8qIEEgbWFpbiBzdXJmYWNlIHVz aW5nIGEgQ0NTIEFVWCBzdXJmYWNlIG11c3QgYmUgNHg0IHRpbGVzIGFsaWduZWQuICovCj4gLQkJ cmV0dXJuIEFMSUdOKG1pbl9zdHJpZGUsIDY0KTsKPiAtCX0gZWxzZSBpZiAoaXNfZ2VuMTJfY2Nz X21vZGlmaWVyKGZiLT5tb2RpZmllcikgJiYgcGxhbmUgPT0gMikgewo+ICsJfSBlbHNlIGlmIChp c19nZW4xMl9jY3NfY2NfcGxhbmUoZmIsIHBsYW5lKSkgewo+ICAJCS8qIGNsZWFyIGNvbG9yIGFs d2F5cyBmaXhlZCB0byA2NCBieXRlcyAqLwo+ICAJCXJldHVybiA2NDsKPiArCX0gZWxzZSBpZiAo aXNfZ2VuMTJfY2NzX3BsYW5lKGZiLCBwbGFuZSkpIHsKPiArCQkvKiBBIG1haW4gc3VyZmFjZSB1 c2luZyBhIENDUyBBVVggc3VyZmFjZSBtdXN0IGJlIDR4NCB0aWxlcyBhbGlnbmVkLiAqLwo+ICsJ CXJldHVybiBBTElHTihtaW5fc3RyaWRlLCA2NCk7Cj4gIAl9IGVsc2Ugewo+ICAJCXVuc2lnbmVk IGludCB0aWxlX3dpZHRoLCB0aWxlX2hlaWdodDsKPiAgCj4gQEAgLTY0NCw3ICs2ODAsNyBAQCBz dGF0aWMgdWludDY0X3QgY2FsY19wbGFuZV9zaXplKHN0cnVjdCBpZ3RfZmIgKmZiLCBpbnQgcGxh bmUpCj4gIAkJc2l6ZSA9IHJvdW5kdXBfcG93ZXJfb2ZfdHdvKHNpemUpOwo+ICAKPiAgCQlyZXR1 cm4gc2l6ZTsKPiAtCX0gZWxzZSBpZiAoaXNfZ2VuMTJfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmll cikgJiYgKHBsYW5lID09IDEgfHwgcGxhbmUgPT0gMikpIHsKPiArCX0gZWxzZSBpZiAoaXNfZ2Vu MTJfY2NzX3BsYW5lKGZiLCBwbGFuZSkpIHsKPiAgCQkvKiBUaGUgQVVYIENDUyBzdXJmYWNlIG11 c3QgYmUgcGFnZSBhbGlnbmVkICovCj4gIAkJcmV0dXJuICh1aW50NjRfdClmYi0+c3RyaWRlc1tw bGFuZV0gKgo+ICAJCQlBTElHTihmYi0+cGxhbmVfaGVpZ2h0W3BsYW5lXSwgNjQpOwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==