public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Thasleem, Mohammed" <mohammed.thasleem@intel.com>
To: Kunal Joshi <kunal1.joshi@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 1/3] tests/intel/kms_mst_helper: Add helper to check for MST outputs
Date: Mon, 23 Feb 2026 23:10:22 +0530	[thread overview]
Message-ID: <ddf7eda9-bde0-4821-9a84-d12c68027f30@intel.com> (raw)
In-Reply-To: <20260220152239.276034-2-kunal1.joshi@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]


On 20-02-2026 08:52 pm, Kunal Joshi wrote:
> Add igt_display_has_mst_output() helper function to check
> if a display has at least one DP MST output connected.
> This is useful for tests that need to verify MST output
> availability before running.
>
> Signed-off-by: Kunal Joshi<kunal1.joshi@intel.com>
> ---
>   tests/intel/kms_mst_helper.c | 19 +++++++++++++++++++
>   tests/intel/kms_mst_helper.h |  1 +
>   2 files changed, 20 insertions(+)
>
> diff --git a/tests/intel/kms_mst_helper.c b/tests/intel/kms_mst_helper.c
> index aef74cd31..6b986a45c 100644
> --- a/tests/intel/kms_mst_helper.c
> +++ b/tests/intel/kms_mst_helper.c
> @@ -46,3 +46,22 @@ int igt_find_all_mst_output_in_topology(int drm_fd, igt_display_t *display,
>   	}
>   	return 0;
>   }
> +
/**
  * igt_display_has_mst_output:
-->with above two lines addition, LGTM:

Reviewed-by: Mohammed Thasleem <mohammed.thasleem@intel.com>

> +/*
> + * @display: pointer to #igt_display_t structure
> + *
> + * Iterates over all connected outputs and checks if any of them
> + * is a DP MST output.
> + *
> + * Returns: true if at least one MST output is found, false otherwise
> + */
> +bool igt_display_has_mst_output(igt_display_t *display)
> +{
> +    igt_output_t *output;
> +
> +    for_each_connected_output(display, output) {
> +        if (igt_check_output_is_dp_mst(output))
> +            return true;
> +    }
> +    return false;
> +}
> diff --git a/tests/intel/kms_mst_helper.h b/tests/intel/kms_mst_helper.h
> index 7391494ab..0e8ece0a0 100644
> --- a/tests/intel/kms_mst_helper.h
> +++ b/tests/intel/kms_mst_helper.h
> @@ -12,4 +12,5 @@ int igt_find_all_mst_output_in_topology(int drm_fd, igt_display_t *display,
>   					igt_output_t *output,
>   					igt_output_t *mst_outputs[],
>   					int *num_mst_outputs);
> +bool igt_display_has_mst_output(igt_display_t *display);
>   #endif

[-- Attachment #2: Type: text/html, Size: 37691 bytes --]

  reply	other threads:[~2026-02-23 17:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 15:22 [PATCH 0/3] tests/kms_pipe_crc_basic: add mst suspend-resume test Kunal Joshi
2026-02-20 15:22 ` [PATCH i-g-t 1/3] tests/intel/kms_mst_helper: Add helper to check for MST outputs Kunal Joshi
2026-02-23 17:40   ` Thasleem, Mohammed [this message]
2026-02-26  4:02   ` Kandpal, Suraj
2026-02-20 15:22 ` [PATCH i-g-t 2/3] lib/igt_kms: Fix max_non_joiner_mode_found Kunal Joshi
2026-02-24 10:30   ` Thasleem, Mohammed
2026-02-26  4:26   ` Kandpal, Suraj
2026-02-20 15:22 ` [PATCH i-g-t 3/3] tests/kms_pipe_crc_basic: Add MST suspend-resume test Kunal Joshi
2026-02-24  8:35   ` Thasleem, Mohammed
2026-02-24 10:27     ` Thasleem, Mohammed
2026-03-03  6:18   ` Kandpal, Suraj
2026-03-10  4:49     ` Kandpal, Suraj
2026-03-10  4:53       ` Kandpal, Suraj
2026-02-20 18:31 ` ✓ Xe.CI.BAT: success for tests/kms_pipe_crc_basic: add mst suspend-resume test (rev4) Patchwork
2026-02-20 19:02 ` ✓ i915.CI.BAT: " Patchwork
2026-02-21  4:26 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-21  8:38 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddf7eda9-bde0-4821-9a84-d12c68027f30@intel.com \
    --to=mohammed.thasleem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox