public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Only require the scheduler
Date: Mon, 29 Jul 2019 08:54:32 +0100	[thread overview]
Message-ID: <de5557ea-f094-dd38-c823-6bfee1a13274@linux.intel.com> (raw)
In-Reply-To: <20190728092322.23239-1-chris@chris-wilson.co.uk>


On 28/07/2019 10:23, Chris Wilson wrote:
> If the legacy ringbuffer doesn't support scheduling, it doesn't set the
> cap! Hypothetically if one were to enable ringbuffer scheduling, this is
> part of its testing suite.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_exec_schedule.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c
> index 7b4186228..4ccacba41 100644
> --- a/tests/i915/gem_exec_schedule.c
> +++ b/tests/i915/gem_exec_schedule.c
> @@ -1774,9 +1774,6 @@ igt_main
>   		igt_fixture {
>   			igt_require(gem_scheduler_enabled(fd));
>   			igt_require(gem_scheduler_has_ctx_priority(fd));
> -
> -			/* need separate rings */
> -			igt_require(gem_has_execlists(fd));
>   		}
>   
>   		for (e = intel_execution_engines; e->name; e++) {
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-07-29  7:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-28  9:23 [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Only require the scheduler Chris Wilson
2019-07-28 22:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-07-29  7:54 ` Tvrtko Ursulin [this message]
2019-07-29 12:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de5557ea-f094-dd38-c823-6bfee1a13274@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox