From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B807989A4A for ; Tue, 19 Mar 2019 10:22:36 +0000 (UTC) References: <20190318232812.1307-1-andi.shyti@intel.com> <20190318232812.1307-7-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: Date: Tue, 19 Mar 2019 10:22:20 +0000 MIME-Version: 1.0 In-Reply-To: <20190318232812.1307-7-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v12 6/7] lib/igt_gt: use for_each_engine_class_instance to loop through active engines List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDE4LzAzLzIwMTkgMjM6MjgsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gRXh0ZW5kIHRoZSAnZm9y X2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlJyBzbyB0aGF0IGl0IGNhbiBsb29wCj4gb25seSB0 aHJvdWdoIGFjdGl2ZSBlbmdpbmVzLgo+IAo+IFRoZSAnZm9yX2VhY2hfZW5naW5lX2NsYXNzX2lu c3RhbmNlKCknIGRlZmluZSBzdGFydHMgaXRzIGxvb3AKPiBmcm9tIGdlbmVyYXRpbmcgYSAnc3Ry dWN0IGludGVsX2VuZ2luZV9kYXRhJyB0aGF0IGNvbnRhaW5zIG9ubHkKPiB0aGUgY3VycmVudCBl bmdpbmVzIGFuZCBpdCBsb29wcyB0aHJvdWdoIHRoZSBsaXN0Lgo+IAo+IEEgbmV3IHBhcmFtZXRl ciBpcyBhZGRlZCB3aGljaCByZWZlcnMgdG8gdGhlIGNvbnRleHQsIHRvIHdoaWNoCj4gZW5naW5l cyBhciBib3VuZC4KPiAKPiBVcGRhdGUgdGVzdHMvcGVyZl9wbXUuYyB0aGF0IHVzZXMgdGhlCj4g J2Zvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0YW5jZSgpJyBsb29wLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEFuZGkgU2h5dGkgPGFuZGkuc2h5dGlAaW50ZWwuY29tPgo+IC0tLQo+ICAgbGliL2lndF9n dC5oICAgICB8ICA5ICsrKysrKy0tLQo+ICAgdGVzdHMvcGVyZl9wbXUuYyB8IDIxICsrKysrKysr KysrLS0tLS0tLS0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9ndC5oIGIvbGliL2lndF9ndC5o Cj4gaW5kZXggNDc1YzBiM2MzY2M2Li4yMmJhYWJjZTdiYjAgMTAwNjQ0Cj4gLS0tIGEvbGliL2ln dF9ndC5oCj4gKysrIGIvbGliL2lndF9ndC5oCj4gQEAgLTExNyw4ICsxMTcsMTEgQEAgdm9pZCBn ZW1fcmVxdWlyZV9lbmdpbmUoaW50IGdlbV9mZCwKPiAgICNkZWZpbmUgX19mb3JfZWFjaF9lbmdp bmVfY2xhc3NfaW5zdGFuY2UoZV9fKSBcCj4gICAJZm9yICgoZV9fKSA9IGludGVsX2V4ZWN1dGlv bl9lbmdpbmVzMjsgKGVfXyktPm5hbWU7IChlX18pKyspCj4gICAKPiAtI2RlZmluZSBmb3JfZWFj aF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmRfXywgZV9fKSBcCj4gLQlmb3IgKChlX18pID0gaW50 ZWxfZXhlY3V0aW9uX2VuZ2luZXMyOyAoZV9fKS0+bmFtZTsgKGVfXykrKykgXAo+IC0JCWZvcl9p ZiAoZ2VtX2hhc19lbmdpbmUoKGZkX18pLCAoZV9fKS0+Y2xhc3MsIChlX18pLT5pbnN0YW5jZSkp Cj4gKyNpbmNsdWRlICJpOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuaCIKPiArCj4gKyNkZWZpbmUg Zm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGZkX18sIGN0eF9fLCBlX18pIFwKPiArCWZv ciAoc3RydWN0IGludGVsX2VuZ2luZV9kYXRhIGlfXyA9IGludGVsX2luaXRfZW5naW5lX2xpc3Qo ZmRfXywgY3R4X18pOyBcCj4gKwkJKChlX18pID0gKGlfXy5uIDwgaV9fLm5lbmdpbmVzKSA/ICZp X18uZW5naW5lc1tpX18ubl0gOiBOVUxMKTsgXAo+ICsJCQlpX18ubisrKQo+ICAgCj4gICAjZW5k aWYgLyogSUdUX0dUX0ggKi8KPiBkaWZmIC0tZ2l0IGEvdGVzdHMvcGVyZl9wbXUuYyBiL3Rlc3Rz L3BlcmZfcG11LmMKPiBpbmRleCA0NTI5MTI5OGMwMjEuLjFiMDIxOTIyMDFlOCAxMDA2NDQKPiAt LS0gYS90ZXN0cy9wZXJmX3BtdS5jCj4gKysrIGIvdGVzdHMvcGVyZl9wbXUuYwo+IEBAIC00MzQs NyArNDM0LDcgQEAgYnVzeV9jaGVja19hbGwoaW50IGdlbV9mZCwgY29uc3Qgc3RydWN0IGludGVs X2V4ZWN1dGlvbl9lbmdpbmUyICplLAo+ICAgCj4gICAJaSA9IDA7Cj4gICAJZmRbMF0gPSAtMTsK PiAtCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0YW5jZShnZW1fZmQsIGVfKSB7Cj4gKwlmb3Jf ZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCAwLCBlXykgewoKSG93IG11Y2ggY2h1 cm4gaXQgd291bGQgYmUgdG8gZHJvcCBmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UgYW5k IApjb252ZXJ0IHRoZSBmb3JfZWFjaF9lbmdpbmVfcGh5c2ljYWwgbWFjcm8gdG8gdXNlIHRoZSBu ZXcgc2NoZW1lPwoKSSBhbSB0aGlua2luZyBhYm91dCBlbmRpbmcgd2l0aCB0d28gbWFjcm9zOgoK Zm9yX2VhY2hfZW5naW5lX3BoeXNpY2FsKGZkLCBlKSAvLyBvciBub3QgZSwgaWYgaXQgaXMgaW4g dGhlIGl0ZXJhdG9yPwoKZm9yX2VhY2hfZW5naW5lX2NvbnRleHQoZmQsIGN0eCwgZSkgLy8gd2hl biB0ZXN0cyBhcmUgdXNpbmcgY29udGV4dHMKClRoZSBmb3JtZXIgd291bGQganVzdCBiZToKCiNk ZWZpbmUgZm9yX2VhY2hfZW5naW5lX3BoeXNpY2FsKGZkKSBmb3JfZWFjaF9lbmdpbmVfY29udGV4 dChmZCwgMCkKCkNocmlzIHlvdXIgb3Bpbmlvbj8KClJlZ2FyZHMsCgpUdnJ0a28KCj4gICAJCWlm IChlID09IGVfKQo+ICAgCQkJYnVzeV9pZHggPSBpOwo+ICAgCj4gQEAgLTQ3MywxNSArNDczLDE2 IEBAIGJ1c3lfY2hlY2tfYWxsKGludCBnZW1fZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRp b25fZW5naW5lMiAqZSwKPiAgIHN0YXRpYyB2b2lkCj4gICBfX3N1Ym1pdF9zcGluX2JhdGNoKGlu dCBnZW1fZmQsIGlndF9zcGluX3QgKnNwaW4sCj4gICAJCSAgICBjb25zdCBzdHJ1Y3QgaW50ZWxf ZXhlY3V0aW9uX2VuZ2luZTIgKmUsCj4gLQkJICAgIGludCBvZmZzZXQpCj4gKwkJICAgIGludCBv ZmZzZXQsCj4gKwkJICAgIHVuc2lnbmVkIGludCBpKQo+ICAgewo+ICAgCXN0cnVjdCBkcm1faTkx NV9nZW1fZXhlY2J1ZmZlcjIgZWIgPSBzcGluLT5leGVjYnVmOwo+ICAgCj4gICAJZWIuZmxhZ3Mg Jj0gfigweDNmIHwgSTkxNV9FWEVDX0JTRF9NQVNLKTsKPiAtCWViLmZsYWdzIHw9IGUycmluZyhn ZW1fZmQsIGUpIHwgSTkxNV9FWEVDX05PX1JFTE9DOwo+ICsJZWIuZmxhZ3MgfD0gSTkxNV9FWEVD X05PX1JFTE9DOwo+ICAgCWViLmJhdGNoX3N0YXJ0X29mZnNldCArPSBvZmZzZXQ7Cj4gICAKPiAt CWdlbV9leGVjYnVmKGdlbV9mZCwgJmViKTsKPiArCWdlbV9jb250ZXh0X2V4ZWNidWYoZ2VtX2Zk LCAmZWIsICplLCBpLCAwKTsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQKPiBAQCAtNDk3LDEx ICs0OTgsMTEgQEAgbW9zdF9idXN5X2NoZWNrX2FsbChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3Qg aW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUsCj4gICAJdW5zaWduZWQgaW50IGlkbGVfaWR4LCBp Owo+ICAgCj4gICAJaSA9IDA7Cj4gLQlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2Vt X2ZkLCBlXykgewo+ICsJZm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGdlbV9mZCwgMCwg ZV8pIHsKPiAgIAkJaWYgKGUgPT0gZV8pCj4gICAJCQlpZGxlX2lkeCA9IGk7Cj4gICAJCWVsc2Ug aWYgKHNwaW4pCj4gLQkJCV9fc3VibWl0X3NwaW5fYmF0Y2goZ2VtX2ZkLCBzcGluLCBlXywgNjQp Owo+ICsJCQlfX3N1Ym1pdF9zcGluX2JhdGNoKGdlbV9mZCwgc3BpbiwgZV8sIDY0LCBpICsgMSk7 Cj4gICAJCWVsc2UKPiAgIAkJCXNwaW4gPSBfX3NwaW5fcG9sbChnZW1fZmQsIDAsIGUycmluZyhn ZW1fZmQsIGVfKSk7Cj4gICAKPiBAQCAtNTU0LDkgKzU1NSw5IEBAIGFsbF9idXN5X2NoZWNrX2Fs bChpbnQgZ2VtX2ZkLCBjb25zdCB1bnNpZ25lZCBpbnQgbnVtX2VuZ2luZXMsCj4gICAJdW5zaWdu ZWQgaW50IGk7Cj4gICAKPiAgIAlpID0gMDsKPiAtCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0 YW5jZShnZW1fZmQsIGUpIHsKPiArCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0YW5jZShnZW1f ZmQsIDAsIGUpIHsKPiAgIAkJaWYgKHNwaW4pCj4gLQkJCV9fc3VibWl0X3NwaW5fYmF0Y2goZ2Vt X2ZkLCBzcGluLCBlLCA2NCk7Cj4gKwkJCV9fc3VibWl0X3NwaW5fYmF0Y2goZ2VtX2ZkLCBzcGlu LCBlLCA2NCwgaSArIDEpOwo+ICAgCQllbHNlCj4gICAJCQlzcGluID0gX19zcGluX3BvbGwoZ2Vt X2ZkLCAwLCBlMnJpbmcoZ2VtX2ZkLCBlKSk7Cj4gICAKPiBAQCAtMTU5Nyw3ICsxNTk4LDcgQEAg YWNjdXJhY3koaW50IGdlbV9mZCwgY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUy ICplLAo+ICAgCj4gICAJCQkJLyogUmVzdGFydCB0aGUgc3BpbmJhdGNoLiAqLwo+ICAgCQkJCV9f cmVhcm1fc3Bpbl9iYXRjaChzcGluKTsKPiAtCQkJCV9fc3VibWl0X3NwaW5fYmF0Y2goZ2VtX2Zk LCBzcGluLCBlLCAwKTsKPiArCQkJCV9fc3VibWl0X3NwaW5fYmF0Y2goZ2VtX2ZkLCBzcGluLCBl LCAwLCAwKTsKPiAgIAo+ICAgCQkJCS8qIFBXTSBidXN5IHNsZWVwLiAqLwo+ICAgCQkJCWxvb3Bf YnVzeSA9IGlndF9uc2VjX2VsYXBzZWQoJnN0YXJ0KTsKPiBAQCAtMTY4Myw3ICsxNjg0LDcgQEAg aWd0X21haW4KPiAgIAkJaWd0X3JlcXVpcmVfZ2VtKGZkKTsKPiAgIAkJaWd0X3JlcXVpcmUoaTkx NV90eXBlX2lkKCkgPiAwKTsKPiAgIAo+IC0JCWZvcl9lYWNoX2VuZ2luZV9jbGFzc19pbnN0YW5j ZShmZCwgZSkKPiArCQlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmQsIDAsIGUpCj4g ICAJCQludW1fZW5naW5lcysrOwo+ICAgCX0KPiAgIAo+IApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lndC1kZXY=