Re: [PATCH] tests/kms_flip: Fix regression on non-Intel devices in event_loop

["Michał Grzelak" <michal.grzelak@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

Hi Alex,

On Thu, 9 Apr 2026, Alex Hung wrote:
> Guard the device-id query with is_intel_device() so the "wa" flag is
> only computed on Intel hardware, restoring the pre-regression behavior
> for all other drivers.
>
> This fixes the following regression:
>
> (kms_flip:15463) intel_chipset-CRITICAL: Test assertion failure function intel_get_drm_devid, file ../lib/intel_chipset.c:145:
> (kms_flip:15463) intel_chipset-CRITICAL: Failed assertion: is_intel_device(fd)
>
> Fixes: 2a9f1c1ae ("tests/kms_flip: test suspend at most twice on SNB && BMG")
> Signed-off-by: Alex Hung <alex.hung@amd.com>

Looks good to me.

Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>

BR,
Michał

> ---
> tests/kms_flip.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 81fa8dd5c..1ef9492ba 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1327,11 +1327,12 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
> 	unsigned long start, end;
> 	uint32_t devid;
> 	int count = 0;
> -	bool wa;
> +	bool wa = false;
>
> -	devid = intel_get_drm_devid(drm_fd);
> -
> -	wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
> +	if (is_intel_device(drm_fd)) {
> +		devid = intel_get_drm_devid(drm_fd);
> +		wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
> +	}
>
> 	start = gettime_us();
>
> -- 
> 2.43.0
>
>