Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Remove unused argument in exec_blit

[Karolina Stolarek <karolina.stolarek@intel.com>]

On 30.06.2023 17:43, Kamil Konieczny wrote:
> Hi Karolina,
> On 2023-06-28 at 10:10:50 +0200, Karolina Stolarek wrote:
>> We don't use information about platform's gen anymore, so
>> stop passing it in.
>>
>> Signed-off-by: Karolina Stolarek <karolina.stolarek@intel.com>
> 
> Even if it will be needed we can get it from fd, so

That is true, many thanks for the review, Kamil.

And I see that my changes are already merged, even more thanks to you :)

All the best,
Karolina

> 
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> 
>> ---
>>   lib/intel_batchbuffer.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index 186f65aff..0e92c6f70 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -214,8 +214,8 @@ static uint32_t find_engine(const intel_ctx_cfg_t *cfg, unsigned int class)
>>   
>>   static void exec_blit(int fd,
>>   		      struct drm_i915_gem_exec_object2 *objs,
>> -		      uint32_t count, unsigned int gen,
>> -		      uint32_t ctx, const intel_ctx_cfg_t *cfg)
>> +		      uint32_t count, uint32_t ctx,
>> +		      const intel_ctx_cfg_t *cfg)
>>   {
>>   	struct drm_i915_gem_execbuffer2 exec;
>>   	uint32_t devid = intel_get_drm_devid(fd);
>> @@ -514,7 +514,7 @@ void igt_blitter_src_copy(int fd,
>>   		objs[2].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
>>   	}
>>   
>> -	exec_blit(fd, objs, 3, gen, ctx, cfg);
>> +	exec_blit(fd, objs, 3, ctx, cfg);
>>   
>>   	gem_close(fd, batch_handle);
>>   }
>> @@ -636,7 +636,7 @@ void igt_blitter_fast_copy__raw(int fd,
>>   		objs[2].flags |= EXEC_OBJECT_PINNED;
>>   	}
>>   
>> -	exec_blit(fd, objs, 3, intel_gen(intel_get_drm_devid(fd)), ctx, cfg);
>> +	exec_blit(fd, objs, 3, ctx, cfg);
>>   
>>   	gem_close(fd, batch_handle);
>>   }
>> -- 
>> 2.25.1
>>