From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190322092155.1656-2-chris@chris-wilson.co.uk> <20190326091824.17228-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: Date: Tue, 26 Mar 2019 09:52:05 +0000 MIME-Version: 1.0 In-Reply-To: <20190326091824.17228-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t v2] lib: Add GPU power measurement List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin List-ID: Ck9uIDI2LzAzLzIwMTkgMDk6MTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBSZWFkIHRoZSBSQVBM IHBvd2VyIG1ldHJpY3MgY291cnRlc3kgb2YgcGVyZi4gT3IgeW91ciBsb2NhbCBIVwo+IGVxdWl2 YWxlbnQ/Cj4gCj4gdjI6IHVzZWxvY2FsZSgpCj4gdjM6IFVzZSBncHVfcG93ZXJfcygpLCBncHVf cG93ZXJfSigpLCBncHVfcG93ZXJfVygpIHRvIHRyeSBhbmQgbWFrZSB0aGUKPiBzY2FsZSBmYWN0 b3JzIHNlbGYtY29uc2lzdGVudC4KPiB2NDogVXNlIGlndF9zeXNmcwo+IAo+IFNpZ25lZC1vZmYt Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgbGliL01ha2VmaWxl LmFtICAgICAgfCAgMSArCj4gICBsaWIvTWFrZWZpbGUuc291cmNlcyB8ICAyICsrCj4gICBsaWIv aWd0X2dwdV9wb3dlci5jICB8IDc4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gICBsaWIvaWd0X2dwdV9wb3dlci5oICB8IDY2ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAgIGxpYi9tZXNvbi5idWlsZCAgICAgIHwgIDIgKysKPiAg IDUgZmlsZXMgY2hhbmdlZCwgMTQ5IGluc2VydGlvbnMoKykKPiAgIGNyZWF0ZSBtb2RlIDEwMDY0 NCBsaWIvaWd0X2dwdV9wb3dlci5jCj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgbGliL2lndF9ncHVf cG93ZXIuaAo+IAo+IGRpZmYgLS1naXQgYS9saWIvTWFrZWZpbGUuYW0gYi9saWIvTWFrZWZpbGUu YW0KPiBpbmRleCAzZTZhN2ZkYmEuLjYyZThiZGE3MyAxMDA2NDQKPiAtLS0gYS9saWIvTWFrZWZp bGUuYW0KPiArKysgYi9saWIvTWFrZWZpbGUuYW0KPiBAQCAtODQsNCArODQsNSBAQCBsaWJpbnRl bF90b29sc19sYV9MSUJBREQgPSBcCj4gICAJJChMSUJVREVWX0xJQlMpIFwKPiAgIAkkKFBJWE1B Tl9MSUJTKSBcCj4gICAJJChHTElCX0xJQlMpIFwKPiArCWxpYmlndF9wZXJmLmxhIFwKPiAgIAkt bG0KPiBkaWZmIC0tZ2l0IGEvbGliL01ha2VmaWxlLnNvdXJjZXMgYi9saWIvTWFrZWZpbGUuc291 cmNlcwo+IGluZGV4IGNmMjcyMDk4MS4uZTAwMzQ3Zjk0IDEwMDY0NAo+IC0tLSBhL2xpYi9NYWtl ZmlsZS5zb3VyY2VzCj4gKysrIGIvbGliL01ha2VmaWxlLnNvdXJjZXMKPiBAQCAtMjYsNiArMjYs OCBAQCBsaWJfc291cmNlX2xpc3QgPQkgCVwKPiAgIAlpZ3RfY29sb3JfZW5jb2RpbmcuYwlcCj4g ICAJaWd0X2NvbG9yX2VuY29kaW5nLmgJXAo+ICAgCWlndF9lZGlkX3RlbXBsYXRlLmgJXAo+ICsJ aWd0X2dwdV9wb3dlci5jCQlcCj4gKwlpZ3RfZ3B1X3Bvd2VyLmgJCVwKPiAgIAlpZ3RfZ3QuYwkJ XAo+ICAgCWlndF9ndC5oCQlcCj4gICAJaWd0X2d2dC5jCQlcCj4gZGlmZiAtLWdpdCBhL2xpYi9p Z3RfZ3B1X3Bvd2VyLmMgYi9saWIvaWd0X2dwdV9wb3dlci5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2 NDQKPiBpbmRleCAwMDAwMDAwMDAuLjYxODQyZTE3ZQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9s aWIvaWd0X2dwdV9wb3dlci5jCj4gQEAgLTAsMCArMSw3OCBAQAo+ICsjaW5jbHVkZSA8Y3R5cGUu aD4KPiArI2luY2x1ZGUgPGVycm5vLmg+Cj4gKyNpbmNsdWRlIDxmY250bC5oPgo+ICsjaW5jbHVk ZSA8bG9jYWxlLmg+Cj4gKyNpbmNsdWRlIDxtYXRoLmg+Cj4gKyNpbmNsdWRlIDx1bmlzdGQuaD4K PiArI2luY2x1ZGUgPGludHR5cGVzLmg+Cj4gKwo+ICsjaW5jbHVkZSAiaWd0X2dwdV9wb3dlci5o Igo+ICsjaW5jbHVkZSAiaWd0X3BlcmYuaCIKPiArI2luY2x1ZGUgImlndF9zeXNmcy5oIgo+ICsK PiArc3RydWN0IHJhcGwgewo+ICsJdWludDY0X3QgcG93ZXIsIHR5cGU7Cj4gKwlkb3VibGUgc2Nh bGU7Cj4gK307Cj4gKwo+ICtzdGF0aWMgaW50IHJhcGxfcGFyc2Uoc3RydWN0IHJhcGwgKnIpCj4g K3sKPiArCWxvY2FsZV90IGxvY2FsZSwgb2xkbG9jYWxlOwo+ICsJaW50IGRpcjsKPiArCj4gKwlk aXIgPSBvcGVuKCIvc3lzL2RldmljZXMvcG93ZXIiLCBPX1JET05MWSk7Cj4gKwlpZiAoZGlyIDwg MCkKPiArCQlyZXR1cm4gLWVycm5vOwo+ICsKPiArCS8qIFJlcGxhY2UgdXNlciBlbnZpcm9ubWVu dCB3aXRoIHBsYWluIEMgdG8gbWF0Y2gga2VybmVsIGZvcm1hdCAqLwo+ICsJbG9jYWxlID0gbmV3 bG9jYWxlKExDX0FMTCwgIkMiLCAwKTsKPiArCW9sZGxvY2FsZSA9IHVzZWxvY2FsZShsb2NhbGUp Owo+ICsKPiArCW1lbXNldChyLCAwLCBzaXplb2YoKnIpKTsKPiArCWlndF9zeXNmc19zY2FuZihk aXIsICJ0eXBlIiwgIiUiUFJJdTY0LCAmci0+dHlwZSk7Cj4gKwlpZ3Rfc3lzZnNfc2NhbmYoZGly LCAiZXZlbnRzL2VuZXJneS1ncHUiLCAiZXZlbnQ9JSJQUkl4NjQsICZyLT5wb3dlcik7Cj4gKwlp Z3Rfc3lzZnNfc2NhbmYoZGlyLCAiZXZlbnRzL2VuZXJneS1ncHUuc2NhbGUiLCAiJWxmIiwgJnIt PnNjYWxlKTsKCkNoZWNrIHJldHVybiBjb2Rlcz8KCj4gKwo+ICsJdXNlbG9jYWxlKG9sZGxvY2Fs ZSk7Cj4gKwlmcmVlbG9jYWxlKGxvY2FsZSk7Cj4gKwo+ICsJY2xvc2UoZGlyKTsKPiArCj4gKwlp ZiAoaXNuYW4oci0+c2NhbGUpIHx8ICFyLT5zY2FsZSkKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAr Cj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAraW50IGdwdV9wb3dlcl9vcGVuKHN0cnVjdCBncHVf cG93ZXIgKnBvd2VyKQo+ICt7Cj4gKwlzdHJ1Y3QgcmFwbCByOwo+ICsKPiArCXBvd2VyLT5mZCA9 IHJhcGxfcGFyc2UoJnIpOwo+ICsJaWYgKHBvd2VyLT5mZCA8IDApCj4gKwkJZ290byBlcnI7Cj4g Kwo+ICsJcG93ZXItPmZkID0gaWd0X3BlcmZfb3BlbihyLnR5cGUsIHIucG93ZXIpOwo+ICsJaWYg KHBvd2VyLT5mZCA8IDApIHsKPiArCQlwb3dlci0+ZmQgPSAtZXJybm87Cj4gKwkJZ290byBlcnI7 Cj4gKwl9Cj4gKwo+ICsJcG93ZXItPnNjYWxlID0gci5zY2FsZTsKPiArCj4gKwlyZXR1cm4gMDsK PiArCj4gK2VycjoKPiArCWVycm5vID0gMDsKPiArCXJldHVybiBwb3dlci0+ZmQ7Cj4gK30KPiAr Cj4gK2Jvb2wgZ3B1X3Bvd2VyX3JlYWQoc3RydWN0IGdwdV9wb3dlciAqcG93ZXIsIHN0cnVjdCBn cHVfcG93ZXJfc2FtcGxlICpzKQo+ICt7Cj4gKwlyZXR1cm4gcmVhZChwb3dlci0+ZmQsIHMsIHNp emVvZigqcykpID09IHNpemVvZigqcyk7Cj4gK30KPiArCj4gK3ZvaWQgZ3B1X3Bvd2VyX2Nsb3Nl KHN0cnVjdCBncHVfcG93ZXIgKnBvd2VyKQo+ICt7Cj4gKwljbG9zZShwb3dlci0+ZmQpOwo+ICt9 Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZ3B1X3Bvd2VyLmggYi9saWIvaWd0X2dwdV9wb3dlci5o Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAuLjAzMmU0OGIxMQo+IC0t LSAvZGV2L251bGwKPiArKysgYi9saWIvaWd0X2dwdV9wb3dlci5oCj4gQEAgLTAsMCArMSw2NiBA QAo+ICsvKgo+ICsgKiBDb3B5cmlnaHQgwqkgMjAxOSBJbnRlbCBDb3Jwb3JhdGlvbgo+ICsgKgo+ ICsgKiBQZXJtaXNzaW9uIGlzIGhlcmVieSBncmFudGVkLCBmcmVlIG9mIGNoYXJnZSwgdG8gYW55 IHBlcnNvbiBvYnRhaW5pbmcgYQo+ICsgKiBjb3B5IG9mIHRoaXMgc29mdHdhcmUgYW5kIGFzc29j aWF0ZWQgZG9jdW1lbnRhdGlvbiBmaWxlcyAodGhlICJTb2Z0d2FyZSIpLAo+ICsgKiB0byBkZWFs IGluIHRoZSBTb2Z0d2FyZSB3aXRob3V0IHJlc3RyaWN0aW9uLCBpbmNsdWRpbmcgd2l0aG91dCBs aW1pdGF0aW9uCj4gKyAqIHRoZSByaWdodHMgdG8gdXNlLCBjb3B5LCBtb2RpZnksIG1lcmdlLCBw dWJsaXNoLCBkaXN0cmlidXRlLCBzdWJsaWNlbnNlLAo+ICsgKiBhbmQvb3Igc2VsbCBjb3BpZXMg b2YgdGhlIFNvZnR3YXJlLCBhbmQgdG8gcGVybWl0IHBlcnNvbnMgdG8gd2hvbSB0aGUKPiArICog U29mdHdhcmUgaXMgZnVybmlzaGVkIHRvIGRvIHNvLCBzdWJqZWN0IHRvIHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9uczoKPiArICoKPiArICogVGhlIGFib3ZlIGNvcHlyaWdodCBub3RpY2UgYW5kIHRo aXMgcGVybWlzc2lvbiBub3RpY2UgKGluY2x1ZGluZyB0aGUgbmV4dAo+ICsgKiBwYXJhZ3JhcGgp IHNoYWxsIGJlIGluY2x1ZGVkIGluIGFsbCBjb3BpZXMgb3Igc3Vic3RhbnRpYWwgcG9ydGlvbnMg b2YgdGhlCj4gKyAqIFNvZnR3YXJlLgo+ICsgKgo+ICsgKiBUSEUgU09GVFdBUkUgSVMgUFJPVklE RUQgIkFTIElTIiwgV0lUSE9VVCBXQVJSQU5UWSBPRiBBTlkgS0lORCwgRVhQUkVTUyBPUgo+ICsg KiBJTVBMSUVELCBJTkNMVURJTkcgQlVUIE5PVCBMSU1JVEVEIFRPIFRIRSBXQVJSQU5USUVTIE9G IE1FUkNIQU5UQUJJTElUWSwKPiArICogRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0Ug QU5EIE5PTklORlJJTkdFTUVOVC4gIElOIE5PIEVWRU5UIFNIQUxMCj4gKyAqIFRIRSBBVVRIT1JT IE9SIENPUFlSSUdIVCBIT0xERVJTIEJFIExJQUJMRSBGT1IgQU5ZIENMQUlNLCBEQU1BR0VTIE9S IE9USEVSCj4gKyAqIExJQUJJTElUWSwgV0hFVEhFUiBJTiBBTiBBQ1RJT04gT0YgQ09OVFJBQ1Qs IFRPUlQgT1IgT1RIRVJXSVNFLCBBUklTSU5HCj4gKyAqIEZST00sIE9VVCBPRiBPUiBJTiBDT05O RUNUSU9OIFdJVEggVEhFIFNPRlRXQVJFIE9SIFRIRSBVU0UgT1IgT1RIRVIgREVBTElOR1MKPiAr ICogSU4gVEhFIFNPRlRXQVJFLgo+ICsgKgo+ICsgKi8KPiArCj4gKyNpZm5kZWYgSUdUX0dQVV9Q T1dFUl9ICj4gKyNkZWZpbmUgSUdUX0dQVV9QT1dFUl9ICj4gKwo+ICsjaW5jbHVkZSA8c3RkYm9v bC5oPgo+ICsjaW5jbHVkZSA8c3RkaW50Lmg+Cj4gKwo+ICtzdHJ1Y3QgZ3B1X3Bvd2VyIHsKPiAr CWludCBmZDsKPiArCWRvdWJsZSBzY2FsZTsKPiArfTsKPiArCj4gK3N0cnVjdCBncHVfcG93ZXJf c2FtcGxlIHsKPiArCXVpbnQ2NF90IGVuZXJneTsKPiArCXVpbnQ2NF90IHRpbWU7Cj4gK307Cj4g Kwo+ICtpbnQgZ3B1X3Bvd2VyX29wZW4oc3RydWN0IGdwdV9wb3dlciAqcG93ZXIpOwo+ICtib29s IGdwdV9wb3dlcl9yZWFkKHN0cnVjdCBncHVfcG93ZXIgKnBvd2VyLCBzdHJ1Y3QgZ3B1X3Bvd2Vy X3NhbXBsZSAqcyk7Cj4gK3ZvaWQgZ3B1X3Bvd2VyX2Nsb3NlKHN0cnVjdCBncHVfcG93ZXIgKnBv d2VyKTsKPiArCj4gK3N0YXRpYyBpbmxpbmUgZG91YmxlIGdwdV9wb3dlcl9KKGNvbnN0IHN0cnVj dCBncHVfcG93ZXIgKnAsCj4gKwkJCQkgY29uc3Qgc3RydWN0IGdwdV9wb3dlcl9zYW1wbGUgKnQw LAo+ICsJCQkJIGNvbnN0IHN0cnVjdCBncHVfcG93ZXJfc2FtcGxlICp0MSkKCid0JyBtYWtlcyBt ZSB0aGluayBvZiB0aW1lIC0gcmVuYW1lIHRbMDFdIHRvIHNbMDFdIGZvciBzYW1wbGU/Cgo+ICt7 Cj4gKwlyZXR1cm4gKHQxLT5lbmVyZ3kgLSB0MC0+ZW5lcmd5KSAqIHAtPnNjYWxlOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgaW5saW5lIGRvdWJsZSBncHVfcG93ZXJfcyhjb25zdCBzdHJ1Y3QgZ3B1X3Bv d2VyICpwLAo+ICsJCQkJIGNvbnN0IHN0cnVjdCBncHVfcG93ZXJfc2FtcGxlICp0MCwKPiArCQkJ CSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyX3NhbXBsZSAqdDEpCj4gK3sKPiArCXJldHVybiAodDEt PnRpbWUgLSB0MC0+dGltZSkgKiAxZS05Owo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5saW5lIGRvdWJs ZSBncHVfcG93ZXJfVyhjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2VyICpwLAo+ICsJCQkJIGNvbnN0IHN0 cnVjdCBncHVfcG93ZXJfc2FtcGxlICp0MCwKPiArCQkJCSBjb25zdCBzdHJ1Y3QgZ3B1X3Bvd2Vy X3NhbXBsZSAqdDEpCj4gK3sKPiArCXJldHVybiBncHVfcG93ZXJfSihwLCB0MCwgdDEpIC8gZ3B1 X3Bvd2VyX3MocCwgdDAsIHQxKTsKPiArfQo+ICsKPiArI2VuZGlmIC8qIElHVF9HUFVfUE9XRVJf SCAqLwo+IGRpZmYgLS1naXQgYS9saWIvbWVzb24uYnVpbGQgYi9saWIvbWVzb24uYnVpbGQKPiBp bmRleCAwZWI1NTg1ZDcuLjg5ZGUwNmU2OSAxMDA2NDQKPiAtLS0gYS9saWIvbWVzb24uYnVpbGQK PiArKysgYi9saWIvbWVzb24uYnVpbGQKPiBAQCAtOSw5ICs5LDExIEBAIGxpYl9zb3VyY2VzID0g Wwo+ICAgCSdpZ3RfZGVidWdmcy5jJywKPiAgIAknaWd0X2RldmljZS5jJywKPiAgIAknaWd0X2F1 eC5jJywKPiArCSdpZ3RfZ3B1X3Bvd2VyLmMnLAo+ICAgCSdpZ3RfZ3QuYycsCj4gICAJJ2lndF9n dnQuYycsCj4gICAJJ2lndF9tYXRyaXguYycsCj4gKwknaWd0X3BlcmYuYycsCj4gICAJJ2lndF9w cmltZXMuYycsCj4gICAJJ2lndF9yYW5kLmMnLAo+ICAgCSdpZ3Rfc3RhdHMuYycsCj4gCgpOaXRw aWNrcyBvciBub3Q6CgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pZ3QtZGV2