Re: [igt-dev] [PATCH v2] tests/i915_pm_rpm: improved strictness and verbosity of i2c subtest

Vasilev, Oleg
2019-06-17T10:05:33Z

[-- Attachment #1.1: Type: text/plain, Size: 1047 bytes --]

Hi,

Thank you for the review. I've sent an updated patch.

On Fri, 2019-06-14 at 18:30 +0300, Ville Syrjälä wrote:
> On Thu, Jun 13, 2019 at 04:06:23PM +0300, Oleg Vasilev wrote:
> >
> > +static void format_hex_string(unsigned char edid[static
> > EDID_LENGTH],
> > + char buf[static EDID_LENGTH * 5 + 1])
>
> What's the deal with those 'static's?

This enforces an array size to be at least EDID_LENGTH.

https://hamberg.no/erlend/posts/2013-02-18-static-array-indices.html

>
> The kernel does modify the reported EDID for some quirks IIRC. I
> don't
> really like that behaviour, and it would be an issue for this test.
> But
> I guess we don't have any of those on any monitors we test.

I guess, if we see the regression like this, the test should be further
updated in order to handle those cases.

Oleg

>
> Apart from the minor nits looks good to me.
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>
> > }
> >
> > static void setup_pc8(void)
> > --
> > 2.21.0

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3261 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]