From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Brian Welty <brian.welty@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] intel-gpu-top: Support for client stats
Date: Mon, 16 Dec 2019 14:11:53 +0000 [thread overview]
Message-ID: <e01d7d43-9592-4a9c-dbd3-392b3e37407c@linux.intel.com> (raw)
In-Reply-To: <157650281113.2428.13876026348312542903@skylake-alporthouse-com>
On 16/12/2019 13:26, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-12-16 12:09:23)
>> +static void __restore_stats(void)
>> +{
>> + int ret;
>> +
>> + if (__stats_enabled)
>> + return;
>> +
>> + ret = __set_stats(false);
>
> Therein lies the problem with a global toggle. :(
Inverted check bug, okay. :) But yes, global toggle is a bit of a silly
thing.
> Hmm, if our stats toggling is always in process_csb() responding to
> events, they shouldn't affect execution latency... I think you have made
> them cheap enough to consider always enabling. Let's see.
I think they will be. Didn't spot anything in casual testing but can do
more pathological cases if you want.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-16 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:09 [igt-dev] [PATCH i-g-t 0/1] intel_gpu_top per client engine busyness Tvrtko Ursulin
2019-12-16 12:09 ` [igt-dev] [PATCH i-g-t 1/1] intel-gpu-top: Support for client stats Tvrtko Ursulin
2019-12-16 13:26 ` Chris Wilson
2019-12-16 14:11 ` Tvrtko Ursulin [this message]
2019-12-16 18:23 ` [igt-dev] [PATCH] " Tvrtko Ursulin
2019-12-16 14:52 ` [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top per client engine busyness Patchwork
2019-12-16 16:44 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-16 18:53 ` [igt-dev] ✓ Fi.CI.BAT: success for intel_gpu_top per client engine busyness (rev2) Patchwork
2019-12-17 0:24 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-09-04 13:06 [Intel-gfx] [PATCH i-g-t 0/1] Per client engine busyness for intel_gpu_top Tvrtko Ursulin
2020-09-04 13:06 ` [igt-dev] [PATCH i-g-t 1/1] intel-gpu-top: Support for client stats Tvrtko Ursulin
2020-09-07 9:31 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e01d7d43-9592-4a9c-dbd3-392b3e37407c@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=brian.welty@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox