From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0704C6E9AF for ; Thu, 3 Dec 2020 12:13:38 +0000 (UTC) From: "Shankar, Uma" Date: Thu, 3 Dec 2020 12:13:33 +0000 Message-ID: References: <20201110050334.2747067-1-kunal1.joshi@intel.com> In-Reply-To: <20201110050334.2747067-1-kunal1.joshi@intel.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_color_chamelium: time optimization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Joshi, Kunal1" , "igt-dev@lists.freedesktop.org" Cc: "Latvala, Petri" List-ID: > -----Original Message----- > From: Joshi, Kunal1 > Sent: Tuesday, November 10, 2020 10:34 AM > To: igt-dev@lists.freedesktop.org > Cc: Latvala, Petri ; Shankar, Uma > ; B S, Karthik ; Joshi, Kunal1 > > Subject: [PATCH i-g-t] tests/kms_color_chamelium: time optimization > > Instead of going through all the delta even if we got success with one, now > breaking when we pass, thus saving some time and decreasing load on > chamelium for capturing the rest of the frames. Looks Good to me. Reviewed-by: Uma Shankar > Signed-off-by: Kunal Joshi > --- > tests/kms_color_chamelium.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/tests/kms_color_chamelium.c b/tests/kms_color_chamelium.c index > 310c021a..43bbe1f2 100644 > --- a/tests/kms_color_chamelium.c > +++ b/tests/kms_color_chamelium.c > @@ -610,9 +610,9 @@ run_tests_for_pipe(data_t *data, enum pipe p) > expected_colors[1].g = > expected_colors[2].b = > 0.25 + delta * (i - 2); > - success |= test_pipe_ctm(data, primary, > - red_green_blue, > - expected_colors, ctm); > + if(test_pipe_ctm(data, primary, red_green_blue, > + expected_colors, ctm)) > + break; > } > igt_assert(success); > } > @@ -632,9 +632,9 @@ run_tests_for_pipe(data_t *data, enum pipe p) > expected_colors[1].g = > expected_colors[2].b = > 0.5 + delta * (i - 2); > - success |= test_pipe_ctm(data, primary, > - red_green_blue, > - expected_colors, ctm); > + if(test_pipe_ctm(data, primary, red_green_blue, > + expected_colors, ctm)) > + break; > } > igt_assert(success); > } > @@ -654,9 +654,9 @@ run_tests_for_pipe(data_t *data, enum pipe p) > expected_colors[1].g = > expected_colors[2].b = > 0.75 + delta * (i - 3); > - success |= test_pipe_ctm(data, primary, > - red_green_blue, > - expected_colors, ctm); > + if(test_pipe_ctm(data, primary, red_green_blue, > + expected_colors, ctm)) > + break; > } > igt_assert(success); > } > -- > 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev