Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Hajda <andrzej.hajda@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Subject: Re: [PATCH i-g-t 1/2] lib/intel_cmds_info: Remove duplicate block-copy tiling definition
Date: Thu, 20 Jun 2024 14:27:50 +0200	[thread overview]
Message-ID: <e14a02c7-ebc6-49d7-b455-badb14912b96@intel.com> (raw)
In-Reply-To: <20240620094822.524239-1-zbigniew.kempczynski@intel.com>



On 20.06.2024 11:48, Zbigniew Kempczyński wrote:
> Block-copy definition for Xe2 duplicates DG2+ so remove it.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>

Regards
Andrzej
> ---
>   lib/intel_cmds_info.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/lib/intel_cmds_info.c b/lib/intel_cmds_info.c
> index 1416e02cd4..d581edb6eb 100644
> --- a/lib/intel_cmds_info.c
> +++ b/lib/intel_cmds_info.c
> @@ -64,11 +64,6 @@ static const struct blt_cmd_info
>   						 BLT_CMD_EXTENDED |
>   						 BLT_CMD_SUPPORTS_COMPRESSION);
>   
> -static const struct blt_cmd_info
> -		xe2_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY, TILE_L_X_4_64,
> -						 BLT_CMD_EXTENDED |
> -						 BLT_CMD_SUPPORTS_COMPRESSION);
> -
>   static const struct blt_cmd_info
>   		mtl_xy_block_copy = BLT_INFO_EXT(XY_BLOCK_COPY, TILE_L_X_4_64,
>   						 BLT_CMD_EXTENDED);
> @@ -183,7 +178,7 @@ const struct intel_cmds_info gen12_pvc_cmds_info = {
>   const struct intel_cmds_info xe2_cmds_info  = {
>   	.blt_cmds = {
>   		[XY_FAST_COPY] = &dg2_xy_fast_copy,
> -		[XY_BLOCK_COPY] = &xe2_xy_block_copy,
> +		[XY_BLOCK_COPY] = &dg2_xy_block_copy,
>   		[MEM_COPY] = &pvc_mem_copy,
>   		[MEM_SET] = &pvc_mem_set,
>   	},


  parent reply	other threads:[~2024-06-20 12:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20  9:48 [PATCH i-g-t 1/2] lib/intel_cmds_info: Remove duplicate block-copy tiling definition Zbigniew Kempczyński
2024-06-20  9:48 ` [PATCH i-g-t 2/2] lib/intel_device_info: Add blitter/render definition for BMG Zbigniew Kempczyński
2024-06-20 10:40   ` Kamil Konieczny
2024-06-20 12:28   ` Andrzej Hajda
2024-06-20 10:34 ` [PATCH i-g-t 1/2] lib/intel_cmds_info: Remove duplicate block-copy tiling definition Kamil Konieczny
2024-06-20 12:27 ` Andrzej Hajda [this message]
2024-06-20 14:58 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2024-06-20 15:00 ` ✓ CI.xeBAT: " Patchwork
2024-06-20 16:27 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-20 20:44 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e14a02c7-ebc6-49d7-b455-badb14912b96@intel.com \
    --to=andrzej.hajda@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox