From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Gupta, Nidhi1" <nidhi1.gupta@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic
Date: Thu, 23 Jun 2022 14:37:12 +0530 [thread overview]
Message-ID: <e152fb1c-e7d0-2427-5564-37df417c5772@intel.com> (raw)
In-Reply-To: <YrQVy1l/4gh9vHqB@platvala-desk.ger.corp.intel.com>
On Thu-23-06-2022 12:57 pm, Petri Latvala wrote:
> On Thu, Jun 23, 2022 at 11:43:01AM +0530, Modem, Bhanuprakash wrote:
>> On Thu-23-06-2022 11:25 am, Gupta, Nidhi1 wrote:
>>> Hi Bhanu,
>>>
>>> In many tests we are using drm calls, like drmModePageFlip, drmModeSetCrtc, if I will replace it with igt wrapper it will increase the code lines, should I still change it?
>>
>> It's fine to increase the number of lines of code. The idea is to use IGT
>> wrappers wherever it's possible, since IGT helpers were developed
>> purposefully and more handy.
>>
>> Ofcourse, in some tests it is not possible to use these IGT helpers, ex:
>> kms_setmode.
>>
>> @Petri, any thoughts?
>
> When possible, igt wrappers should be preferred, yes.
Thanks Petri,
@Nidhi, please plan to fix as part of cleanup.
>
>
next prev parent reply other threads:[~2022-06-23 9:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 15:48 [igt-dev] [PATCH i-g-t 0/2] tests/kms_invalid_mode: Test Cleanup Nidhi Gupta
2022-06-22 15:48 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic Nidhi Gupta
2022-06-22 15:51 ` Petri Latvala
2022-06-23 2:41 ` Modem, Bhanuprakash
2022-06-23 5:55 ` Gupta, Nidhi1
2022-06-23 6:13 ` Modem, Bhanuprakash
2022-06-23 7:27 ` Petri Latvala
2022-06-23 9:07 ` Modem, Bhanuprakash [this message]
2022-06-22 15:48 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_invalid_mode: Test Cleanup Nidhi Gupta
2022-06-22 18:49 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-06-27 9:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-06-23 23:57 [igt-dev] [PATCH i-g-t 0/2] " Nidhi Gupta
2022-06-23 23:57 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic Nidhi Gupta
2022-06-24 5:09 ` Modem, Bhanuprakash
2022-06-27 7:07 [igt-dev] [PATCH i-g-t 0/2] tests/kms_invalid_mode: Test Cleanup Nidhi Gupta
2022-06-27 7:07 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic Nidhi Gupta
2022-06-27 7:23 ` Modem, Bhanuprakash
2022-06-27 9:54 [igt-dev] [PATCH i-g-t 0/2] tests/kms_invalid_mode: Test Cleanup Nidhi Gupta
2022-06-27 9:54 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic Nidhi Gupta
2022-06-28 13:32 [igt-dev] [PATCH i-g-t 0/2] tests/kms_invalid_mode: Test Cleanup Nidhi Gupta
2022-06-28 13:32 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic Nidhi Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e152fb1c-e7d0-2427-5564-37df417c5772@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nidhi1.gupta@intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox