From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: reduce work on framebuffer creation
Date: Fri, 31 Mar 2023 19:35:54 +0530 [thread overview]
Message-ID: <e172cb8d-8f14-f84b-d799-7daad7af6130@intel.com> (raw)
In-Reply-To: <20230321085732.29298-1-juhapekka.heikkila@gmail.com>
LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 21-Mar-23 2:27 PM, Juha-Pekka Heikkila wrote:
> There was created pattern framebuffers on tests which are not crc
> tests, change these to blank framebuffers.
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_plane_scaling.c | 38 +++++++++++++++++++-------------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 71586efba..fe695b684 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -719,10 +719,10 @@ static void setup_fb(int fd, int width, int height,
> double r, double g, double b,
> struct igt_fb *fb)
> {
> - igt_create_color_pattern_fb(fd, width, height,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR,
> - r, g, b, fb);
> + igt_create_fb(fd, width, height,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR,
> + fb);
> }
> static void
> @@ -803,21 +803,21 @@ test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
> plane[2] = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 2);
> igt_require(plane[2]);
> - igt_create_color_pattern_fb(display->drm_fd,
> - width, height,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR,
> - 1.0, 0.0, 0.0, &d->fb[0]);
> - igt_create_color_pattern_fb(display->drm_fd,
> - width, height,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR,
> - 0.0, 1.0, 0.0, &d->fb[1]);
> - igt_create_color_pattern_fb(display->drm_fd,
> - width, height,
> - DRM_FORMAT_XRGB8888,
> - DRM_FORMAT_MOD_LINEAR,
> - 0.0, 0.0, 1.0, &d->fb[2]);
> + igt_create_fb(display->drm_fd,
> + width, height,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR,
> + &d->fb[0]);
> + igt_create_fb(display->drm_fd,
> + width, height,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR,
> + &d->fb[1]);
> + igt_create_fb(display->drm_fd,
> + width, height,
> + DRM_FORMAT_XRGB8888,
> + DRM_FORMAT_MOD_LINEAR,
> + &d->fb[2]);
> igt_plane_set_fb(plane[0], &d->fb[0]);
> igt_plane_set_fb(plane[1], &d->fb[1]);
prev parent reply other threads:[~2023-03-31 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 8:57 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: reduce work on framebuffer creation Juha-Pekka Heikkila
2023-03-21 10:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-21 15:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-03-31 14:05 ` Sharma, Swati2 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e172cb8d-8f14-f84b-d799-7daad7af6130@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox