Re: [PATCH i-g-t v1] kms/feature_discovery: Add VRR capability subtest per output

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

Hi Sowmiya,

On 3/20/2026 11:23 AM, Naladala, Ramanaidu wrote:
> Hi Sowmiya,
>
> Thanks for the review.
>
> On 1/21/2026 10:28 AM, S, Sowmiya wrote:
>> Hi Ramanaidu,
>>
>>> -----Original Message-----
>>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of 
>>> Naladala
>>> Ramanaidu
>>> Sent: 21 January 2026 05:43
>>> To: igt-dev@lists.freedesktop.org
>>> Cc: Sharma, Swati2 <swati2.sharma@intel.com>; Naladala, Ramanaidu
>>> <ramanaidu.naladala@intel.com>
>>> Subject: [PATCH i-g-t v1] kms/feature_discovery: Add VRR capability 
>>> subtest per
>>> output
>>>
>>> Add a dynamic "vrr" subtest that checks vrr capability on each 
>>> connected
>>> output, skipping if the driver or output lacks VRR support.
>>>
>>> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
>>> ---
>>>   tests/kms_feature_discovery.c | 19 +++++++++++++++++++
>>>   1 file changed, 19 insertions(+)
>>>
>>> diff --git a/tests/kms_feature_discovery.c 
>>> b/tests/kms_feature_discovery.c
>>> index da80ecf66..bf36740cf 100644
>>> --- a/tests/kms_feature_discovery.c
>>> +++ b/tests/kms_feature_discovery.c
>>> @@ -60,6 +60,10 @@
>>>    * Description: Make sure that we have eDP panel with PSR2 support.
>>>    * Mega feature: PSR
>>>    *
>>> + * SUBTEST: vrr
>>> + * Description: Make sure that we have VRR support on output.
>>> + * Mega feature: Adaptive Sync
>>> + *
>>>    * SUBTEST: dp-mst
>>>    * Description: Make sure that we have DP-MST configuration.
>>>    *
>>> @@ -155,6 +159,21 @@ int igt_main() {
>>>               igt_require(psr_sink_support(fd, debugfs_fd,
>>> PSR_MODE_2, NULL));
>>>           }
>>>
>>> +        igt_describe("Make sure that we have VRR support on
>>> output.");
>> Use igt_skip_on_f, so only the current dynamic subtest is skipped, 
>> not the entire test.
>
> Sure, I will update the logic to use igt_skip_on_f.
When converting from igt_skip to igt_skip_on_if it introduced a 
LONG_LINE warning in checkpatch. To avoid this, I am proceeding with the 
if + igt_skip approach instead.
>
> FYI, Using igt_skip also skips only the current dynamic subtest, not 
> the entire test.
>
>>
>> Regards,
>> Sowmiya
>>
>>> +        igt_subtest_with_dynamic("vrr") {
>>> +            igt_output_t *output;
>>> +
>>> +            for_each_connected_output(&display, output) {
>>> +                igt_dynamic_f("%s", output->name) {
>>> +                    if (!igt_output_has_prop(output,
>>> IGT_CONNECTOR_VRR_CAPABLE))
>>> +                        igt_skip("Driver not supports
>>> VRR.\n");
>>> +
>>> +                    if (!igt_output_get_prop(output,
>>> IGT_CONNECTOR_VRR_CAPABLE))
>>> +                        igt_skip("Output not supports
>>> VRR.\n");
>>> +                }
>>> +            }
>>> +        }
>>> +
>>>           igt_describe("Make sure that we have DP-MST configuration.");
>>>           igt_subtest("dp-mst") {
>>>               struct kmstest_connector_config config;
>>> -- 
>>> 2.43.0
> Regards,
> Ramanaidu N.