From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH v2] i915/gem_mocs_settings: log the engine and MOCS index
Date: Wed, 31 Jul 2019 09:53:06 -0700 [thread overview]
Message-ID: <e1ccfecb-7646-d9b5-3203-ef0110c2ef96@intel.com> (raw)
In-Reply-To: <20190729212826.20852-1-lucas.demarchi@intel.com>
On 7/29/19 2:28 PM, Lucas De Marchi wrote:
> This helps to identify which entry is wrong in the table.
>
> v2: Add back the values and missing \n (from Daniele)
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Daniele
> ---
> tests/i915/gem_mocs_settings.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_mocs_settings.c b/tests/i915/gem_mocs_settings.c
> index 220cdddc..3ad94149 100644
> --- a/tests/i915/gem_mocs_settings.c
> +++ b/tests/i915/gem_mocs_settings.c
> @@ -366,10 +366,16 @@ static void check_control_registers(int fd,
>
> gem_set_domain(fd, dst_handle, I915_GEM_DOMAIN_CPU, 0);
> for (int index = 0; index < table.size; index++) {
> + uint32_t val, read_val;
> +
> if (!table.table[index].used)
> continue;
> - igt_assert_eq_u32(read_regs[index],
> - table.table[index].control_value);
> +
> + read_val = read_regs[index];
> + val = table.table[index].control_value;
> + igt_assert_f(read_val == val,
> + "engine=%u index=%u read_value=0x%08x value=0x%08x\n",
> + engine, index, read_val, val);
> }
>
> munmap(read_regs, 4096);
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-07-31 16:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:28 [igt-dev] [PATCH v2] i915/gem_mocs_settings: log the engine and MOCS index Lucas De Marchi
2019-07-29 23:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-07-30 6:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-07-31 16:53 ` Daniele Ceraolo Spurio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1ccfecb-7646-d9b5-3203-ef0110c2ef96@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox