Re: [PATCH i-g-t] tests/intel-ci: Add kms_sysfs_edid_timing to blocklist

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 2/18/2025 1:02 PM, Sharma, Swati2 wrote:
> Hi Kamil
>
> On 14-02-2025 04:15 pm, Kamil Konieczny wrote:
>> Hi Swati,
>> On 2025-02-13 at 18:58:02 +0530, Swati Sharma wrote:
>>> Add kms_sysfs_edid_timing to blocklist. Test was written with the
>>> idea that edid read shouldn't take an unreasonable amount of time.
>>> The timeout is an arbitrary value because it depends on when the
>>> display responds and, in some cases, especially when the display
>>> is coming back from sleep, it can take quite a while. This test
>>> has sporadic behavior across various platforms connected to
>>> different displays.
>>>
>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>>
>> Could such measurements be moved to tools into some generic one,
>> like display_wakeup or display_response?
> Even I had this proposal to move this test into tools.
> @ankit any feedback?

Perhaps there would be some value to have a tool to get the measurement.

I agree on adding the test to the CI blocklist to reduce noise due to 
this test.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>



>>
>> Regards,
>> Kamil
>>
>>> ---
>>>   tests/intel-ci/blacklist.txt    | 10 ++++++++++
>>>   tests/intel-ci/xe.blocklist.txt |  9 +++++++++
>>>   2 files changed, 19 insertions(+)
>>>
>>> diff --git a/tests/intel-ci/blacklist.txt 
>>> b/tests/intel-ci/blacklist.txt
>>> index 1236b8280..9917bf46a 100644
>>> --- a/tests/intel-ci/blacklist.txt
>>> +++ b/tests/intel-ci/blacklist.txt
>>> @@ -151,3 +151,13 @@ igt@kms_ccs@.*-4-tiled-xe2-ccs
>>>   igt@kms_frontbuffer_tracking@plane-fbc-rte
>>>   igt@kms_pm_dc@deep-pkgc
>>>   igt@kms_vrr@cmrr
>>> +
>>> +###############################################
>>> +# Test was written with the idea that edid read shouldn't take an
>>> +# unreasonable amount of time. The timeout is an arbitrary value
>>> +# because it depends on when the display responds and, in some cases,
>>> +# especially when the display is coming back from sleep, it can take
>>> +# quite a while. This test has sporadic behavior across various
>>> +# platforms connected to different displays.
>>> +###############################################
>>> +igt@kms_sysfs_edid_timing
>>> diff --git a/tests/intel-ci/xe.blocklist.txt 
>>> b/tests/intel-ci/xe.blocklist.txt
>>> index 6964628f1..80ceba9a5 100644
>>> --- a/tests/intel-ci/xe.blocklist.txt
>>> +++ b/tests/intel-ci/xe.blocklist.txt
>>> @@ -80,6 +80,15 @@ igt@kms_pm_rpm@cursor.*
>>> ##################################################################
>>>   igt@kms_prime@.*
>>> ##################################################################
>>> +# KMS: Test was written with the idea that edid read shouldn't take an
>>> +# unreasonable amount of time. The timeout is an arbitrary value
>>> +# because it depends on when the display responds and, in some cases,
>>> +# especially when the display is coming back from sleep, it can take
>>> +# quite a while. This test has sporadic behavior across various
>>> +# platforms connected to different displays.
>>> +##################################################################
>>> +igt@kms_sysfs_edid_timing
>>> +##################################################################
>>>   # KMS: Non-Intel tests
>>> ##################################################################
>>>   igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot
>>> -- 
>>> 2.25.1
>>>
>