Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Maaz Mombasawala (VMware)" <maazm@fastmail.com>
To: Zack Rusin <zackr@vmware.com>, igt-dev@lists.freedesktop.org
Cc: krastevm@vmware.com, mombasawalam@vmware.com,
	petri.latvala@intel.com, banackm@vmware.com
Subject: Re: [igt-dev] [PATCH i-g-t v2 8/8] lib/igt_kms: vmwgfx returns 8 crtc
Date: Thu, 16 Mar 2023 10:39:39 -0700	[thread overview]
Message-ID: <e21a9702-e160-3c8a-4577-8afd28268a5b@fastmail.com> (raw)
In-Reply-To: <20230316022659.73202-9-zack@kde.org>

LGTM!

Reviewed-by: Maaz Mombasawala <mombasawalam@vmware.com>

--

Maaz Mombasawala (VMware) <maazm@fastmail.com>


On 3/15/23 19:26, Zack Rusin wrote:
> From: Zack Rusin <zackr@vmware.com>
>
> To avoid crashes in multiple tests we need to extend the number of
> available pipe's to match the numbers returned by the virtualized drivers.
>
> Signed-off-by: Zack Rusin <zackr@vmware.com>
> ---
>   lib/igt_kms.c | 2 +-
>   lib/igt_kms.h | 2 ++
>   2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 8c7dd85b..d2e9eccc 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -839,7 +839,7 @@ static igt_plane_t *igt_get_assigned_primary(igt_output_t *output, igt_pipe_t *p
>    */
>   const char *kmstest_pipe_name(enum pipe pipe)
>   {
> -	static const char str[] = "A\0B\0C\0D\0E\0F";
> +	static const char str[] = "A\0B\0C\0D\0E\0F\0G\0H";
>   
>   	_Static_assert(sizeof(str) == IGT_MAX_PIPES * 2,
>   		       "Missing pipe name");
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index be5482e0..64807a7f 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -62,6 +62,8 @@ enum pipe {
>           PIPE_D,
>           PIPE_E,
>           PIPE_F,
> +	PIPE_G,
> +	PIPE_H,
>           IGT_MAX_PIPES
>   };
>   const char *kmstest_pipe_name(enum pipe pipe);

  parent reply	other threads:[~2023-03-16 17:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16  2:26 [igt-dev] [PATCH i-g-t v2 0/8] Add vmwgfx support Zack Rusin
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 1/8] igt/vmwgfx: Add generated headers for svga device Zack Rusin
     [not found]   ` <DM6PR05MB7099753BF0C4C180B50FE6F5AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 13:03     ` Martin Krastev (VMware)
2023-03-20 17:08       ` Kamil Konieczny
2023-03-17 16:52   ` Kamil Konieczny
2023-03-17 19:34     ` Zack Rusin
2023-04-03 12:57       ` Kamil Konieczny
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 2/8] igt/vmwgfx: Add vmwgfx support Zack Rusin
     [not found]   ` <DM6PR05MB7099CE80747EDA8D25FA1B80AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 13:17     ` Martin Krastev (VMware)
2023-03-17  8:12   ` Petri Latvala
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 3/8] igt/vmwgfx: Add triangle test Zack Rusin
     [not found]   ` <DM6PR05MB7099906944F388E2AF52683CAEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 13:37     ` Martin Krastev (VMware)
2023-03-17 16:58   ` Kamil Konieczny
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 4/8] igt/vmwgfx: Add execution buffer test Zack Rusin
     [not found]   ` <DM6PR05MB7099387153CDB475DEC7D7A4AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 13:55     ` Martin Krastev (VMware)
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 5/8] igt/vmwgfx: Add surface copy test Zack Rusin
     [not found]   ` <DM6PR05MB7099EFBC41B5FCEE66C80C44AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 14:08     ` Martin Krastev (VMware)
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 6/8] igt/vmwgfx: Add mob stress test Zack Rusin
     [not found]   ` <DM6PR05MB70993CAD6D2EF2959A0522F8AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 14:13     ` Martin Krastev (VMware)
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 7/8] igt/vmwgfx: Add reference counting tests Zack Rusin
     [not found]   ` <DM6PR05MB70999D64A5D5DC1B22771866AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 14:22     ` Martin Krastev (VMware)
2023-03-16  2:26 ` [igt-dev] [PATCH i-g-t v2 8/8] lib/igt_kms: vmwgfx returns 8 crtc Zack Rusin
     [not found]   ` <DM6PR05MB70990327C01C62C72489C001AEBC9@DM6PR05MB7099.namprd05.prod.outlook.com>
2023-03-16 14:25     ` Martin Krastev (VMware)
2023-03-16 17:39   ` Maaz Mombasawala (VMware) [this message]
2023-03-16  3:07 ` [igt-dev] ✓ Fi.CI.BAT: success for Add vmwgfx support (rev2) Patchwork
2023-03-16  8:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e21a9702-e160-3c8a-4577-8afd28268a5b@fastmail.com \
    --to=maazm@fastmail.com \
    --cc=banackm@vmware.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=krastevm@vmware.com \
    --cc=mombasawalam@vmware.com \
    --cc=petri.latvala@intel.com \
    --cc=zackr@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox