From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F49F6EB2E for ; Fri, 20 Mar 2020 13:04:23 +0000 (UTC) From: "Kahola, Mika" Date: Fri, 20 Mar 2020 13:03:45 +0000 Message-ID: References: <20200319140608.25405-1-juhapekka.heikkila@gmail.com> In-Reply-To: <20200319140608.25405-1-juhapekka.heikkila@gmail.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Juha-Pekka Heikkila , "igt-dev@lists.freedesktop.org" List-ID: -----Original Message----- From: igt-dev On Behalf Of Juha-Pekka Heikkila Sent: Thursday, March 19, 2020 4:06 PM To: igt-dev@lists.freedesktop.org Subject: [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows Change test initialization so CRC buffer will not become full on slower machines. v2: don't waste time by draining crcs unnecessarily. Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Mika Kahola --- tests/kms_plane_multiple.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c index 255cd34a..3c503c26 100644 --- a/tests/kms_plane_multiple.c +++ b/tests/kms_plane_multiple.c @@ -121,8 +121,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe, ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC); igt_skip_on(ret != 0); - igt_pipe_crc_start(data->pipe_crc); - igt_pipe_crc_get_single(data->pipe_crc, &data->ref_crc); + igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc); } static void @@ -330,6 +329,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, igt_output_name(output), kmstest_pipe_name(pipe), c, info, opt.seed); + igt_pipe_crc_start(data->pipe_crc); + i = 0; while (i < iterations || loop_forever) { /* randomize planes and set up the holes */ -- 2.17.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev