[igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Avoid CRC buffer overflows

Juha-Pekka Heikkila
2020-03-19T14:07:01Z

Change test initialization so CRC buffer will not become full
on slower machines.

v2: don't waste time by draining crcs unnecessarily.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_plane_multiple.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 255cd34a..3c503c26 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -121,8 +121,7 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
igt_skip_on(ret != 0);

- igt_pipe_crc_start(data->pipe_crc);
- igt_pipe_crc_get_single(data->pipe_crc, &data->ref_crc);
+ igt_pipe_crc_collect_crc(data->pipe_crc, &data->ref_crc);
}

static void
@@ -330,6 +329,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
igt_output_name(output), kmstest_pipe_name(pipe), c,
info, opt.seed);

+ igt_pipe_crc_start(data->pipe_crc);
+
i = 0;
while (i < iterations || loop_forever) {
/* randomize planes and set up the holes */
--
2.17.1