Hi JP,

On 9/12/2024 8:16 PM, Juha-Pekka Heikkila wrote:
> On Intel Xe2 hw Tile4 no longer can be used with horizontal flip on display.
> bspec 69853
>
> Signed-off-by: Juha-Pekka Heikkila<juhapekka.heikkila@gmail.com>
> ---
>   tests/kms_rotation_crc.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 8d8c53b5f..3e9190590 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -639,6 +639,12 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
>   			    !IS_CHERRYVIEW(data->devid) ||
>   			    data->rotation != (IGT_ROTATION_180 | IGT_REFLECT_X));
>   
> +		/* Intel Xe2 onwards cannot do reflect tile4 */
> +		igt_require(!is_intel_device(data->gfx_fd) ||
> +			    intel_gen(data->devid) < 20 ||
> +			    !(data->override_modifier == I915_FORMAT_MOD_4_TILED &&
> +			    data->rotation&IGT_REFLECT_X));
> +
As per BSpec (69853) up to XE2, horizontal flip is not supported with 
linear surface formats. If it is valid to add that check, please do so.
>   		prepare_crtc(data, output, pipe, plane, true);
>   
>   		for (i = 0; i < num_rectangle_types; i++) {