Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

Daniel Vetter
2019-04-25T13:46:45Z

On Thu, Apr 25, 2019 at 02:45:12PM +0300, Petri Latvala wrote:
> On Thu, Apr 25, 2019 at 09:35:25AM +0200, Daniel Vetter wrote:
> > On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > > Clang builds healthy.
> > >
> > > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > > ---
> > > .gitlab-ci.yml | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index ae8cbb67..e7d31376 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > > - ninja -C build
> > > - ninja -C build igt-gpu-tools-doc
> > >
> > > +build:tests-fedora-clang:
> > > + stage: build
> > > + script:
> > > + - dnf install -y clang
> > > + - export CC=clang
> > > + - meson $MESON_OPTIONS build
> > > + - ninja -C build
> >
> > Uh why?
> >
> > The thing that broken is building on non-x86 hosts, and that's the thing
> > gitlab CI caught. I have no idea why this is all about clang (imo it's
> > not), and I don't think we should care about clang either.
>
>
> Consider this patch as a separate thing instead of getting stuck on
> the recent build failure.
>
> The current state is that clang builds IGT fine. The discussion would
> be different if it didn't. I use clang myself occasionally, although
> indirectly, through clang-analyze. It works, there's non-zero value in
> keeping it working, and as just a build-test for clang this doesn't
> eat that much gitlab-ci-time.
>
>
> This is
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> but I'll leave actual doublechecking of the CI change correctness to
> someone else (Arek?)

I'd say if we want to support clang (personally I really dont care, and
clang isn't going to work with the kernel anytime soon so it's not we can
ditch gcc), then the gitlab CI should also run the tests. That's the same
standard as we have for the non-x86 builds (yes we run them through qemu
machine emulation to get arm/arm64 going on our x86 builders).

With that I can also slap my Acked-by: Daniel Vetter
<daniel.vetter@ffwll.ch> onto the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation