Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

Ser, Simon
2019-04-25T11:22:59Z

On Thu, 2019-04-25 at 09:35 +0200, Daniel Vetter wrote:
> On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> > This adds a build step with Clang on Fedora. Hopefully this can help keeping
> > Clang builds healthy.
> >
> > Signed-off-by: Simon Ser <simon.ser@intel.com>
> > ---
> > .gitlab-ci.yml | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index ae8cbb67..e7d31376 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> > - ninja -C build
> > - ninja -C build igt-gpu-tools-doc
> >
> > +build:tests-fedora-clang:
> > + stage: build
> > + script:
> > + - dnf install -y clang
> > + - export CC=clang
> > + - meson $MESON_OPTIONS build
> > + - ninja -C build
>
> Uh why?
>
> The thing that broken is building on non-x86 hosts, and that's the thing
> gitlab CI caught. I have no idea why this is all about clang (imo it's
> not), and I don't think we should care about clang either.
> -Daniel

Well I didn't know it was broken on non-x86 hosts. I submitted the
patch because I use Clang and it broke on my machine.

I do think there is value in supporting Clang, just not to be trapped
forever with GCC. It's not like it's a huge hassle either since Clang
implements the huge pile of GNU extensions GCC has (sadly).

> > +
> > build:tests-debian-meson:
> > image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> > stage: build
> > --
> > 2.21.0
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev