Re: [igt-dev] [PATCH i-g-t] ci: build with Clang

Arkadiusz Hiler
2019-04-25T13:50:55Z

On Wed, Apr 24, 2019 at 07:15:26PM +0300, Simon Ser wrote:
> This adds a build step with Clang on Fedora. Hopefully this can help keeping
> Clang builds healthy.
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> ---
> .gitlab-ci.yml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index ae8cbb67..e7d31376 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -47,6 +47,14 @@ build:tests-fedora-oldest-meson:
> - ninja -C build
> - ninja -C build igt-gpu-tools-doc
>
> +build:tests-fedora-clang:
> + stage: build
> + script:
> + - dnf install -y clang

From experience, this is going to be quite slow - packages indexes will
get updated basically every run, and it may cause random failures of the
build step.

I think it would be better to stick to:

diff --git a/Dockerfile.fedora b/Dockerfile.fedora
index 29520f7b..d48d16fc 100644
--- a/Dockerfile.fedora
+++ b/Dockerfile.fedora
@@ -35,6 +35,9 @@ RUN tar xf peg-0.1.18.tar.gz
RUN cd peg-0.1.18 && make PREFIX=/usr install
RUN rm -fr /tmp/peg

+# For clang compilation-testing
+RUN dnf install -y clang
+
# Meson version switching shenanigans
WORKDIR /usr/src
RUN curl -O https://files.pythonhosted.org/packages/17/d0/0fe98a9557a2f07dbe6f99ef57f2bc37450b641e1f6ceae9ce04c3c845dd/meson-0.46.0.tar.gz