From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Caz Yokoyama <caz.yokoyama@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [igt PATCH v1 1/1] i915/gem_ctx_switch: evenly run 4 child processes
Date: Fri, 22 Feb 2019 17:09:32 -0800 [thread overview]
Message-ID: <e4b81a3e-4f08-58a6-fa43-a4b5c6712955@intel.com> (raw)
In-Reply-To: <3c1d471aaff359e7dc2c9c7d34325e78858f0913.1550904761.git.caz.yokoyama@intel.com>
On 22/02/19 22:54, Caz Yokoyama wrote:
> gem_ctx_switch@basic-all-light test creates 4 child processes for each
> engine and wait. render engine runs slower than others. By this patch,
> 4 child processes run fairly evenly. As a result, parent process runs
> faster. On my NUC, its execution time becomes about half.
>
> Signed-off-by: Caz Yokoyama <caz.yokoyama@intel.com>
> ---
> tests/i915/gem_ctx_switch.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_switch.c b/tests/i915/gem_ctx_switch.c
> index 1208cb8d..9ed22f35 100644
> --- a/tests/i915/gem_ctx_switch.c
> +++ b/tests/i915/gem_ctx_switch.c
> @@ -247,7 +247,9 @@ static void all(int fd, uint32_t handle, unsigned flags, int timeout)
>
> clock_gettime(CLOCK_MONOTONIC, &start);
> do {
> - for (int loop = 0; loop < qlen; loop++) {
> + int x = strcmp(name[child], "render") == 0 ? qlen/2 : qlen;
> +
> + for (int loop = 0; loop < x; loop++) {
Beware that count becomes incorrect. It should be:
count += x;
Antonio
> execbuf.rsvd1 = contexts[loop % nctx];
> gem_execbuf(fd, &execbuf);
> }
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-23 1:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 6:54 [igt-dev] [igt PATCH v1 1/1] i915/gem_ctx_switch: evenly run 4 child processes Caz Yokoyama
2019-02-23 0:25 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v1,1/1] " Patchwork
2019-02-23 0:41 ` [igt-dev] [igt PATCH v1 1/1] " Chris Wilson
2019-02-26 16:07 ` Caz Yokoyama
2019-02-23 1:09 ` Antonio Argenziano [this message]
2019-02-23 1:34 ` [igt-dev] [PATCH i-g-t] i915/gem_ctx_switch: Use minimum qlen over all engines and measure switches Chris Wilson
2019-02-25 18:28 ` Caz Yokoyama
2019-02-25 18:29 ` [Intel-gfx] " Chris Wilson
2019-02-26 16:14 ` [igt-dev] " Caz Yokoyama
2019-02-26 16:15 ` Chris Wilson
2019-02-23 2:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t] i915/gem_ctx_switch: Use minimum qlen over all engines and measure switches (rev2) Patchwork
2019-02-23 6:42 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [v1,1/1] i915/gem_ctx_switch: evenly run 4 child processes Patchwork
2019-02-23 9:31 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t] i915/gem_ctx_switch: Use minimum qlen over all engines and measure switches (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b81a3e-4f08-58a6-fa43-a4b5c6712955@intel.com \
--to=antonio.argenziano@intel.com \
--cc=caz.yokoyama@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox