Re: [PATCH i-g-t v2 1/2] lib/igt_kms: Add lowclk and highclk modes

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

Hi Santhosh,

Imho,  rewrite the git subject something like, "Add helpers to fetch 
lowest and highest pixel clock modes"

On 3/17/2026 11:00 AM, Santhosh Reddy Guddati wrote:
> Introduce functions to return low clock and high clock modes when
> connector supports multiple modes.This sorts connector modes by display
> clock rather than resolution.
>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
>   lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
>   lib/igt_kms.h |  2 ++
>   2 files changed, 38 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 8c42909fc..2ba34b034 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -5198,6 +5198,42 @@ drmModeModeInfo *igt_output_get_lowres_mode(igt_output_t *output)
>   	return lowest_mode;
>   }
>   
> +/**
> + * igt_output_get_lowclk_mode:
> + * @output: Target output
> + *
> + * Returns: A #drmModeModeInfo struct representing the mode with the lowest
> + * pixel clock.
> + */
> +drmModeModeInfo *igt_output_get_lowclk_mode(igt_output_t *output)
> +{
> +	drmModeConnector *connector = output->config.connector;
> +
> +	igt_assert_f(connector->count_modes > 0, "No modes for %s\n", igt_output_name(output));
> +
> +	igt_sort_connector_modes(connector, sort_drm_modes_by_clk_asc);
> +
> +	return &connector->modes[0];
> +}
> +
> +/**
> + * igt_output_get_highclk_mode:
> + * @output: Target output
> + *
> + * Returns: A #drmModeModeInfo struct representing the mode with the highest
> + * pixel clock.
> + */
> +drmModeModeInfo *igt_output_get_highclk_mode(igt_output_t *output)
> +{
> +	drmModeConnector *connector = output->config.connector;
> +
> +	igt_assert_f(connector->count_modes > 0, "No modes for %s\n", igt_output_name(output));
> +
> +	igt_sort_connector_modes(connector, sort_drm_modes_by_clk_dsc);
> +
> +	return &connector->modes[0];
> +}
> +
>   /**
>    * igt_output_override_mode:
>    * @output: Output of which the mode will be overridden
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index b3def1e73..6c8e60f02 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -604,6 +604,8 @@ bool kmstest_mode_is_valid(const drmModeModeInfo *mode);
>   drmModeModeInfo *igt_output_get_mode(igt_output_t *output);
>   drmModeModeInfo *igt_output_get_highres_mode(igt_output_t *output);
>   drmModeModeInfo *igt_output_get_lowres_mode(igt_output_t *output);
> +drmModeModeInfo *igt_output_get_lowclk_mode(igt_output_t *output);
> +drmModeModeInfo *igt_output_get_highclk_mode(igt_output_t *output);
>   void igt_output_override_mode(igt_output_t *output, const drmModeModeInfo *mode);
>   int igt_output_preferred_vrefresh(igt_output_t *output);
>   void igt_output_set_crtc(igt_output_t *output, igt_crtc_t *crtc);