Re: [PATCH i-g-t 1/2] lib/igt_psr: Skip the test when PSR is disabled

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2025-07-15 at 13:38 +0200, Michał Grzelak wrote:
> If PSR setup timing is not met, then PSR will stay disabled and test
> will fail anyway. Skip the test upon finding that setup timing was
> not
> met.
> 
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>  lib/igt_psr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 3d8f1949b..f35051ebc 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -38,7 +38,7 @@ bool psr_disabled_check(int debugfs_fd)
>  	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status",
> buf,
>  				sizeof(buf));
>  
> -	return strstr(buf, "PSR mode: disabled\n");
> +	return strstr(buf, "PSR disabled:");

I think you should not change the format in this debugfs in your kernel
patch -> you could drop this change as well.

>  }
>  
>  bool selective_fetch_check(int debugfs_fd, igt_output_t *output)
> @@ -122,6 +122,8 @@ static bool psr_active_check(int debugfs_fd, enum
> psr_mode mode, igt_output_t *o
>  
>  	igt_skip_on(strstr(buf, "PSR sink not reliable: yes"));
>  
> +	igt_skip_on(strstr(buf, "PSR setup timing not met"));
> +

This would work if debugfs output is like this:

PSR mode: disabled (PSR setup timing not met)

BR,

Jouni Högander

>  	active = strstr(buf, state) ||
>  		 (c && (c->connector_type ==
> DRM_MODE_CONNECTOR_DisplayPort) &&
>  		  strstr(buf, "SU_STANDBY"));