From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A42C410E490 for ; Fri, 3 Nov 2023 08:05:06 +0000 (UTC) Message-ID: Date: Fri, 3 Nov 2023 13:34:45 +0530 To: Bhanuprakash Modem , References: <20231031110424.4127934-1-bhanuprakash.modem@intel.com> Content-Language: en-US From: Karthik B S In-Reply-To: <20231031110424.4127934-1-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t] tests/intel/kms_pm_lpsp: Fix test constraint for bigjoiner List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 10/31/2023 4:34 PM, Bhanuprakash Modem wrote: > If there is no Bigjoiner involved, the test constraint returns > 'false', which causes the test to be skipped. Fix the test > constraint logic to handle both bigjoiner & non-bigjoiner cases. > > Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/9340 > Signed-off-by: Bhanuprakash Modem Reviewed-by: Karthik B S > --- > tests/intel/kms_pm_lpsp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/intel/kms_pm_lpsp.c b/tests/intel/kms_pm_lpsp.c > index cb3c3e379..a85e4e795 100644 > --- a/tests/intel/kms_pm_lpsp.c > +++ b/tests/intel/kms_pm_lpsp.c > @@ -174,9 +174,11 @@ static bool test_constraint(data_t *data) > > return true; > } > + > + return false; > } > > - return false; > + return true; > } > > static void test_lpsp(data_t *data)