Re: [igt-dev] [i-g-t] tests/kms_addfb_basic: Use proper macro for invalid tests

[Karthik B S <karthik.b.s@intel.com>]

On 4/20/2023 5:36 PM, Bhanuprakash Modem wrote:
> For invalid tests, instead of using magic numbers use proper
> macros those are already defined in IGT lib.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_addfb_basic.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index a66ccfa6b..e4783624f 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -549,7 +549,7 @@ static void addfb25_tests(int fd)
>   	igt_subtest("addfb25-bad-modifier") {
>   		igt_require_fb_modifiers(fd);
>   
> -		f.modifier[0] = ~0;
> +		f.modifier[0] = DRM_FORMAT_MOD_INVALID;
>   		do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
>   	}
>   
> @@ -729,7 +729,7 @@ static void prop_tests(int fd)
>   
>   	igt_describe("Test that get-properties ioctl call fails correctly for invalid object type");
>   	igt_subtest("invalid-get-prop-any") {
> -		get_props.obj_type = 0; /* DRM_MODE_OBJECT_ANY */
> +		get_props.obj_type = DRM_MODE_OBJECT_ANY;
>   
>   		do_ioctl_err(fd, DRM_IOCTL_MODE_OBJ_GETPROPERTIES, &get_props, EINVAL);
>   	}
> @@ -747,7 +747,7 @@ static void prop_tests(int fd)
>   
>   	igt_describe("Test that set-properties ioctl call fails correctly for invalid object type");
>   	igt_subtest("invalid-set-prop-any") {
> -		set_prop.obj_type = 0; /* DRM_MODE_OBJECT_ANY */
> +		set_prop.obj_type = DRM_MODE_OBJECT_ANY;
>   
>   		do_ioctl_err(fd, DRM_IOCTL_MODE_OBJ_SETPROPERTY, &set_prop, EINVAL);
>   	}