Re: [PATCH v2 3/3] tests/intel/xe_exec_reset: Add multi-queue long spin tests

["Summers, Stuart" <stuart.summers@intel.com>]

On Thu, 2026-05-07 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> Add the following multi-queue tests and update xe_legacy_test_mode()
> function to use queue_timestamp and multi_queue_switch spinner
> options
> for the multi-queue scenarios.
> 
> multi-queue-long-spin-many-queue-switch
> multi-queue-long-spin-reuse-many-queue-switch
> 
> v2: Change test name and add documentation (Stuart)
> 
> Signed-off-by: Niranjana Vishwanathapura
> <niranjana.vishwanathapura@intel.com>

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  lib/xe/xe_legacy.c          |  2 ++
>  tests/intel/xe_exec_reset.c | 23 +++++++++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/lib/xe/xe_legacy.c b/lib/xe/xe_legacy.c
> index f9bd5bcb61..b7054756cd 100644
> --- a/lib/xe/xe_legacy.c
> +++ b/lib/xe/xe_legacy.c
> @@ -67,6 +67,8 @@ xe_legacy_test_mode(int fd, struct
> drm_xe_engine_class_instance *eci,
>         } *data;
>         struct xe_spin_opts spin_opts = {
>                 .preempt = flags & PREEMPT,
> +               .multi_queue_switch = flags & MULTI_QUEUE,
> +               .use_queue_timestamp = flags & MULTI_QUEUE,
>  #define THREE_SEC      (3 * 1000000000ull)
>                 .ctx_ticks = flags & LONG_SPIN ?
>                         xe_spin_nsec_to_ticks(fd, 0, THREE_SEC) : 0,
> diff --git a/tests/intel/xe_exec_reset.c
> b/tests/intel/xe_exec_reset.c
> index a3cf290abf..89a47d236f 100644
> --- a/tests/intel/xe_exec_reset.c
> +++ b/tests/intel/xe_exec_reset.c
> @@ -330,6 +330,12 @@ test_balancer(int fd, int gt, int class, int
> n_exec_queues, int n_execs,
>   * SUBTEST: long-spin-reuse-many-preempt-media
>   * Description: Test long spinners with many preemptable jobs, use
> queues again spinners complete on media GT
>   *
> + * SUBTEST: multi-queue-long-spin-many-queue-switch
> + * Description: Test long spinners with many jobs with multi-queue
> switching
> + *
> + * SUBTEST: multi-queue-long-spin-reuse-many-queue-switch
> + * Description: Test long spinners with many jobs with multi-queue
> switching, use queues again once spinners complete
> + *
>   * SUBTEST: gt-reset
>   * Description: Test GT reset
>   *
> @@ -1179,6 +1185,23 @@ int igt_main()
>                                           MULTI_QUEUE);
>         }
>  
> +       igt_subtest("multi-queue-long-spin-many-queue-switch")
> +               xe_for_each_multi_queue_engine(fd, hwe) {
> +                       xe_legacy_test_mode(fd, hwe, 4, 8,
> +                                           LONG_SPIN | MULTI_QUEUE,
> +                                           LEGACY_MODE_ADDR, false);
> +                       break;
> +               }
> +
> +       igt_subtest("multi-queue-long-spin-reuse-many-queue-switch")
> +               xe_for_each_multi_queue_engine(fd, hwe) {
> +                       xe_legacy_test_mode(fd, hwe, 4, 8,
> +                                           LONG_SPIN | MULTI_QUEUE |
> +                                           LONG_SPIN_REUSE_QUEUE,
> +                                           LEGACY_MODE_ADDR, false);
> +                       break;
> +               }
> +
>         igt_fixture()
>                 drm_close_driver(fd);
>  }